From: Jamal Hadi Salim <jhs@mojatatu•com>
To: Cong Wang <xiyou.wangcong@gmail•com>
Cc: Stephen Hemminger <stephen@networkplumber•org>,
Linux Kernel Network Developers <netdev@vger•kernel.org>,
David Miller <davem@davemloft•net>
Subject: Re: [Patch iproute2] u32: add terminal parameter
Date: Mon, 14 Apr 2014 19:14:38 -0400 [thread overview]
Message-ID: <534C6BDE.8020600@mojatatu.com> (raw)
In-Reply-To: <CAM_iQpXJnOOUbpS0WwrB7C50LGxcLhMEQPrDB84Zm-SLKVHh6w@mail.gmail.com>
On 04/14/14 17:18, Cong Wang wrote:
> On Sat, Apr 12, 2014 at 4:43 AM, Jamal Hadi Salim <jhs@mojatatu•com> wrote:
> Why? The qdisc my u32 filters attached to is classless (ingress).
flowid is a filter id. I am almost certain it was a mistake on your
part to leave it out. This is why i called it an FAQ and suggested
you provide a patch to block people from leaving it out.
> Also, why this is relevant to u32 terminal?
Because if you defined a flowid you are defining it as a terminal
u32 node. You wouldnt have to complain about "???" or produce a patch
to solve a non-existent problem.
You want to add a new syntax and didnt even bother to look at the code?
>> So I agree with Stephen on the verdict on your patch.
>> We need a patch to avoid this FAQ problem since it happens
>> often i.e reject a filter that doesnt have flow/classid
>> specified. How about you provide that patch instead?
>>
>
> Even if you were right, it is too late to change, we obviously don't
> want to break existing scripts that work fine. I am pretty sure
> my script runs well without flowid.
>
I dont think it can be guaranteed to work at all if you dont specify
a flowid. You may have gotten lucky.
cheers,
jamal
next prev parent reply other threads:[~2014-04-14 23:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 17:17 [Patch iproute2] u32: add terminal parameter Cong Wang
2014-04-11 21:04 ` Stephen Hemminger
2014-04-12 0:45 ` Cong Wang
2014-04-12 0:58 ` Stephen Hemminger
2014-04-12 1:15 ` Cong Wang
2014-04-12 11:43 ` Jamal Hadi Salim
2014-04-14 21:18 ` Cong Wang
2014-04-14 23:14 ` Jamal Hadi Salim [this message]
2014-04-15 1:57 ` Cong Wang
2014-04-15 13:00 ` Jamal Hadi Salim
2014-04-15 20:17 ` Cong Wang
2014-04-16 12:19 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534C6BDE.8020600@mojatatu.com \
--to=jhs@mojatatu$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox