From: Jamal Hadi Salim <jhs@mojatatu•com>
To: Cong Wang <xiyou.wangcong@gmail•com>,
Stephen Hemminger <stephen@networkplumber•org>
Cc: Linux Kernel Network Developers <netdev@vger•kernel.org>,
David Miller <davem@davemloft•net>
Subject: Re: [Patch iproute2] u32: add terminal parameter
Date: Sat, 12 Apr 2014 07:43:51 -0400 [thread overview]
Message-ID: <534926F7.10505@mojatatu.com> (raw)
In-Reply-To: <CAM_iQpU7Ntn-yo-ez0vP2BhKe+-Vaq1w_+MQhFPHM-bbQZx2gg@mail.gmail.com>
Cong,
You MUST specify flowid in your filter construct;->
So I agree with Stephen on the verdict on your patch.
We need a patch to avoid this FAQ problem since it happens
often i.e reject a filter that doesnt have flow/classid
specified. How about you provide that patch instead?
cheers,
jamal
On 04/11/14 21:15, Cong Wang wrote:
> On Fri, Apr 11, 2014 at 5:58 PM, Stephen Hemminger
> <stephen@networkplumber•org> wrote:
>> On Fri, 11 Apr 2014 17:45:53 -0700
>> Cong Wang <xiyou.wangcong@gmail•com> wrote:
>>> It's already there:
>>>
>>> } else if (sel && sel->flags&TC_U32_TERMINAL) {
>>> fprintf(f, "terminal flowid ??? ");
>>> }
>>
>> But it printing it like an error, not an known good option.
>> The ??? implies that somebody did something wrong.
>
> I don't know why ??? is displayed together with terminal, but
> nothing seems wrong here, check the output after I add
> a mirred action:
>
> filter protocol ip pref 49152 u32
> filter protocol ip pref 49152 u32 fh 800: ht divisor 1
> filter protocol ip pref 49152 u32 fh 800::800 order 2048 key ht 800
> bkt 0 terminal flowid ???
> match 01020304/ffffffff at 16
> action order 1: mirred (Egress Mirror to device virbr0) pipe
> index 1 ref 1 bind 1
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-04-12 11:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 17:17 [Patch iproute2] u32: add terminal parameter Cong Wang
2014-04-11 21:04 ` Stephen Hemminger
2014-04-12 0:45 ` Cong Wang
2014-04-12 0:58 ` Stephen Hemminger
2014-04-12 1:15 ` Cong Wang
2014-04-12 11:43 ` Jamal Hadi Salim [this message]
2014-04-14 21:18 ` Cong Wang
2014-04-14 23:14 ` Jamal Hadi Salim
2014-04-15 1:57 ` Cong Wang
2014-04-15 13:00 ` Jamal Hadi Salim
2014-04-15 20:17 ` Cong Wang
2014-04-16 12:19 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534926F7.10505@mojatatu.com \
--to=jhs@mojatatu$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox