From: Jiri Pirko <jiri@resnulli•us>
To: Scott Feldman <sfeldma@cumulusnetworks•com>
Cc: Roopa Prabhu <roopa@cumulusnetworks•com>,
Jamal Hadi Salim <jhs@mojatatu•com>,
netdev <netdev@vger•kernel.org>,
David Miller <davem@davemloft•net>,
Neil Horman <nhorman@tuxdriver•com>,
Andy Gospodarek <andy@greyhouse•net>, Thomas Graf <tgraf@suug•ch>,
dborkman <dborkman@redhat•com>, ogerlitz <ogerlitz@mellanox•com>,
jesse <jesse@nicira•com>, pshelar <pshelar@nicira•com>,
azhou <azhou@nicira•com>, Ben Hutchings <ben@decadent•org.uk>,
Stephen Hemminger <stephen@networkplumber•org>,
Jeff Kirsher <jeffrey.t.kirsher@intel•com>,
Vlad Yasevich <vyasevic@redhat•com>,
Cong Wang <xiyou.wangcong@gmail•com>,
John Fastabend <john.r.fastabend@intel•com>,
Eric Dumazet <edumazet@google•com>,
Florian Fainelli <f.fainelli@gmail•com>,
"John W. Linville" <linville@tuxdriver•com>,
dev@openvswitch•org, jasowang@redhat•com, ebiederm@xmission•com,
nicolas.dichtel@6wind•com, Sergey Ryazan
Subject: Re: [patch net-next v2 8/9] switchdev: introduce Netlink API
Date: Sat, 20 Sep 2014 19:38:54 +0200 [thread overview]
Message-ID: <20140920173854.GA1829@nanopsycho.orion> (raw)
In-Reply-To: <DCCFAE52-F4BD-4877-A6FC-3C3AE180E871@cumulusnetworks.com>
Sat, Sep 20, 2014 at 07:21:10PM CEST, sfeldma@cumulusnetworks•com wrote:
>
>On Sep 20, 2014, at 5:51 AM, Roopa Prabhu <roopa@cumulusnetworks•com> wrote:
>
>> On 9/20/14, 1:10 AM, Scott Feldman wrote:
>>> On Sep 19, 2014, at 8:41 PM, Roopa Prabhu <roopa@cumulusnetworks•com>
>>> wrote:
>>>
>>>
>>>> On 9/19/14, 8:49 AM, Jiri Pirko wrote:
>>>>
>>>>> Fri, Sep 19, 2014 at 05:25:48PM CEST, jhs@mojatatu•com
>>>>> wrote:
>>>>>
>>>>>> On 09/19/14 09:49, Jiri Pirko wrote:
>>>>>>
>>>>>>> This patch exposes switchdev API using generic Netlink.
>>>>>>> Example userspace utility is here:
>>>>>>>
>>>>>>> https://github.com/jpirko/switchdev
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> Is this just a temporary test tool? Otherwise i dont see reason
>>>>>> for its existence (or the API that it feeds on).
>>>>>>
>>>>> Please read the conversation I had with Pravin and Jesse in v1 thread.
>>>>> Long story short they like to have the api separated from ovs datapath
>>>>> so ovs daemon can use it to directly communicate with driver. Also John
>>>>> Fastabend requested a way to work with driver flows without using ovs ->
>>>>> that was the original reason I created switchdev genl api.
>>>>>
>>>>> Regarding the "sw" tool, yes it is for testing purposes now. ovs daemon
>>>>> will use directly switchdev genl api.
>>>>>
>>>>> I hope I cleared this out.
>>>>>
>>>> We already have all the needed rtnetlink kernel api and userspace tools around it to support all
>>>> switching asic features. ie, the rtnetlink api is the switchdev api. We can do l2, l3, acl's with it.
>>>> Its unclear to me why we need another new netlink api. Which will mean none of the existing tools to
>>>> create bridges etc will work on a switchdev.
>>>> Which seems like going in the direction exactly opposite to what we had discussed earlier.
>>>>
>>> Existing rtnetlink isn’t available to swdev without some kind of snooping the echoes from the various kernel components (bridge, fib, etc). With swdev_flow, as Jiri has defined it, there is an additional conversion needed to bridge the gap (bad expression, I know) between rtnetlink and swdev_flow. This conversion happens in the kernel components. For example, the bridge module, still driven from userspace by existing rtnetlink, will formulate the necessary swdev_flow insert/remove calls to the swdev driver such that HW will offload the fwd path.
>>>
>>> You have:
>>> user -> rtnetlink -> kernel -> netlink echo -> [some process] -> [some driver] -> HW
>>>
>>>
>>> Jiri has:
>>> user -> rtnetlink -> kernel -> swdev_* -> swdev driver -> HW
>>>
>>>
>> Keeping the goal to not change or not add a new userspace API in mind,
>> I have :
>> user -> rtnetlink -> kernel -> ndo_op -> swdev driver -> HW
>>
>
>Then you have the same as Jiri, for the traditional L2/L3 case.
>
>> Jiri has:
>> user -> genl (newapi) -> kernel -> swdev_* -> swdev driver -> HW
>
>Jiri’s genl is for userspace apps that are talking rtnetlink, like OVS. It’s not a substitute for rtnetlink, it’s an alternative. The complete picture is:
Not an alternative, an addition.
>
>user -> swdev genl -----
> \
> \
> -------> kernel -> ndo_swdev_* -> swdev driver -> HW
> /
> /
>user -> rtnetlink ------
True is that, as Thomas pointed out, we can probably nest this into
rtnl_link messages. That might work.
next prev parent reply other threads:[~2014-09-20 17:38 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 13:49 [patch net-next v2 0/9] introduce rocker switch driver with hardware accelerated datapath api Jiri Pirko
2014-09-19 13:49 ` [patch net-next v2 1/9] net: rename netdev_phys_port_id to more generic name Jiri Pirko
[not found] ` <1411134590-4586-2-git-send-email-jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>
2014-09-19 13:54 ` Jeff Kirsher
2014-09-19 13:49 ` [patch net-next v2 3/9] rtnl: expose physical switch id for particular device Jiri Pirko
2014-09-19 13:49 ` [patch net-next v2 4/9] net-sysfs: " Jiri Pirko
2014-09-19 13:49 ` [patch net-next v2 5/9] net: introduce dummy switch Jiri Pirko
[not found] ` <1411134590-4586-6-git-send-email-jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>
2014-09-20 5:21 ` Florian Fainelli
2014-09-20 7:37 ` Jiri Pirko
2014-09-19 13:49 ` [patch net-next v2 6/9] switchdev: add basic support for flow matching and actions Jiri Pirko
2014-09-20 5:32 ` Florian Fainelli
2014-09-20 7:28 ` Jiri Pirko
2014-09-19 13:49 ` [patch net-next v2 7/9] switchdev: add swdev features Jiri Pirko
2014-09-19 13:49 ` [patch net-next v2 8/9] switchdev: introduce Netlink API Jiri Pirko
2014-09-19 15:25 ` Jamal Hadi Salim
2014-09-19 15:49 ` Jiri Pirko
2014-09-19 17:57 ` Jamal Hadi Salim
2014-09-19 22:12 ` John Fastabend
2014-09-19 22:18 ` Jamal Hadi Salim
2014-09-20 5:39 ` Florian Fainelli
2014-09-20 8:25 ` Jiri Pirko
2014-09-20 8:17 ` Jiri Pirko
2014-09-20 10:19 ` Jamal Hadi Salim
2014-09-20 11:01 ` Thomas Graf
2014-09-20 11:32 ` Jamal Hadi Salim
2014-09-20 11:51 ` Thomas Graf
[not found] ` <20140920115140.GA3777-FZi0V3Vbi30CUdFEqe4BF2D2FQJk+8+b@public.gmane.org>
2014-09-20 12:35 ` Jamal Hadi Salim
2014-09-22 7:53 ` Jiri Pirko
[not found] ` <20140922075337.GA1828-6KJVSR23iU488b5SBfVpbw@public.gmane.org>
2014-09-22 11:48 ` Jamal Hadi Salim
2014-09-20 5:36 ` Florian Fainelli
2014-09-20 8:14 ` Jiri Pirko
2014-09-20 10:53 ` Thomas Graf
2014-09-20 22:50 ` Alexei Starovoitov
2014-09-22 8:13 ` Thomas Graf
2014-09-22 15:10 ` Tom Herbert
2014-09-22 22:17 ` Thomas Graf
[not found] ` <20140922221727.GA4708-FZi0V3Vbi30CUdFEqe4BF2D2FQJk+8+b@public.gmane.org>
2014-09-22 22:40 ` Tom Herbert
2014-09-22 22:53 ` Thomas Graf
2014-09-22 23:07 ` Tom Herbert
2014-09-23 1:36 ` John Fastabend
2014-09-23 7:19 ` Thomas Graf
2014-09-23 11:09 ` Jamal Hadi Salim
[not found] ` <CA+mtBx9ZVQ5r5Hzy9-uEnk+iu+HKkOP4+VANC06Xf8VvTxktwQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-23 9:18 ` Thomas Graf
2014-09-23 1:54 ` Alexei Starovoitov
2014-09-23 2:16 ` Tom Herbert
2014-09-23 4:11 ` Andy Gospodarek
2014-09-23 10:11 ` Thomas Graf
2014-09-23 15:32 ` Or Gerlitz
2014-09-24 13:32 ` Thomas Graf
2014-09-26 20:03 ` Or Gerlitz
2014-09-26 21:02 ` Thomas Graf
2014-09-23 9:52 ` Thomas Graf
2014-09-20 3:41 ` Roopa Prabhu
2014-09-20 8:09 ` Jiri Pirko
2014-09-20 12:39 ` Roopa Prabhu
2014-09-20 8:10 ` Scott Feldman
2014-09-20 10:31 ` Jamal Hadi Salim
[not found] ` <DDC24110-C3F5-470F-B9BE-1D1792415D1E-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org>
2014-09-20 12:51 ` Roopa Prabhu
2014-09-20 17:21 ` Scott Feldman
2014-09-20 17:38 ` Jiri Pirko [this message]
2014-09-21 1:30 ` Roopa Prabhu
2014-09-19 13:49 ` [patch net-next v2 9/9] rocker: introduce rocker switch driver Jiri Pirko
[not found] ` <1411134590-4586-1-git-send-email-jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>
2014-09-19 13:49 ` [patch net-next v2 2/9] net: introduce generic switch devices support Jiri Pirko
2014-09-19 14:15 ` [patch net-next v2 0/9] introduce rocker switch driver with hardware accelerated datapath api David Laight
[not found] ` <063D6719AE5E284EB5DD2968C1650D6D17495CC6-VkEWCZq2GCInGFn1LkZF6NBPR1lH4CV8@public.gmane.org>
2014-09-19 14:20 ` Jiri Pirko
2014-09-20 5:37 ` Florian Fainelli
-- strict thread matches above, loose matches on Subject: below --
2014-09-23 3:43 [patch net-next v2 8/9] switchdev: introduce Netlink API Alexei Starovoitov
2014-09-23 20:57 ` Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140920173854.GA1829@nanopsycho.orion \
--to=jiri@resnulli$(echo .)us \
--cc=andy@greyhouse$(echo .)net \
--cc=azhou@nicira$(echo .)com \
--cc=ben@decadent$(echo .)org.uk \
--cc=davem@davemloft$(echo .)net \
--cc=dborkman@redhat$(echo .)com \
--cc=dev@openvswitch$(echo .)org \
--cc=ebiederm@xmission$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=jasowang@redhat$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=jesse@nicira$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=john.r.fastabend@intel$(echo .)com \
--cc=linville@tuxdriver$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
--cc=nicolas.dichtel@6wind$(echo .)com \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=pshelar@nicira$(echo .)com \
--cc=roopa@cumulusnetworks$(echo .)com \
--cc=sfeldma@cumulusnetworks$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
--cc=tgraf@suug$(echo .)ch \
--cc=vyasevic@redhat$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox