public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Roopa Prabhu <roopa@cumulusnetworks•com>
To: Jiri Pirko <jiri@resnulli•us>
Cc: Jamal Hadi Salim <jhs@mojatatu•com>,
	netdev@vger•kernel.org, davem@davemloft•net,
	nhorman@tuxdriver•com, andy@greyhouse•net, tgraf@suug•ch,
	dborkman@redhat•com, ogerlitz@mellanox•com, jesse@nicira•com,
	pshelar@nicira•com, azhou@nicira•com, ben@decadent•org.uk,
	stephen@networkplumber•org, jeffrey.t.kirsher@intel•com,
	vyasevic@redhat•com, xiyou.wangcong@gmail•com,
	john.r.fastabend@intel•com, edumazet@google•com,
	sfeldma@cumulusnetworks•com, f.fainelli@gmail•com,
	linville@tuxdriver•com, dev@openvswitch•org, jasowang@redhat•com,
	ebiederm@xmission•com, nicolas.dichtel@6wind•com,
	ryazanov.s.a@gmail•com, buytenh@wantstofly•org,
	aviadr@mellanox•com, nbd@openwrt•org,
	alexei.starovoitov@gmail•com, Neil.Jerram@metaswitch•com,
	ronye@mellanox•com, simon.horman@netronome•com,
	alexander.h.duyck@intel•com,
	Shrijeet Mukherjee <shm@cumulusnetworks•com>
Subject: Re: [patch net-next v2 8/9] switchdev: introduce Netlink API
Date: Sat, 20 Sep 2014 05:39:57 -0700	[thread overview]
Message-ID: <541D759D.3030000@cumulusnetworks.com> (raw)
In-Reply-To: <20140920080943.GD1821@nanopsycho.orion>

On 9/20/14, 1:09 AM, Jiri Pirko wrote:
> Sat, Sep 20, 2014 at 05:41:16AM CEST, roopa@cumulusnetworks•com wrote:
>> On 9/19/14, 8:49 AM, Jiri Pirko wrote:
>>> Fri, Sep 19, 2014 at 05:25:48PM CEST, jhs@mojatatu•com wrote:
>>>> On 09/19/14 09:49, Jiri Pirko wrote:
>>>>> This patch exposes switchdev API using generic Netlink.
>>>>> Example userspace utility is here:
>>>>> https://github.com/jpirko/switchdev
>>>>>
>>>> Is this just a temporary test tool? Otherwise i dont see reason
>>>> for its existence (or the API that it feeds on).
>>> Please read the conversation I had with Pravin and Jesse in v1 thread.
>>> Long story short they like to have the api separated from ovs datapath
>>> so ovs daemon can use it to directly communicate with driver. Also John
>>> Fastabend requested a way to work with driver flows without using ovs ->
>>> that was the original reason I created switchdev genl api.
>>>
>>> Regarding the "sw" tool, yes it is for testing purposes now. ovs daemon
>>> will use directly switchdev genl api.
>>>
>>> I hope I cleared this out.
>> We already have all the needed rtnetlink kernel api and userspace tools
>> around it to support all
>> switching asic features. ie, the rtnetlink api is the switchdev api. We can
>> do l2, l3, acl's with it.
>> Its unclear to me why we need another new netlink api. Which will mean none
>> of the existing tools to
>> create bridges etc will work on a switchdev.
> No one is proposing such API. Note that what I'm trying to solve in my
> patchset is FLOW world. There is only one API there, ovs genl. But the
> usage of that for hw offload purposes was nacked by ovs maintainer. Plus
> couple of people wanted to run the offloading independently on ovs
> instance. Therefore I introduced the switchdev genl, which takes care of
> that. No plan to extend it for other things you mentioned, just flows.
ok, That was not clear to me. Introducing a new genl api and calling it the
switchd dev api can result it non-flow creep into it in the future.
>
>
>> Which seems like going in the direction exactly opposite to what we had
>> discussed earlier.
> Nope. The previous discussion ignored flows.
>> If a non-ovs flow interface is needed from userspace, we can extend the
>> existing interface to include flows.
> How? You mean to extend rtnetlink? What advantage it would bring
> comparing to separate genl iface?
yes. Advantage would be that we dont have yet another parallel switchdev 
netlink api.


>> I don't understand why we should replace the existing rtnetlink switchdev api
>> to accommodate flows.
> Sorry, I do not undertand what "existing rtnetlink switchdev api" you
> have on mind. Would you care to explain?

I am taking about existing rtnetlink api that bridge, ip link uses to 
talk l2 and l3 to the kernel.
RTM_NEWROUTE etc.

  reply	other threads:[~2014-09-20 12:40 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-19 13:49 [patch net-next v2 0/9] introduce rocker switch driver with hardware accelerated datapath api Jiri Pirko
2014-09-19 13:49 ` [patch net-next v2 1/9] net: rename netdev_phys_port_id to more generic name Jiri Pirko
     [not found]   ` <1411134590-4586-2-git-send-email-jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>
2014-09-19 13:54     ` Jeff Kirsher
2014-09-19 13:49 ` [patch net-next v2 3/9] rtnl: expose physical switch id for particular device Jiri Pirko
2014-09-19 13:49 ` [patch net-next v2 4/9] net-sysfs: " Jiri Pirko
2014-09-19 13:49 ` [patch net-next v2 5/9] net: introduce dummy switch Jiri Pirko
     [not found]   ` <1411134590-4586-6-git-send-email-jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>
2014-09-20  5:21     ` Florian Fainelli
2014-09-20  7:37       ` Jiri Pirko
2014-09-19 13:49 ` [patch net-next v2 6/9] switchdev: add basic support for flow matching and actions Jiri Pirko
2014-09-20  5:32   ` Florian Fainelli
2014-09-20  7:28     ` Jiri Pirko
2014-09-19 13:49 ` [patch net-next v2 7/9] switchdev: add swdev features Jiri Pirko
2014-09-19 13:49 ` [patch net-next v2 8/9] switchdev: introduce Netlink API Jiri Pirko
2014-09-19 15:25   ` Jamal Hadi Salim
2014-09-19 15:49     ` Jiri Pirko
2014-09-19 17:57       ` Jamal Hadi Salim
2014-09-19 22:12         ` John Fastabend
2014-09-19 22:18           ` Jamal Hadi Salim
2014-09-20  5:39             ` Florian Fainelli
2014-09-20  8:25               ` Jiri Pirko
2014-09-20  8:17             ` Jiri Pirko
2014-09-20 10:19               ` Jamal Hadi Salim
2014-09-20 11:01                 ` Thomas Graf
2014-09-20 11:32                   ` Jamal Hadi Salim
2014-09-20 11:51                     ` Thomas Graf
     [not found]                       ` <20140920115140.GA3777-FZi0V3Vbi30CUdFEqe4BF2D2FQJk+8+b@public.gmane.org>
2014-09-20 12:35                         ` Jamal Hadi Salim
2014-09-22  7:53                     ` Jiri Pirko
     [not found]                       ` <20140922075337.GA1828-6KJVSR23iU488b5SBfVpbw@public.gmane.org>
2014-09-22 11:48                         ` Jamal Hadi Salim
2014-09-20  5:36           ` Florian Fainelli
2014-09-20  8:14           ` Jiri Pirko
2014-09-20 10:53             ` Thomas Graf
2014-09-20 22:50               ` Alexei Starovoitov
2014-09-22  8:13                 ` Thomas Graf
2014-09-22 15:10                   ` Tom Herbert
2014-09-22 22:17                     ` Thomas Graf
     [not found]                       ` <20140922221727.GA4708-FZi0V3Vbi30CUdFEqe4BF2D2FQJk+8+b@public.gmane.org>
2014-09-22 22:40                         ` Tom Herbert
2014-09-22 22:53                           ` Thomas Graf
2014-09-22 23:07                             ` Tom Herbert
2014-09-23  1:36                               ` John Fastabend
2014-09-23  7:19                                 ` Thomas Graf
2014-09-23 11:09                                 ` Jamal Hadi Salim
     [not found]                           ` <CA+mtBx9ZVQ5r5Hzy9-uEnk+iu+HKkOP4+VANC06Xf8VvTxktwQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-23  9:18                             ` Thomas Graf
2014-09-23  1:54                     ` Alexei Starovoitov
2014-09-23  2:16                       ` Tom Herbert
2014-09-23  4:11                         ` Andy Gospodarek
2014-09-23 10:11                           ` Thomas Graf
2014-09-23 15:32                           ` Or Gerlitz
2014-09-24 13:32                             ` Thomas Graf
2014-09-26 20:03                               ` Or Gerlitz
2014-09-26 21:02                                 ` Thomas Graf
2014-09-23  9:52                         ` Thomas Graf
2014-09-20  3:41       ` Roopa Prabhu
2014-09-20  8:09         ` Jiri Pirko
2014-09-20 12:39           ` Roopa Prabhu [this message]
2014-09-20  8:10         ` Scott Feldman
2014-09-20 10:31           ` Jamal Hadi Salim
     [not found]           ` <DDC24110-C3F5-470F-B9BE-1D1792415D1E-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org>
2014-09-20 12:51             ` Roopa Prabhu
2014-09-20 17:21               ` Scott Feldman
2014-09-20 17:38                 ` Jiri Pirko
2014-09-21  1:30                   ` Roopa Prabhu
2014-09-19 13:49 ` [patch net-next v2 9/9] rocker: introduce rocker switch driver Jiri Pirko
     [not found] ` <1411134590-4586-1-git-send-email-jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>
2014-09-19 13:49   ` [patch net-next v2 2/9] net: introduce generic switch devices support Jiri Pirko
2014-09-19 14:15   ` [patch net-next v2 0/9] introduce rocker switch driver with hardware accelerated datapath api David Laight
     [not found]     ` <063D6719AE5E284EB5DD2968C1650D6D17495CC6-VkEWCZq2GCInGFn1LkZF6NBPR1lH4CV8@public.gmane.org>
2014-09-19 14:20       ` Jiri Pirko
2014-09-20  5:37         ` Florian Fainelli
  -- strict thread matches above, loose matches on Subject: below --
2014-09-23  3:43 [patch net-next v2 8/9] switchdev: introduce Netlink API Alexei Starovoitov
2014-09-23 20:57 ` Tom Herbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=541D759D.3030000@cumulusnetworks.com \
    --to=roopa@cumulusnetworks$(echo .)com \
    --cc=Neil.Jerram@metaswitch$(echo .)com \
    --cc=alexander.h.duyck@intel$(echo .)com \
    --cc=alexei.starovoitov@gmail$(echo .)com \
    --cc=andy@greyhouse$(echo .)net \
    --cc=aviadr@mellanox$(echo .)com \
    --cc=azhou@nicira$(echo .)com \
    --cc=ben@decadent$(echo .)org.uk \
    --cc=buytenh@wantstofly$(echo .)org \
    --cc=davem@davemloft$(echo .)net \
    --cc=dborkman@redhat$(echo .)com \
    --cc=dev@openvswitch$(echo .)org \
    --cc=ebiederm@xmission$(echo .)com \
    --cc=edumazet@google$(echo .)com \
    --cc=f.fainelli@gmail$(echo .)com \
    --cc=jasowang@redhat$(echo .)com \
    --cc=jeffrey.t.kirsher@intel$(echo .)com \
    --cc=jesse@nicira$(echo .)com \
    --cc=jhs@mojatatu$(echo .)com \
    --cc=jiri@resnulli$(echo .)us \
    --cc=john.r.fastabend@intel$(echo .)com \
    --cc=linville@tuxdriver$(echo .)com \
    --cc=nbd@openwrt$(echo .)org \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=nhorman@tuxdriver$(echo .)com \
    --cc=nicolas.dichtel@6wind$(echo .)com \
    --cc=ogerlitz@mellanox$(echo .)com \
    --cc=pshelar@nicira$(echo .)com \
    --cc=ronye@mellanox$(echo .)com \
    --cc=ryazanov.s.a@gmail$(echo .)com \
    --cc=sfeldma@cumulusnetworks$(echo .)com \
    --cc=shm@cumulusnetworks$(echo .)com \
    --cc=simon.horman@netronome$(echo .)com \
    --cc=stephen@networkplumber$(echo .)org \
    --cc=tgraf@suug$(echo .)ch \
    --cc=vyasevic@redhat$(echo .)com \
    --cc=xiyou.wangcong@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox