public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Vadim Kochan <vadim4j@gmail•com>
To: Stephen Hemminger <stephen@networkplumber•org>
Cc: Vadim Kochan <vadim4j@gmail•com>, netdev@vger•kernel.org
Subject: Re: [PATCH iproute2] bridge: Show state names in the 'link help' print
Date: Thu, 26 Feb 2015 03:03:50 +0200	[thread overview]
Message-ID: <20150226010350.GA13245@angus-think.lan> (raw)
In-Reply-To: <20150225170950.06b81a78@urahara>

On Wed, Feb 25, 2015 at 05:09:50PM -0800, Stephen Hemminger wrote:
> On Thu, 26 Feb 2015 01:56:33 +0200
> Vadim Kochan <vadim4j@gmail•com> wrote:
> 
> > From: Vadim Kochan <vadim4j@gmail•com>
> > 
> > Signed-off-by: Vadim Kochan <vadim4j@gmail•com>
> > ---
> >  bridge/link.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/bridge/link.c b/bridge/link.c
> > index a7bd85f..7f1ec70 100644
> > --- a/bridge/link.c
> > +++ b/bridge/link.c
> > @@ -228,6 +228,12 @@ static void usage(void)
> >  	fprintf(stderr,	"                               [ flood {on | off} ]\n");
> >  	fprintf(stderr, "                               [ hwmode {vepa | veb} ]\n");
> >  	fprintf(stderr, "       bridge link show [dev DEV]\n");
> > +	fprintf(stderr, "\n");
> > +	fprintf(stderr, "STATE := { 0 | disabled   |\n");
> > +	fprintf(stderr, "           1 | listening  |\n");
> > +	fprintf(stderr, "           2 | learning   |\n");
> > +	fprintf(stderr, "           3 | forwarding |\n");
> > +	fprintf(stderr, "           4 | blocking }\n");
> >  	exit(-1);
> >  }
> >  
> 
> that is too wordy for help. put it in docs if needed.

Hm, I assumed this might be useful for fast looking for state names from the shell just by 'link help'...

      reply	other threads:[~2015-02-26  1:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-25 23:56 [PATCH iproute2] bridge: Show state names in the 'link help' print Vadim Kochan
2015-02-26  1:09 ` Stephen Hemminger
2015-02-26  1:03   ` Vadim Kochan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150226010350.GA13245@angus-think.lan \
    --to=vadim4j@gmail$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=stephen@networkplumber$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox