* [PATCH iproute2] bridge: Show state names in the 'link help' print
@ 2015-02-25 23:56 Vadim Kochan
2015-02-26 1:09 ` Stephen Hemminger
0 siblings, 1 reply; 3+ messages in thread
From: Vadim Kochan @ 2015-02-25 23:56 UTC (permalink / raw)
To: stephen; +Cc: netdev, Vadim Kochan
From: Vadim Kochan <vadim4j@gmail•com>
Signed-off-by: Vadim Kochan <vadim4j@gmail•com>
---
bridge/link.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/bridge/link.c b/bridge/link.c
index a7bd85f..7f1ec70 100644
--- a/bridge/link.c
+++ b/bridge/link.c
@@ -228,6 +228,12 @@ static void usage(void)
fprintf(stderr, " [ flood {on | off} ]\n");
fprintf(stderr, " [ hwmode {vepa | veb} ]\n");
fprintf(stderr, " bridge link show [dev DEV]\n");
+ fprintf(stderr, "\n");
+ fprintf(stderr, "STATE := { 0 | disabled |\n");
+ fprintf(stderr, " 1 | listening |\n");
+ fprintf(stderr, " 2 | learning |\n");
+ fprintf(stderr, " 3 | forwarding |\n");
+ fprintf(stderr, " 4 | blocking }\n");
exit(-1);
}
--
2.2.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH iproute2] bridge: Show state names in the 'link help' print
2015-02-25 23:56 [PATCH iproute2] bridge: Show state names in the 'link help' print Vadim Kochan
@ 2015-02-26 1:09 ` Stephen Hemminger
2015-02-26 1:03 ` Vadim Kochan
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2015-02-26 1:09 UTC (permalink / raw)
To: Vadim Kochan; +Cc: netdev
On Thu, 26 Feb 2015 01:56:33 +0200
Vadim Kochan <vadim4j@gmail•com> wrote:
> From: Vadim Kochan <vadim4j@gmail•com>
>
> Signed-off-by: Vadim Kochan <vadim4j@gmail•com>
> ---
> bridge/link.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/bridge/link.c b/bridge/link.c
> index a7bd85f..7f1ec70 100644
> --- a/bridge/link.c
> +++ b/bridge/link.c
> @@ -228,6 +228,12 @@ static void usage(void)
> fprintf(stderr, " [ flood {on | off} ]\n");
> fprintf(stderr, " [ hwmode {vepa | veb} ]\n");
> fprintf(stderr, " bridge link show [dev DEV]\n");
> + fprintf(stderr, "\n");
> + fprintf(stderr, "STATE := { 0 | disabled |\n");
> + fprintf(stderr, " 1 | listening |\n");
> + fprintf(stderr, " 2 | learning |\n");
> + fprintf(stderr, " 3 | forwarding |\n");
> + fprintf(stderr, " 4 | blocking }\n");
> exit(-1);
> }
>
that is too wordy for help. put it in docs if needed.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH iproute2] bridge: Show state names in the 'link help' print
2015-02-26 1:09 ` Stephen Hemminger
@ 2015-02-26 1:03 ` Vadim Kochan
0 siblings, 0 replies; 3+ messages in thread
From: Vadim Kochan @ 2015-02-26 1:03 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Vadim Kochan, netdev
On Wed, Feb 25, 2015 at 05:09:50PM -0800, Stephen Hemminger wrote:
> On Thu, 26 Feb 2015 01:56:33 +0200
> Vadim Kochan <vadim4j@gmail•com> wrote:
>
> > From: Vadim Kochan <vadim4j@gmail•com>
> >
> > Signed-off-by: Vadim Kochan <vadim4j@gmail•com>
> > ---
> > bridge/link.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/bridge/link.c b/bridge/link.c
> > index a7bd85f..7f1ec70 100644
> > --- a/bridge/link.c
> > +++ b/bridge/link.c
> > @@ -228,6 +228,12 @@ static void usage(void)
> > fprintf(stderr, " [ flood {on | off} ]\n");
> > fprintf(stderr, " [ hwmode {vepa | veb} ]\n");
> > fprintf(stderr, " bridge link show [dev DEV]\n");
> > + fprintf(stderr, "\n");
> > + fprintf(stderr, "STATE := { 0 | disabled |\n");
> > + fprintf(stderr, " 1 | listening |\n");
> > + fprintf(stderr, " 2 | learning |\n");
> > + fprintf(stderr, " 3 | forwarding |\n");
> > + fprintf(stderr, " 4 | blocking }\n");
> > exit(-1);
> > }
> >
>
> that is too wordy for help. put it in docs if needed.
Hm, I assumed this might be useful for fast looking for state names from the shell just by 'link help'...
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-26 1:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-25 23:56 [PATCH iproute2] bridge: Show state names in the 'link help' print Vadim Kochan
2015-02-26 1:09 ` Stephen Hemminger
2015-02-26 1:03 ` Vadim Kochan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox