From: Simon Horman <horms@kernel•org>
To: Lorenzo Bianconi <lorenzo@kernel•org>
Cc: netdev@vger•kernel.org, nbd@nbd•name,
lorenzo.bianconi83@gmail•com, davem@davemloft•net,
edumazet@google•com, kuba@kernel•org, pabeni@redhat•com,
conor@kernel•org, linux-arm-kernel@lists•infradead.org,
robh+dt@kernel•org, krzysztof.kozlowski+dt@linaro•org,
conor+dt@kernel•org, devicetree@vger•kernel.org,
catalin.marinas@arm•com, will@kernel•org, upstream@airoha•com,
angelogioacchino.delregno@collabora•com,
benjamin.larsson@genexis•eu, rkannoth@marvell•com,
sgoutham@marvell•com, andrew@lunn•ch, arnd@arndb•de
Subject: Re: [PATCH v5 net-next 2/2] net: airoha: Introduce ethernet support for EN7581 SoC
Date: Fri, 5 Jul 2024 20:06:44 +0100 [thread overview]
Message-ID: <20240705190644.GB1480790@kernel.org> (raw)
In-Reply-To: <18e837f0f9377b68302d42ec9174473046a4a30a.1720079772.git.lorenzo@kernel.org>
On Thu, Jul 04, 2024 at 10:08:11AM +0200, Lorenzo Bianconi wrote:
> Add airoha_eth driver in order to introduce ethernet support for
> Airoha EN7581 SoC available on EN7581 development board (en7581-evb).
> en7581-evb networking architecture is composed by airoha_eth as mac
> controller (cpu port) and a mt7530 dsa based switch.
> EN7581 mac controller is mainly composed by Frame Engine (FE) and
> QoS-DMA (QDMA) modules. FE is used for traffic offloading (just basic
> functionalities are supported now) while QDMA is used for DMA operation
> and QOS functionalities between mac layer and the dsa switch (hw QoS is
> not available yet and it will be added in the future).
> Currently only hw lan features are available, hw wan will be added with
> subsequent patches.
>
> Tested-by: Benjamin Larsson <benjamin.larsson@genexis•eu>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel•org>
...
> +static const char * const airoha_ethtool_stats_name[] = {
> + "tx_eth_pkt_cnt",
> + "tx_eth_byte_cnt",
> + "tx_ok_pkt_cnt",
> + "tx_ok_byte_cnt",
> + "tx_eth_drop_cnt",
> + "tx_eth_bc_cnt",
> + "tx_eth_mc_cnt",
> + "tx_eth_lt64_cnt",
> + "tx_eth_eq64_cnt",
> + "tx_eth_65_127_cnt",
> + "tx_eth_128_255_cnt",
> + "tx_eth_256_511_cnt",
> + "tx_eth_512_1023_cnt",
> + "tx_eth_1024_1518_cnt",
> + "tx_eth_gt1518_cnt",
> + "rx_eth_pkt_cnt",
> + "rx_eth_byte_cnt",
> + "rx_ok_pkt_cnt",
> + "rx_ok_byte_cnt",
> + "rx_eth_drop_cnt",
> + "rx_eth_bc_cnt",
> + "rx_eth_mc_cnt",
> + "rx_eth_crc_drop_cnt",
> + "rx_eth_frag_cnt",
> + "rx_eth_jabber_cnt",
> + "rx_eth_lt64_cnt",
> + "rx_eth_eq64_cnt",
> + "rx_eth_65_127_cnt",
> + "rx_eth_128_255_cnt",
> + "rx_eth_256_511_cnt",
> + "rx_eth_512_1023_cnt",
> + "rx_eth_1024_1518_cnt",
> + "rx_eth_gt1518_cnt",
> +};
Hi Lorenzo,
Sorry for not noticing this earlier.
It seems to me that some of the stats above could
use standard stats, which is preferred.
Basically, my understanding is that one should:
1. Implement .ndo_get_stats64
(that seems relevant here)
2. As appropriate implement ethtool_stats non-extended stats operations
(perhaps not relevant here)
3. Then implement get_ethtool_stats for what is left over
...
next prev parent reply other threads:[~2024-07-05 19:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 8:08 [PATCH v5 net-next 0/2] Introduce EN7581 ethernet support Lorenzo Bianconi
2024-07-04 8:08 ` [PATCH v5 net-next 1/2] dt-bindings: net: airoha: Add EN7581 ethernet controller Lorenzo Bianconi
2024-07-08 16:37 ` Rob Herring
2024-07-08 17:03 ` Lorenzo Bianconi
2024-07-08 20:19 ` Rob Herring
2024-07-08 20:48 ` Andrew Lunn
2024-07-08 21:16 ` Lorenzo Bianconi
2024-07-08 21:10 ` Lorenzo Bianconi
2024-07-08 22:02 ` Lorenzo Bianconi
2024-07-04 8:08 ` [PATCH v5 net-next 2/2] net: airoha: Introduce ethernet support for EN7581 SoC Lorenzo Bianconi
2024-07-05 19:06 ` Simon Horman [this message]
2024-07-06 8:27 ` Lorenzo Bianconi
2024-07-06 12:27 ` Simon Horman
2024-07-06 12:58 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240705190644.GB1480790@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=angelogioacchino.delregno@collabora$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=benjamin.larsson@genexis$(echo .)eu \
--cc=catalin.marinas@arm$(echo .)com \
--cc=conor+dt@kernel$(echo .)org \
--cc=conor@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=krzysztof.kozlowski+dt@linaro$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=lorenzo.bianconi83@gmail$(echo .)com \
--cc=lorenzo@kernel$(echo .)org \
--cc=nbd@nbd$(echo .)name \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=rkannoth@marvell$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=sgoutham@marvell$(echo .)com \
--cc=upstream@airoha$(echo .)com \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox