From: Rob Herring <robh@kernel•org>
To: Lorenzo Bianconi <lorenzo@kernel•org>
Cc: netdev@vger•kernel.org, nbd@nbd•name,
lorenzo.bianconi83@gmail•com, davem@davemloft•net,
edumazet@google•com, kuba@kernel•org, pabeni@redhat•com,
conor@kernel•org, linux-arm-kernel@lists•infradead.org,
krzysztof.kozlowski+dt@linaro•org, conor+dt@kernel•org,
devicetree@vger•kernel.org, catalin.marinas@arm•com,
will@kernel•org, upstream@airoha•com,
angelogioacchino.delregno@collabora•com,
benjamin.larsson@genexis•eu, rkannoth@marvell•com,
sgoutham@marvell•com, andrew@lunn•ch, arnd@arndb•de,
horms@kernel•org
Subject: Re: [PATCH v5 net-next 1/2] dt-bindings: net: airoha: Add EN7581 ethernet controller
Date: Mon, 8 Jul 2024 10:37:08 -0600 [thread overview]
Message-ID: <20240708163708.GA3371750-robh@kernel.org> (raw)
In-Reply-To: <48dde2595c6ff497a846183b117ac9704537b78c.1720079772.git.lorenzo@kernel.org>
On Thu, Jul 04, 2024 at 10:08:10AM +0200, Lorenzo Bianconi wrote:
> Introduce device-tree binding documentation for Airoha EN7581 ethernet
> mac controller.
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel•org>
> ---
> .../bindings/net/airoha,en7581-eth.yaml | 146 ++++++++++++++++++
> 1 file changed, 146 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/airoha,en7581-eth.yaml
>
> diff --git a/Documentation/devicetree/bindings/net/airoha,en7581-eth.yaml b/Documentation/devicetree/bindings/net/airoha,en7581-eth.yaml
> new file mode 100644
> index 000000000000..f4b1f8afddd0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/airoha,en7581-eth.yaml
> @@ -0,0 +1,146 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/airoha,en7581-eth.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Airoha EN7581 Frame Engine Ethernet controller
> +
> +allOf:
> + - $ref: ethernet-controller.yaml#
Again, to rephrase, what are you using from this binding? It does not
make sense for the parent and child both to use it.
> +
> +maintainers:
> + - Lorenzo Bianconi <lorenzo@kernel•org>
> +
> +description:
> + The frame engine ethernet controller can be found on Airoha SoCs.
> + These SoCs have multi-GMAC ports.
> +
> +properties:
> + compatible:
> + enum:
> + - airoha,en7581-eth
> +
> + reg:
> + items:
> + - description: Frame engine base address
> + - description: QDMA0 base address
> + - description: QDMA1 base address
> +
> + reg-names:
> + items:
> + - const: fe
> + - const: qdma0
> + - const: qdma1
> +
> + interrupts:
> + items:
> + - description: QDMA lan irq0
> + - description: QDMA lan irq1
> + - description: QDMA lan irq2
> + - description: QDMA lan irq3
> + - description: QDMA wan irq0
> + - description: QDMA wan irq1
> + - description: QDMA wan irq2
> + - description: QDMA wan irq3
> + - description: FE error irq
> + - description: PDMA irq
> +
> + resets:
> + maxItems: 8
> +
> + reset-names:
> + items:
> + - const: fe
> + - const: pdma
> + - const: qdma
> + - const: xsi-mac
> + - const: hsi0-mac
> + - const: hsi1-mac
> + - const: hsi-mac
> + - const: xfp-mac
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> +patternProperties:
> + "^mac@[1-4]$":
'ethernet' is the defined node name for users of
ethernet-controller.yaml.
> + type: object
> + unevaluatedProperties: false
> + $ref: ethernet-controller.yaml#
> + description:
> + Ethernet GMAC port associated to the MAC controller
> + properties:
> + compatible:
> + const: airoha,eth-mac
> +
> + reg:
> + minimum: 1
> + maximum: 4
> + description: GMAC port identifier
> +
> + required:
> + - reg
> + - compatible
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - resets
> + - reset-names
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/clock/en7523-clk.h>
> +
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + eth0: ethernet@1fb50000 {
> + compatible = "airoha,en7581-eth";
> + reg = <0 0x1fb50000 0 0x2600>,
> + <0 0x1fb54000 0 0x2000>,
> + <0 0x1fb56000 0 0x2000>;
> + reg-names = "fe", "qdma0", "qdma1";
> +
> + resets = <&scuclk 44>,
> + <&scuclk 30>,
> + <&scuclk 31>,
> + <&scuclk 6>,
> + <&scuclk 15>,
> + <&scuclk 16>,
> + <&scuclk 17>,
> + <&scuclk 26>;
> + reset-names = "fe", "pdma", "qdma", "xsi-mac",
> + "hsi0-mac", "hsi1-mac", "hsi-mac",
> + "xfp-mac";
> +
> + interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + mac1: mac@1 {
> + compatible = "airoha,eth-mac";
> + reg = <1>;
> + };
> + };
> + };
> --
> 2.45.2
>
next prev parent reply other threads:[~2024-07-08 16:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 8:08 [PATCH v5 net-next 0/2] Introduce EN7581 ethernet support Lorenzo Bianconi
2024-07-04 8:08 ` [PATCH v5 net-next 1/2] dt-bindings: net: airoha: Add EN7581 ethernet controller Lorenzo Bianconi
2024-07-08 16:37 ` Rob Herring [this message]
2024-07-08 17:03 ` Lorenzo Bianconi
2024-07-08 20:19 ` Rob Herring
2024-07-08 20:48 ` Andrew Lunn
2024-07-08 21:16 ` Lorenzo Bianconi
2024-07-08 21:10 ` Lorenzo Bianconi
2024-07-08 22:02 ` Lorenzo Bianconi
2024-07-04 8:08 ` [PATCH v5 net-next 2/2] net: airoha: Introduce ethernet support for EN7581 SoC Lorenzo Bianconi
2024-07-05 19:06 ` Simon Horman
2024-07-06 8:27 ` Lorenzo Bianconi
2024-07-06 12:27 ` Simon Horman
2024-07-06 12:58 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240708163708.GA3371750-robh@kernel.org \
--to=robh@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=angelogioacchino.delregno@collabora$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=benjamin.larsson@genexis$(echo .)eu \
--cc=catalin.marinas@arm$(echo .)com \
--cc=conor+dt@kernel$(echo .)org \
--cc=conor@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=krzysztof.kozlowski+dt@linaro$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=lorenzo.bianconi83@gmail$(echo .)com \
--cc=lorenzo@kernel$(echo .)org \
--cc=nbd@nbd$(echo .)name \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=rkannoth@marvell$(echo .)com \
--cc=sgoutham@marvell$(echo .)com \
--cc=upstream@airoha$(echo .)com \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox