From: Lorenzo Bianconi <lorenzo@kernel•org>
To: Andrew Lunn <andrew@lunn•ch>
Cc: Rob Herring <robh@kernel•org>,
netdev@vger•kernel.org, nbd@nbd•name,
lorenzo.bianconi83@gmail•com, davem@davemloft•net,
edumazet@google•com, kuba@kernel•org, pabeni@redhat•com,
conor@kernel•org, linux-arm-kernel@lists•infradead.org,
krzysztof.kozlowski+dt@linaro•org, conor+dt@kernel•org,
devicetree@vger•kernel.org, catalin.marinas@arm•com,
will@kernel•org, upstream@airoha•com,
angelogioacchino.delregno@collabora•com,
benjamin.larsson@genexis•eu, rkannoth@marvell•com,
sgoutham@marvell•com, arnd@arndb•de, horms@kernel•org
Subject: Re: [PATCH v5 net-next 1/2] dt-bindings: net: airoha: Add EN7581 ethernet controller
Date: Mon, 8 Jul 2024 23:16:27 +0200 [thread overview]
Message-ID: <ZoxXK-uGsX_9_Fn4@lore-desk> (raw)
In-Reply-To: <8f8a1ee1-8c6c-48d6-a794-286464c38712@lunn.ch>
[-- Attachment #1: Type: text/plain, Size: 2915 bytes --]
> > > eth0: ethernet@1fb50000 {
> > > compatible = "airoha,en7581-eth";
> > > reg = <0 0x1fb50000 0 0x2600>,
> > > <0 0x1fb54000 0 0x2000>,
> > > <0 0x1fb56000 0 0x2000>;
> > > reg-names = "fe", "qdma0", "qdma1";
> > >
> > > resets = <&scuclk EN7581_FE_RST>,
> > > <&scuclk EN7581_FE_PDMA_RST>,
> > > <&scuclk EN7581_FE_QDMA_RST>,
> > > <&scuclk EN7581_XSI_MAC_RST>,
> > > <&scuclk EN7581_DUAL_HSI0_MAC_RST>,
> > > <&scuclk EN7581_DUAL_HSI1_MAC_RST>,
> > > <&scuclk EN7581_HSI_MAC_RST>,
> > > <&scuclk EN7581_XFP_MAC_RST>;
> > > reset-names = "fe", "pdma", "qdma", "xsi-mac",
> > > "hsi0-mac", "hsi1-mac", "hsi-mac",
> > > "xfp-mac";
> > >
> > > interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>,
> > > <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>,
> > > <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>,
> > > <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>,
> > > <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>,
> > > <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>,
> > > <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>,
> > > <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>,
> > > <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>,
> > > <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>;
> > >
> > > status = "disabled";
> > >
> > > #address-cells = <1>;
> > > #size-cells = <0>;
> > >
> > > gdm1: mac@1 {
> > > compatible = "airoha,eth-mac";
> > > reg = <1>;
> > > phy-mode = "internal";
> > > status = "disabled";
> > >
> > > fixed-link {
> > > speed = <1000>;
> > > full-duplex;
> > > pause;
> > > };
> > > };
> > > };
> > >
> > > I am using phy related binding for gdm1:mac@1 node.
>
> Hi Lorenzo
Hi Andrew,
>
> phy-mode is a MAC property, not a PHY property. Same for
> fixed-link. These are in ethernet-controller.yaml.
ack
>
> You sometimes have an network controller IP which has multiple MACs
> and some shared infrastructure. You would typically describe the
> shared infrastructure at the top level. The MACs are then listed as
> children, and they make use of ethernet-controller.yaml, and that is
> where all the network specific properties are placed. Is that what you
> are trying to do here?
yep, exactly. Here we have multiple mac nodes that represent the real
ethernet controllers (e.g. used as DSA cpu port). I will use the
ethernet-controller.yaml just for the mac childs.
Regards,
Lorenzo
>
> Andrew
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-07-08 21:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 8:08 [PATCH v5 net-next 0/2] Introduce EN7581 ethernet support Lorenzo Bianconi
2024-07-04 8:08 ` [PATCH v5 net-next 1/2] dt-bindings: net: airoha: Add EN7581 ethernet controller Lorenzo Bianconi
2024-07-08 16:37 ` Rob Herring
2024-07-08 17:03 ` Lorenzo Bianconi
2024-07-08 20:19 ` Rob Herring
2024-07-08 20:48 ` Andrew Lunn
2024-07-08 21:16 ` Lorenzo Bianconi [this message]
2024-07-08 21:10 ` Lorenzo Bianconi
2024-07-08 22:02 ` Lorenzo Bianconi
2024-07-04 8:08 ` [PATCH v5 net-next 2/2] net: airoha: Introduce ethernet support for EN7581 SoC Lorenzo Bianconi
2024-07-05 19:06 ` Simon Horman
2024-07-06 8:27 ` Lorenzo Bianconi
2024-07-06 12:27 ` Simon Horman
2024-07-06 12:58 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZoxXK-uGsX_9_Fn4@lore-desk \
--to=lorenzo@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=angelogioacchino.delregno@collabora$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=benjamin.larsson@genexis$(echo .)eu \
--cc=catalin.marinas@arm$(echo .)com \
--cc=conor+dt@kernel$(echo .)org \
--cc=conor@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=krzysztof.kozlowski+dt@linaro$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=lorenzo.bianconi83@gmail$(echo .)com \
--cc=nbd@nbd$(echo .)name \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=rkannoth@marvell$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=sgoutham@marvell$(echo .)com \
--cc=upstream@airoha$(echo .)com \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox