From: Jeff Garzik <jeff@garzik•org>
To: Josh Boyer <jwboyer@linux•vnet.ibm.com>
Cc: Valentine Barshak <vbarshak@ru•mvista.com>,
Michael Ellerman <michael@ellerman•id.au>,
linuxppc-dev@ozlabs•org, netdev@vger•kernel.org
Subject: Re: [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC.
Date: Mon, 15 Oct 2007 14:53:26 -0400 [thread overview]
Message-ID: <4713B726.6080404@garzik.org> (raw)
In-Reply-To: <20071015134813.6aacdcca@weaponx.rchland.ibm.com>
Josh Boyer wrote:
> On Mon, 15 Oct 2007 14:27:23 -0400
> Jeff Garzik <jeff@garzik•org> wrote:
>
>> Valentine Barshak wrote:
>>> This patch adds BCM5248 and Marvell 88E1111 PHY support to NEW EMAC driver.
>>> These PHY chips are used on PowerPC 440EPx boards.
>>> The PHY code is based on the previous work by Stefan Roese <sr@denx•de>
>>>
>>> Signed-off-by: Stefan Roese <sr@denx•de>
>>> Signed-off-by: Valentine Barshak <vbarshak@ru•mvista.com>
>>> ---
>>> drivers/net/ibm_newemac/phy.c | 39 +++++++++++++++++++++++++++++++++++++++
>>> 1 files changed, 39 insertions(+)
>>>
>>> --- linux.orig/drivers/net/ibm_newemac/phy.c 2007-06-15 21:45:18.000000000 +0400
>>> +++ linux/drivers/net/ibm_newemac/phy.c 2007-06-15 20:45:15.000000000 +0400
>>> @@ -306,8 +306,47 @@
>>> .ops = &cis8201_phy_ops
>>> };
>>>
>>> +static struct mii_phy_def bcm5248_phy_def = {
>>> +
>>> + .phy_id = 0x0143bc00,
>>> + .phy_id_mask = 0x0ffffff0,
>>> + .name = "BCM5248 10/100 SMII Ethernet",
>>> + .ops = &generic_phy_ops
>>> +};
>>> +
>>> +static int m88e1111_init(struct mii_phy *phy)
>>> +{
>>> + printk("%s: Marvell 88E1111 Ethernet\n", __FUNCTION__);
>>> + phy_write(phy, 0x14, 0x0ce3);
>>> + phy_write(phy, 0x18, 0x4101);
>>> + phy_write(phy, 0x09, 0x0e00);
>>> + phy_write(phy, 0x04, 0x01e1);
>>> + phy_write(phy, 0x00, 0x9140);
>>> + phy_write(phy, 0x00, 0x1140);
>>> +
>>> + return 0;
>>> +}
>>> +
>>> +static struct mii_phy_ops m88e1111_phy_ops = {
>>> + .init = m88e1111_init,
>>> + .setup_aneg = genmii_setup_aneg,
>>> + .setup_forced = genmii_setup_forced,
>>> + .poll_link = genmii_poll_link,
>>> + .read_link = genmii_read_link
>>> +};
>>> +
>>> +static struct mii_phy_def m88e1111_phy_def = {
>>> +
>>> + .phy_id = 0x01410CC0,
>>> + .phy_id_mask = 0x0ffffff0,
>>> + .name = "Marvell 88E1111 Ethernet",
>>> + .ops = &m88e1111_phy_ops,
>>> +};
>>> +
>>> static struct mii_phy_def *mii_phy_table[] = {
>>> &cis8201_phy_def,
>>> + &bcm5248_phy_def,
>>> + &m88e1111_phy_def,
>>> &genmii_phy_def,
>> Seems sane to me -- ACK -- but we have multiple people sending me
>> patches for a single driver. That's normal for janitorial cleanups
>> across the whole tree, but discouraged when multiple people are actively
>> working on the same driver.
>>
>> Please coordinate, and have ONE person send me patches...
>
> Who else is sending you patches? Valentine is the only one I've seen
> send patches recently...
It's a zoo :)
Al Viro (3):
typo in ibm_newemac/rgmii.c
skb->tail in ibm_newemac should be skb_tail_pointer()
ibm_newemac annotations (iomem, NULL noise)
David Gibson (1):
Device tree aware EMAC driver
Michael Ellerman (3):
Update ibm_newemac to use dcr_host_t.base
Add dcr_host_t.base in dcr_read()/dcr_write()
Use dcr_host_t.base in dcr_unmap()
Roland Dreier (2):
ibm_new_emac: Nuke SET_MODULE_OWNER() use
ibm_emac: Convert to use napi_struct independent of struct net_device
vbarshak@ru•mvista.com (1):
Fix typo in new EMAC driver.
next prev parent reply other threads:[~2007-10-15 18:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071015122616.08250b54@weaponx.rchland.ibm.com>
2007-10-15 17:57 ` [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC Valentine Barshak
2007-10-15 18:27 ` Jeff Garzik
2007-10-15 18:48 ` Josh Boyer
2007-10-15 18:53 ` Jeff Garzik [this message]
2007-10-15 18:59 ` Josh Boyer
2007-10-15 19:04 ` Jeff Garzik
2007-10-15 21:05 ` Benjamin Herrenschmidt
2007-10-15 22:47 ` Josh Boyer
2007-10-15 21:02 ` Benjamin Herrenschmidt
2007-10-23 15:20 ` Josh Boyer
2007-10-23 16:13 ` Kumar Gala
2007-10-23 16:17 ` Josh Boyer
2007-10-24 3:31 ` Benjamin Herrenschmidt
2007-10-24 19:24 ` Valentine Barshak
2007-10-15 17:58 ` [PATCH] PowerPC: Enable NEW EMAC support for Sequoia 440EPx Valentine Barshak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4713B726.6080404@garzik.org \
--to=jeff@garzik$(echo .)org \
--cc=jwboyer@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=michael@ellerman$(echo .)id.au \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vbarshak@ru$(echo .)mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox