From: Jeff Garzik <jeff@garzik•org>
To: Josh Boyer <jwboyer@linux•vnet.ibm.com>
Cc: netdev@vger•kernel.org, linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC.
Date: Mon, 15 Oct 2007 15:04:33 -0400 [thread overview]
Message-ID: <4713B9C1.5010001@garzik.org> (raw)
In-Reply-To: <20071015135959.5b603d7d@weaponx.rchland.ibm.com>
Josh Boyer wrote:
> On Mon, 15 Oct 2007 14:53:26 -0400
> Jeff Garzik <jeff@garzik•org> wrote:
>>>> Seems sane to me -- ACK -- but we have multiple people sending me
>>>> patches for a single driver. That's normal for janitorial cleanups
>>>> across the whole tree, but discouraged when multiple people are actively
>>>> working on the same driver.
>>>>
>>>> Please coordinate, and have ONE person send me patches...
>>> Who else is sending you patches? Valentine is the only one I've seen
>>> send patches recently...
>> It's a zoo :)
>
> Wow, indeed.
>
>> Al Viro (3):
>> typo in ibm_newemac/rgmii.c
>
> Val sent this as well. Either one works.
>
>> skb->tail in ibm_newemac should be skb_tail_pointer()
>> ibm_newemac annotations (iomem, NULL noise)
>
> Ack on those.
>
>> David Gibson (1):
>> Device tree aware EMAC driver
>
> That's the initial commit :)
>
>> Michael Ellerman (3):
>> Update ibm_newemac to use dcr_host_t.base
>> Add dcr_host_t.base in dcr_read()/dcr_write()
>> Use dcr_host_t.base in dcr_unmap()
>
> Missed those, but I see you applied them which is good.
>
>> Roland Dreier (2):
>> ibm_new_emac: Nuke SET_MODULE_OWNER() use
>> ibm_emac: Convert to use napi_struct independent of struct net_device
>
> I never saw either of these. I'm also beginning to wonder if one of
> them broke things because I can't currently get ibm_newemac to work.
>
>> vbarshak@ru•mvista.com (1):
>> Fix typo in new EMAC driver.
>
> Same fix as Al's.
All those are what's upstream, except for the Michael Ellerman patches.
FWIW it was generated using
git log drivers/net/ibm_newemac | git shortlog
> Anyway, we can queue patches to this through me if you'd like.
I would ideally like a single active patch generator (even if they are
merely reviewed others work sometimes).
Outside of that, I'm hoping you and the other people listed making
changes will self-organize without my help :)
Jeff
next prev parent reply other threads:[~2007-10-15 19:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071015122616.08250b54@weaponx.rchland.ibm.com>
2007-10-15 17:57 ` [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC Valentine Barshak
2007-10-15 18:27 ` Jeff Garzik
2007-10-15 18:48 ` Josh Boyer
2007-10-15 18:53 ` Jeff Garzik
2007-10-15 18:59 ` Josh Boyer
2007-10-15 19:04 ` Jeff Garzik [this message]
2007-10-15 21:05 ` Benjamin Herrenschmidt
2007-10-15 22:47 ` Josh Boyer
2007-10-15 21:02 ` Benjamin Herrenschmidt
2007-10-23 15:20 ` Josh Boyer
2007-10-23 16:13 ` Kumar Gala
2007-10-23 16:17 ` Josh Boyer
2007-10-24 3:31 ` Benjamin Herrenschmidt
2007-10-24 19:24 ` Valentine Barshak
2007-10-15 17:58 ` [PATCH] PowerPC: Enable NEW EMAC support for Sequoia 440EPx Valentine Barshak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4713B9C1.5010001@garzik.org \
--to=jeff@garzik$(echo .)org \
--cc=jwboyer@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox