From: Valentine Barshak <vbarshak@ru•mvista.com>
To: benh@kernel•crashing.org
Cc: linuxppc-dev@ozlabs•org, netdev@vger•kernel.org,
jwboyer@linux•vnet.ibm.com, jeff@garzik•org,
Stefan Roese <sr@denx•de>
Subject: Re: [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC.
Date: Wed, 24 Oct 2007 23:24:08 +0400 [thread overview]
Message-ID: <471F9BD8.905@ru.mvista.com> (raw)
In-Reply-To: <1193196718.2085.35.camel@pasglop>
Benjamin Herrenschmidt wrote:
> On Tue, 2007-10-23 at 20:57 -0500, Valentine Barshak wrote:
>
>> +static int m88e1111_init(struct mii_phy *phy)
>> +{
>> + printk("%s: Marvell 88E1111 Ethernet\n", __FUNCTION__);
>> + phy_write(phy, 0x14, 0x0ce3);
>> + phy_write(phy, 0x18, 0x4101);
>> + phy_write(phy, 0x09, 0x0e00);
>> + phy_write(phy, 0x04, 0x01e1);
>> + phy_write(phy, 0x00, 0x9140);
>> + phy_write(phy, 0x00, 0x1140);
>> +
>> + return 0;
>> +}
>
> Care to put a few comments on why the above is necessary and what it
> does ?
I think this set's up Marvell ext control (0x14) and led control (0x18)
registers with some default values, Also sets some bits in the
CTRL1000, ADVERTISE and basic mode control registers and resets the phy
for the changes to take effect. Unfortunately, I don't have a detailed
88E1111 description and can't tell anything about it. Looks like the
code was originally ported from u-boot and is needed to init the phy :)
Stefan, do you have any info on this?
Thanks,
Valentine.
>
> Thanks !
> Ben.
>
>> +static struct mii_phy_ops m88e1111_phy_ops = {
>> + .init = m88e1111_init,
>> + .setup_aneg = genmii_setup_aneg,
>> + .setup_forced = genmii_setup_forced,
>> + .poll_link = genmii_poll_link,
>> + .read_link = genmii_read_link
>> +};
>> +
>> +static struct mii_phy_def m88e1111_phy_def = {
>> +
>> + .phy_id = 0x01410CC0,
>> + .phy_id_mask = 0x0ffffff0,
>> + .name = "Marvell 88E1111 Ethernet",
>> + .ops = &m88e1111_phy_ops,
>> +};
>> +
>> static struct mii_phy_def *mii_phy_table[] = {
>> &cis8201_phy_def,
>> + &bcm5248_phy_def,
>> + &m88e1111_phy_def,
>> &genmii_phy_def,
>> NULL
>> };
>
next prev parent reply other threads:[~2007-10-24 19:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071015122616.08250b54@weaponx.rchland.ibm.com>
2007-10-15 17:57 ` [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC Valentine Barshak
2007-10-15 18:27 ` Jeff Garzik
2007-10-15 18:48 ` Josh Boyer
2007-10-15 18:53 ` Jeff Garzik
2007-10-15 18:59 ` Josh Boyer
2007-10-15 19:04 ` Jeff Garzik
2007-10-15 21:05 ` Benjamin Herrenschmidt
2007-10-15 22:47 ` Josh Boyer
2007-10-15 21:02 ` Benjamin Herrenschmidt
2007-10-23 15:20 ` Josh Boyer
2007-10-23 16:13 ` Kumar Gala
2007-10-23 16:17 ` Josh Boyer
2007-10-24 3:31 ` Benjamin Herrenschmidt
2007-10-24 19:24 ` Valentine Barshak [this message]
2007-10-15 17:58 ` [PATCH] PowerPC: Enable NEW EMAC support for Sequoia 440EPx Valentine Barshak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471F9BD8.905@ru.mvista.com \
--to=vbarshak@ru$(echo .)mvista.com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=jeff@garzik$(echo .)org \
--cc=jwboyer@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sr@denx$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox