From: Pavel Emelyanov <xemul@parallels•com>
To: Ben Hutchings <bhutchings@solarflare•com>
Cc: David Miller <davem@davemloft•net>,
Eric Dumazet <eric.dumazet@gmail•com>,
"Eric W. Biederman" <ebiederm@xmission•com>,
Linux Netdev List <netdev@vger•kernel.org>
Subject: Re: [PATCH 3/5 (resend)] veth: Allow to create peer link with given ifindex
Date: Wed, 08 Aug 2012 17:38:49 +0400 [thread overview]
Message-ID: <50226BE9.20601@parallels.com> (raw)
In-Reply-To: <1344432330.13142.188.camel@deadeye.wl.decadent.org.uk>
>> You're right, I've missed that fact :( The good news is that we still can
>> use the ifmp->ifi_index for the peer index configuration. We just need to
>> assume that if the caller specified the ifindex for the veth master device,
>> then it's aware of this possibility and should explicitly configure (or set
>> to 0) the peer's ifindex as well. Like this:
>>
>> if (ifmp && (dev->ifindex != 0))
>> peer->ifindex = ifmp->ifi_index;
>>
>> Does this assumption work from you POV?
>
> Yes, that looks like a neat way to do it. Maybe with an explanatory
> comment?
Yes, sure. I will resend the set shortly.
Thanks for the feedback!
> Ben.
>
Thanks,
Pavel
next prev parent reply other threads:[~2012-08-08 13:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 14:13 [PATCH net-next 0/6] Per-net and on-demand link indices (and related) v2 Pavel Emelyanov
2012-08-06 14:13 ` [PATCH 1/6] hash: Introduce ptr_hash_mix routine Pavel Emelyanov
2012-08-06 20:44 ` David Miller
2012-08-07 9:11 ` Pavel Emelyanov
2012-08-07 9:28 ` Eric Dumazet
2012-08-07 9:55 ` Pavel Emelyanov
2012-08-07 10:30 ` Eric Dumazet
2012-08-07 21:39 ` David Miller
2012-08-06 14:14 ` [PATCH 2/6] net: Dont use ifindices in hash fns Pavel Emelyanov
2012-08-06 14:14 ` [PATCH 3/6] net: Allow to create links with given ifindex Pavel Emelyanov
2012-08-07 11:01 ` [PATCH 2/5 (resend)] " Pavel Emelyanov
2012-08-07 13:14 ` Eric Dumazet
2012-08-07 21:42 ` David Miller
2012-08-06 14:14 ` [PATCH 4/6] veth: Allow to create peer link " Pavel Emelyanov
2012-08-07 11:02 ` [PATCH 3/5 (resend)] " Pavel Emelyanov
2012-08-07 13:14 ` Eric Dumazet
2012-08-07 18:36 ` Ben Hutchings
2012-08-08 9:00 ` Pavel Emelyanov
2012-08-08 13:25 ` Ben Hutchings
2012-08-08 13:38 ` Pavel Emelyanov [this message]
2012-08-06 14:14 ` [PATCH 5/6] net: Make ifindex generation per-net namespace Pavel Emelyanov
2012-08-07 11:02 ` [PATCH 4/5 (resend)] " Pavel Emelyanov
2012-08-07 12:11 ` Eric Dumazet
2012-08-07 12:37 ` [PATCH 4/5 (resend)] net: Make ifindex generation per-net namespace (v2) Pavel Emelyanov
2012-08-07 13:13 ` Eric Dumazet
2012-08-06 14:15 ` [PATCH 6/6] net: Loopback ifindex is constant now Pavel Emelyanov
2012-08-07 11:02 ` [PATCH 5/5 (resend)] " Pavel Emelyanov
2012-08-07 13:13 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50226BE9.20601@parallels.com \
--to=xemul@parallels$(echo .)com \
--cc=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ebiederm@xmission$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox