From: Gao feng <gaofeng@cn•fujitsu.com>
To: Hannes Frederic Sowa <hannes@stressinduktion•org>
Cc: "yoshfuji@linux-ipv6•org" <yoshfuji@linux-ipv6•org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [PATCH net] ipv6: ip6_append_data_mtu did not care about pmtudisc and frag_size
Date: Tue, 02 Jul 2013 13:42:24 +0800 [thread overview]
Message-ID: <51D26840.9070603@cn.fujitsu.com> (raw)
In-Reply-To: <20130702051841.GC9877@order.stressinduktion.org>
On 07/02/2013 01:18 PM, Hannes Frederic Sowa wrote:
> On Tue, Jul 02, 2013 at 07:13:21AM +0200, Hannes Frederic Sowa wrote:
>> On Tue, Jul 02, 2013 at 10:46:38AM +0800, Gao feng wrote:
>>> On 07/02/2013 02:17 AM, Hannes Frederic Sowa wrote:
>>> No need to pass ipv6_pinfo to ip6_append_data_mtu, the below is enough.
>>>
>>> *mtu = min(*mtu, (np->pmtudisc == IPV6_PMTUDISC_DO) ?
>>> rt->dst.dev->mtu :
>>> dst_mtu(rt->dst.path);
>>>
>>> This patch looks good go me.
>>>
>>> Acked-by: Gao feng <gaofeng@cn•fujitsu.com>
>>>
>>> Thanks!
>>
>> Thanks for your feedback, I will incooperate it in my next version of
>> the patch. Actually, I seem to have done an error in the above code,
>> i need to replace IPV6_PMTUDISC_DO with IPV6_PMTUDISC_WANT. Does your
>> Acked-by still hold?
>
> Erk, err, IPV6_PMTUDISC_PROBE was what i meant.
>
>
Yes, IPV6_PMTUDISC_PROBE is more reasonable. you can hold my ack.
prev parent reply other threads:[~2013-07-02 5:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-01 18:17 [PATCH net] ipv6: ip6_append_data_mtu did not care about pmtudisc and frag_size Hannes Frederic Sowa
2013-07-01 18:23 ` Hannes Frederic Sowa
2013-07-02 2:46 ` Gao feng
2013-07-02 5:13 ` Hannes Frederic Sowa
2013-07-02 5:18 ` Hannes Frederic Sowa
2013-07-02 5:42 ` Gao feng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D26840.9070603@cn.fujitsu.com \
--to=gaofeng@cn$(echo .)fujitsu.com \
--cc=hannes@stressinduktion$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox