From: roopa <roopa@cumulusnetworks•com>
To: Thomas Graf <tgraf@suug•ch>
Cc: netdev@vger•kernel.org, shemminger@vyatta•com,
vyasevic@redhat•com, john.fastabend@gmail•com, jhs@mojatatu•com,
sfeldma@gmail•com, jiri@resnulli•us, wkok@cumulusnetworks•com
Subject: Re: [PATCH net-next] bridge: fix setlink/dellink notifications
Date: Wed, 14 Jan 2015 12:57:12 -0800 [thread overview]
Message-ID: <54B6D828.3030204@cumulusnetworks.com> (raw)
In-Reply-To: <20150114194137.GC2105@casper.infradead.org>
On 1/14/15, 11:41 AM, Thomas Graf wrote:
> On 01/13/15 at 10:48pm, roopa@cumulusnetworks•com wrote:
>> 2) Generate one notification from master and the other notification from
>> self (This seems to be ideal):
>> For master: the master driver will send notification (bridge in this
>> example)
>> For self: the self driver will send notification (rocker in the above
>> example. It can use helpers from rtnetlink.c to do so. Like the
>> ndo_dflt_bridge_getlink api).
>>
>> This patch implements 2) (leaving the 'rtnl_bridge_notify' around to be used
>> with 'self').
>>
>> CC'ing others who might be affected by this change for review.
>>
>> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks•com>
> I haven't digested this line by line yet but I agree that what you
> describe above would be a good end state.
>
> If I read the patch correctly then we would omit one notification
> for the master case.
yes, correct.
> Were both notifications exactly identical
> previously?
> This has the chance of breaking existing users terribly.
yes AFAICT, because
rtnl_bridge_notify() from rtnetlink.c for bridge results in calling
br_fill_ifinfo() via ndo_bridge_getlink()
and the notification from bridge driver br_ifinfo_notify() also ends up
calling br_fill_ifinfo().
Thanks,
Roopa
next prev parent reply other threads:[~2015-01-14 20:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 6:48 [PATCH net-next] bridge: fix setlink/dellink notifications roopa
2015-01-14 19:41 ` Thomas Graf
2015-01-14 20:57 ` roopa [this message]
2015-01-14 23:22 ` Arad, Ronen
2015-01-14 23:36 ` John Fastabend
2015-01-14 23:56 ` roopa
2015-01-15 0:01 ` tgraf
2015-01-14 23:54 ` roopa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B6D828.3030204@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=john.fastabend@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sfeldma@gmail$(echo .)com \
--cc=shemminger@vyatta$(echo .)com \
--cc=tgraf@suug$(echo .)ch \
--cc=vyasevic@redhat$(echo .)com \
--cc=wkok@cumulusnetworks$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox