From: roopa <roopa@cumulusnetworks•com>
To: John Fastabend <john.fastabend@gmail•com>
Cc: "Arad, Ronen" <ronen.arad@intel•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"shemminger@vyatta•com" <shemminger@vyatta•com>,
"vyasevic@redhat•com" <vyasevic@redhat•com>,
"tgraf@suug•ch" <tgraf@suug•ch>,
"jhs@mojatatu•com" <jhs@mojatatu•com>,
"sfeldma@gmail•com" <sfeldma@gmail•com>,
"jiri@resnulli•us" <jiri@resnulli•us>,
"wkok@cumulusnetworks•com" <wkok@cumulusnetworks•com>
Subject: Re: [PATCH net-next] bridge: fix setlink/dellink notifications
Date: Wed, 14 Jan 2015 15:56:02 -0800 [thread overview]
Message-ID: <54B70212.5050705@cumulusnetworks.com> (raw)
In-Reply-To: <54B6FD60.8020106@gmail.com>
On 1/14/15, 3:36 PM, John Fastabend wrote:
> On 01/14/2015 03:22 PM, Arad, Ronen wrote:
>>
>>
>>> -----Original Message-----
>>> From: netdev-owner@vger•kernel.org
>>> [mailto:netdev-owner@vger•kernel.org] On
>>> Behalf Of roopa@cumulusnetworks•com
>>> Sent: Tuesday, January 13, 2015 10:49 PM
>>> To: netdev@vger•kernel.org; shemminger@vyatta•com; vyasevic@redhat•com;
>>> john.fastabend@gmail•com; tgraf@suug•ch; jhs@mojatatu•com;
>>> sfeldma@gmail•com;
>>> jiri@resnulli•us
>>> Cc: wkok@cumulusnetworks•com
>>> Subject: [PATCH net-next] bridge: fix setlink/dellink notifications
>>>
>>> From: Roopa Prabhu <roopa@cumulusnetworks•com>
>>>
>> [..]
>
> [...]
>
>>> err = dev->netdev_ops->ndo_bridge_setlink(dev, nlh);
>>> -
>>> - if (!err)
>>> + if (!err) {
>>> flags &= ~BRIDGE_FLAGS_SELF;
>>> +
>>> + /* Generate event to notify upper layer of bridge
>>> + * change
>>> + */
>>> + if (!err)
>>> + err = rtnl_bridge_notify(dev, oflags);
>>> + }
>>> }
>>>
>>> if (have_flags)
>>> memcpy(nla_data(attr), &flags, sizeof(flags));
>>
>> What is the purpose of the above two lines (not changed by the patch)?
>> They seem to copy over the flags with the successfully applied cases
>> (MASTER and/or SELF) flags cleared back into the incoming netlink
>> message.
>> I could not figure any place where the modified flags attribute is used
>
> This allows userspace to learn which operation failed when it is an
> operation to set both the software bridge via BRIDGE_FLAGS_MASTER and
> the the hardware via BRIDGE_FLAGS_SELF. When we get the error back
> software looks at the flags to figure out how to recover/retry/etc.
Ah ok, I was also wondering why that was there,
thanks,
Roopa
next prev parent reply other threads:[~2015-01-14 23:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 6:48 [PATCH net-next] bridge: fix setlink/dellink notifications roopa
2015-01-14 19:41 ` Thomas Graf
2015-01-14 20:57 ` roopa
2015-01-14 23:22 ` Arad, Ronen
2015-01-14 23:36 ` John Fastabend
2015-01-14 23:56 ` roopa [this message]
2015-01-15 0:01 ` tgraf
2015-01-14 23:54 ` roopa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B70212.5050705@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=john.fastabend@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ronen.arad@intel$(echo .)com \
--cc=sfeldma@gmail$(echo .)com \
--cc=shemminger@vyatta$(echo .)com \
--cc=tgraf@suug$(echo .)ch \
--cc=vyasevic@redhat$(echo .)com \
--cc=wkok@cumulusnetworks$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox