From: roopa <roopa@cumulusnetworks•com>
To: "Arad, Ronen" <ronen.arad@intel•com>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"shemminger@vyatta•com" <shemminger@vyatta•com>,
"vyasevic@redhat•com" <vyasevic@redhat•com>,
"john.fastabend@gmail•com" <john.fastabend@gmail•com>,
"tgraf@suug•ch" <tgraf@suug•ch>,
"jhs@mojatatu•com" <jhs@mojatatu•com>,
"sfeldma@gmail•com" <sfeldma@gmail•com>,
"jiri@resnulli•us" <jiri@resnulli•us>,
"wkok@cumulusnetworks•com" <wkok@cumulusnetworks•com>
Subject: Re: [PATCH net-next] bridge: fix setlink/dellink notifications
Date: Wed, 14 Jan 2015 15:54:36 -0800 [thread overview]
Message-ID: <54B701BC.4090209@cumulusnetworks.com> (raw)
In-Reply-To: <E4CD12F19ABA0C4D8729E087A761DC3505DEE86A@ORSMSX101.amr.corp.intel.com>
On 1/14/15, 3:22 PM, Arad, Ronen wrote:
>
>> -----Original Message-----
>> From: netdev-owner@vger•kernel.org [mailto:netdev-owner@vger•kernel.org] On
>> Behalf Of roopa@cumulusnetworks•com
>> Sent: Tuesday, January 13, 2015 10:49 PM
>> To: netdev@vger•kernel.org; shemminger@vyatta•com; vyasevic@redhat•com;
>> john.fastabend@gmail•com; tgraf@suug•ch; jhs@mojatatu•com; sfeldma@gmail•com;
>> jiri@resnulli•us
>> Cc: wkok@cumulusnetworks•com
>> Subject: [PATCH net-next] bridge: fix setlink/dellink notifications
>>
>> From: Roopa Prabhu <roopa@cumulusnetworks•com>
>>
> [..]
>> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
>> index d06107d..4ac79ff 100644
>> --- a/net/core/rtnetlink.c
>> +++ b/net/core/rtnetlink.c
>> @@ -2876,13 +2876,6 @@ static int rtnl_bridge_notify(struct net_device *dev,
>> u16 flags)
> The 'flags' argument was only used for applying the same handling of
> MASTER/SELF flags to notification as used for setlink/delink.
> This patch eliminates the MASTER case and leaves only SELF notification.
> It seems clearer to eliminate flags argument and rename the function to
> something like rtnl_bridge_self_notify().
sure, if that makes it clearer.
Thanks,
Roopa
prev parent reply other threads:[~2015-01-14 23:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 6:48 [PATCH net-next] bridge: fix setlink/dellink notifications roopa
2015-01-14 19:41 ` Thomas Graf
2015-01-14 20:57 ` roopa
2015-01-14 23:22 ` Arad, Ronen
2015-01-14 23:36 ` John Fastabend
2015-01-14 23:56 ` roopa
2015-01-15 0:01 ` tgraf
2015-01-14 23:54 ` roopa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B701BC.4090209@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=john.fastabend@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ronen.arad@intel$(echo .)com \
--cc=sfeldma@gmail$(echo .)com \
--cc=shemminger@vyatta$(echo .)com \
--cc=tgraf@suug$(echo .)ch \
--cc=vyasevic@redhat$(echo .)com \
--cc=wkok@cumulusnetworks$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox