From: Jamal Hadi Salim <jhs@mojatatu•com>
To: sfeldma@gmail•com, netdev@vger•kernel.org, davem@davemloft•net,
jiri@resnulli•us, roopa@cumulusnetworks•com,
alexander.h.duyck@redhat•com
Subject: Re: [PATCH net-next v4 2/8] netdevice: add IPv4 fib add/del ops
Date: Fri, 06 Mar 2015 09:55:07 -0500 [thread overview]
Message-ID: <54F9BFCB.5030100@mojatatu.com> (raw)
In-Reply-To: <1425619280-27492-3-git-send-email-sfeldma@gmail.com>
On 03/06/15 00:21, sfeldma@gmail•com wrote:
> From: Scott Feldman <sfeldma@gmail•com>
>
> Add two new ndo ops for IPv4 fib offload support, add and del. Add uses
> modifiy semantics if fib entry already offloaded.
The above semantic will not express correctly the intent that the tools
like iproute2 expose and user space expects.
I think you need to pass the netlink flags to do it correctly at
the driver level.
i.e classical table operations per netlink flags (NLM_F_CREATE,
NLM_F_REPLACE, NLM_F_EXCL, NLM_F_APPEND)
1) Create: NLM_F_CREATE
2) Create exclusively i.e reject if already created
(NLM_F_CREATE|NLM_F_EXCL)
3) Create or modify (which is the semantic you are refering to)
NLM_F_CREATE|NLM_F_REPLACE
4) Append - which means "I dont care if it exists, just append it"
NLM_F_CREATE|NLM_F_APPEND
cheers,
jamal
next prev parent reply other threads:[~2015-03-06 14:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 5:21 [PATCH net-next v4 0/8] switchdev: add IPv4 routing offload sfeldma
2015-03-06 5:21 ` [PATCH net-next v4 1/8] rtnetlink: add RTNH_F_EXTERNAL flag for fib offload sfeldma
2015-03-06 5:21 ` [PATCH net-next v4 2/8] netdevice: add IPv4 fib add/del ops sfeldma
2015-03-06 14:55 ` Jamal Hadi Salim [this message]
2015-03-06 19:59 ` Scott Feldman
2015-03-08 14:31 ` roopa
2015-03-08 22:16 ` Scott Feldman
2015-03-09 6:22 ` roopa
2015-03-09 8:38 ` Scott Feldman
2015-03-09 13:47 ` Jamal Hadi Salim
2015-03-09 18:07 ` Scott Feldman
2015-03-06 5:21 ` [PATCH net-next v4 3/8] switchdev: add IPv4 fib ndo ops wrappers sfeldma
2015-03-06 5:21 ` [PATCH net-next v4 4/8] switchdev: don't support custom ip rules, for now sfeldma
2015-03-06 5:21 ` [PATCH net-next v4 5/8] switchdev: implement IPv4 fib ndo wrappers sfeldma
2015-03-06 7:24 ` Jiri Pirko
2015-03-06 9:38 ` Scott Feldman
2015-03-06 11:53 ` Jiri Pirko
2015-03-06 5:21 ` [PATCH net-next v4 6/8] ipv4: add net bool fib_offload_disabled sfeldma
2015-03-06 5:21 ` [PATCH net-next v4 7/8] fib: hook IPv4 fib for hardware offload sfeldma
2015-03-06 5:21 ` [PATCH net-next v4 8/8] rocker: implement IPv4 fib offloading sfeldma
2015-03-06 5:27 ` [PATCH net-next v4 0/8] switchdev: add IPv4 routing offload David Miller
2015-03-06 15:43 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F9BFCB.5030100@mojatatu.com \
--to=jhs@mojatatu$(echo .)com \
--cc=alexander.h.duyck@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
--cc=roopa@cumulusnetworks$(echo .)com \
--cc=sfeldma@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox