From: Lino Sanfilippo <LinoSanfilippo@gmx•de>
To: cliff_clark@selinc•com, Li Yang <leoli@freescale•com>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH] ucc_geth: Intialize link state to down before register_netdev
Date: Tue, 24 Mar 2015 20:30:00 +0100 [thread overview]
Message-ID: <5511BB38.8010501@gmx.de> (raw)
In-Reply-To: <OF515B2C92.39F94674-ON88257E12.00676FA3-88257E12.00679D6B@selinc.com>
On 24.03.2015 19:51, cliff_clark@selinc•com wrote:
> ucc_geth was indicating link up after a port is administratively enabled
> even
> when nothing is plugged in. This causes user-space tools to see a
> spurious link
> up the first time after boot.
>
> Signed-off-by: Cliff Clark <cliff_clark@selinc•com>
> ---
> drivers/net/ethernet/freescale/ucc_geth.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ethernet/freescale/ucc_geth.c
> b/drivers/net/ethernet/freescale/ucc_geth.c
> index 357e8b57..56b774d 100644
> --- a/drivers/net/ethernet/freescale/ucc_geth.c
> +++ b/drivers/net/ethernet/freescale/ucc_geth.c
> @@ -3893,6 +3893,9 @@ static int ucc_geth_probe(struct platform_device*
> ofdev)
> ugeth->phy_interface = phy_interface;
> ugeth->max_speed = max_speed;
>
> + /* Carrier starts down, phylib will bring it up */
> + netif_carrier_off(dev);
> +
> err = register_netdev(dev);
> if (err) {
> if (netif_msg_probe(ugeth))
The commit message is still messy. checkpatch also complaints about
spaces at the beginning of a line.
Regards,
Lino
next prev parent reply other threads:[~2015-03-24 19:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 18:51 [PATCH] ucc_geth: Intialize link state to down before register_netdev cliff_clark
2015-03-24 19:30 ` Lino Sanfilippo [this message]
2015-03-24 19:41 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2015-03-24 21:07 Cliff Clark
2015-03-24 22:03 ` David Miller
2015-03-23 16:47 cliff_clark
2015-03-23 22:03 ` Li Yang
2015-03-24 1:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5511BB38.8010501@gmx.de \
--to=linosanfilippo@gmx$(echo .)de \
--cc=cliff_clark@selinc$(echo .)com \
--cc=leoli@freescale$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox