* Re: [PATCH] ucc_geth: Intialize link state to down before register_netdev
@ 2015-03-24 18:51 cliff_clark
2015-03-24 19:30 ` Lino Sanfilippo
2015-03-24 19:41 ` David Miller
0 siblings, 2 replies; 8+ messages in thread
From: cliff_clark @ 2015-03-24 18:51 UTC (permalink / raw)
To: Li Yang; +Cc: netdev
ucc_geth was indicating link up after a port is administratively enabled
even
when nothing is plugged in. This causes user-space tools to see a
spurious link
up the first time after boot.
Signed-off-by: Cliff Clark <cliff_clark@selinc•com>
---
drivers/net/ethernet/freescale/ucc_geth.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/freescale/ucc_geth.c
b/drivers/net/ethernet/freescale/ucc_geth.c
index 357e8b57..56b774d 100644
--- a/drivers/net/ethernet/freescale/ucc_geth.c
+++ b/drivers/net/ethernet/freescale/ucc_geth.c
@@ -3893,6 +3893,9 @@ static int ucc_geth_probe(struct platform_device*
ofdev)
ugeth->phy_interface = phy_interface;
ugeth->max_speed = max_speed;
+ /* Carrier starts down, phylib will bring it up */
+ netif_carrier_off(dev);
+
err = register_netdev(dev);
if (err) {
if (netif_msg_probe(ugeth))
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ucc_geth: Intialize link state to down before register_netdev
2015-03-24 18:51 [PATCH] ucc_geth: Intialize link state to down before register_netdev cliff_clark
@ 2015-03-24 19:30 ` Lino Sanfilippo
2015-03-24 19:41 ` David Miller
1 sibling, 0 replies; 8+ messages in thread
From: Lino Sanfilippo @ 2015-03-24 19:30 UTC (permalink / raw)
To: cliff_clark, Li Yang; +Cc: netdev
On 24.03.2015 19:51, cliff_clark@selinc•com wrote:
> ucc_geth was indicating link up after a port is administratively enabled
> even
> when nothing is plugged in. This causes user-space tools to see a
> spurious link
> up the first time after boot.
>
> Signed-off-by: Cliff Clark <cliff_clark@selinc•com>
> ---
> drivers/net/ethernet/freescale/ucc_geth.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ethernet/freescale/ucc_geth.c
> b/drivers/net/ethernet/freescale/ucc_geth.c
> index 357e8b57..56b774d 100644
> --- a/drivers/net/ethernet/freescale/ucc_geth.c
> +++ b/drivers/net/ethernet/freescale/ucc_geth.c
> @@ -3893,6 +3893,9 @@ static int ucc_geth_probe(struct platform_device*
> ofdev)
> ugeth->phy_interface = phy_interface;
> ugeth->max_speed = max_speed;
>
> + /* Carrier starts down, phylib will bring it up */
> + netif_carrier_off(dev);
> +
> err = register_netdev(dev);
> if (err) {
> if (netif_msg_probe(ugeth))
The commit message is still messy. checkpatch also complaints about
spaces at the beginning of a line.
Regards,
Lino
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ucc_geth: Intialize link state to down before register_netdev
2015-03-24 18:51 [PATCH] ucc_geth: Intialize link state to down before register_netdev cliff_clark
2015-03-24 19:30 ` Lino Sanfilippo
@ 2015-03-24 19:41 ` David Miller
1 sibling, 0 replies; 8+ messages in thread
From: David Miller @ 2015-03-24 19:41 UTC (permalink / raw)
To: cliff_clark; +Cc: leoli, netdev
From: cliff_clark@selinc•com
Date: Tue, 24 Mar 2015 11:51:44 -0700
> ucc_geth was indicating link up after a port is administratively enabled
> even
> when nothing is plugged in. This causes user-space tools to see a
> spurious link
> up the first time after boot.
Your commit message is still mis-formatted. Use a plain ASCII editor
to create your commit message, rather than a graphical user interface.
> --- a/drivers/net/ethernet/freescale/ucc_geth.c
> +++ b/drivers/net/ethernet/freescale/ucc_geth.c
> @@ -3893,6 +3893,9 @@ static int ucc_geth_probe(struct platform_device*
> ofdev)
Your email client corrupted your patch.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ucc_geth: Intialize link state to down before register_netdev
@ 2015-03-24 21:07 Cliff Clark
2015-03-24 22:03 ` David Miller
0 siblings, 1 reply; 8+ messages in thread
From: Cliff Clark @ 2015-03-24 21:07 UTC (permalink / raw)
To: LeoLi; +Cc: netdev, Cliff Clark
From: Cliff Clark <cliff_clark@selinc•com>
ucc_geth was indicating link up after a port is administratively enabled even
when nothing is plugged in. This causes user-space tools to see a spurious link
up the first time after boot.
Signed-off-by: Cliff Clark <cliff_clark@selinc•com>
---
drivers/net/ethernet/freescale/ucc_geth.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c
index 357e8b57..56b774d 100644
--- a/drivers/net/ethernet/freescale/ucc_geth.c
+++ b/drivers/net/ethernet/freescale/ucc_geth.c
@@ -3893,6 +3893,9 @@ static int ucc_geth_probe(struct platform_device* ofdev)
ugeth->phy_interface = phy_interface;
ugeth->max_speed = max_speed;
+ /* Carrier starts down, phylib will bring it up */
+ netif_carrier_off(dev);
+
err = register_netdev(dev);
if (err) {
if (netif_msg_probe(ugeth))
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ucc_geth: Intialize link state to down before register_netdev
2015-03-24 21:07 Cliff Clark
@ 2015-03-24 22:03 ` David Miller
0 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2015-03-24 22:03 UTC (permalink / raw)
To: cliff_clark; +Cc: LeoLi, netdev
From: "Cliff Clark" <cliff_clark@selinc•com>
Date: Tue, 24 Mar 2015 14:07:26 -0700
> From: Cliff Clark <cliff_clark@selinc•com>
>
> ucc_geth was indicating link up after a port is administratively enabled even
> when nothing is plugged in. This causes user-space tools to see a spurious link
> up the first time after boot.
>
> Signed-off-by: Cliff Clark <cliff_clark@selinc•com>
Applied, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ucc_geth: Intialize link state to down before register_netdev
@ 2015-03-23 16:47 cliff_clark
2015-03-23 22:03 ` Li Yang
0 siblings, 1 reply; 8+ messages in thread
From: cliff_clark @ 2015-03-23 16:47 UTC (permalink / raw)
To: Li Yang; +Cc: netdev
ucc_geth was indicating link up after a port is administratively enabled
even
when nothing is plugged in. This causes user-space tools to see a
spurious link
up the first time after boot.
Signed-off-by: Cliff Clark <cliff_clark@selinc•com>
---
drivers/net/ethernet/freescale/ucc_geth.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/freescale/ucc_geth.c
b/drivers/net/ethernet/freescale/ucc_geth.c
index 357e8b57..56b774d 100644
--- a/drivers/net/ethernet/freescale/ucc_geth.c
+++ b/drivers/net/ethernet/freescale/ucc_geth.c
@@ -3893,6 +3893,9 @@ static int ucc_geth_probe(struct platform_device*
ofdev)
ugeth->phy_interface = phy_interface;
ugeth->max_speed = max_speed;
+ /* Carrier starts down, phylib will bring it up */
+ netif_carrier_off(dev);
+
err = register_netdev(dev);
if (err) {
if (netif_msg_probe(ugeth))
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ucc_geth: Intialize link state to down before register_netdev
2015-03-23 16:47 cliff_clark
@ 2015-03-23 22:03 ` Li Yang
2015-03-24 1:41 ` David Miller
0 siblings, 1 reply; 8+ messages in thread
From: Li Yang @ 2015-03-23 22:03 UTC (permalink / raw)
To: cliff_clark; +Cc: Netdev
On Mon, Mar 23, 2015 at 11:47 AM, <cliff_clark@selinc•com> wrote:
> ucc_geth was indicating link up after a port is administratively enabled
> even
> when nothing is plugged in. This causes user-space tools to see a
> spurious link
> up the first time after boot.
>
> Signed-off-by: Cliff Clark <cliff_clark@selinc•com>
Ack for the change, but the commit message is having messy line breaks.
- Leo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ucc_geth: Intialize link state to down before register_netdev
2015-03-23 22:03 ` Li Yang
@ 2015-03-24 1:41 ` David Miller
0 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2015-03-24 1:41 UTC (permalink / raw)
To: leoli; +Cc: cliff_clark, netdev
From: Li Yang <leoli@freescale•com>
Date: Mon, 23 Mar 2015 17:03:59 -0500
> On Mon, Mar 23, 2015 at 11:47 AM, <cliff_clark@selinc•com> wrote:
>> ucc_geth was indicating link up after a port is administratively enabled
>> even
>> when nothing is plugged in. This causes user-space tools to see a
>> spurious link
>> up the first time after boot.
>>
>> Signed-off-by: Cliff Clark <cliff_clark@selinc•com>
>
> Ack for the change, but the commit message is having messy line breaks.
Yes, it's really ugly, please fix this.
Don't reply upon a graphical UI or whatever to format these commit
messages properly. Use a plain ASCII text editor and get the column
breaks right.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-03-24 22:03 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-24 18:51 [PATCH] ucc_geth: Intialize link state to down before register_netdev cliff_clark
2015-03-24 19:30 ` Lino Sanfilippo
2015-03-24 19:41 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2015-03-24 21:07 Cliff Clark
2015-03-24 22:03 ` David Miller
2015-03-23 16:47 cliff_clark
2015-03-23 22:03 ` Li Yang
2015-03-24 1:41 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox