From: Kalle Valo <kvalo@codeaurora•org>
To: Arnd Bergmann <arnd@kernel•org>
Cc: Bjorn Andersson <bjorn.andersson@linaro•org>,
Arnd Bergmann <arnd@arndb•de>, Rob Clark <robdclark@gmail•com>,
Sean Paul <sean@poorly•run>, David Airlie <airlied@linux•ie>,
Daniel Vetter <daniel@ffwll•ch>, Joerg Roedel <joro@8bytes•org>,
Will Deacon <will@kernel•org>,
Mauro Carvalho Chehab <mchehab@kernel•org>,
Ulf Hansson <ulf.hansson@linaro•org>,
Alex Elder <elder@kernel•org>,
"David S. Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>, Andy Gross <agross@kernel•org>,
Linus Walleij <linus.walleij@linaro•org>,
Maxime Ripard <mripard@kernel•org>, Chen-Yu Tsai <wens@csie•org>,
Jernej Skrabec <jernej.skrabec@gmail•com>,
Mark Rutland <mark.rutland@arm•com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm•com>,
Sudeep Holla <sudeep.holla@arm•com>,
linux-kernel@vger•kernel.org, linux-arm-msm@vger•kernel.org,
dri-devel@lists•freedesktop.org, freedreno@lists•freedesktop.org,
iommu@lists•linux-foundation.org, linux-media@vger•kernel.org,
linux-mmc@vger•kernel.org, netdev@vger•kernel.org,
ath10k@lists•infradead.org, linux-wireless@vger•kernel.org,
linux-gpio@vger•kernel.org, linux-arm-kernel@lists•infradead.org,
linux-sunxi@lists•linux.dev
Subject: Re: [PATCH] [RFC] qcom_scm: hide Kconfig symbol
Date: Tue, 28 Sep 2021 10:03:25 +0300 [thread overview]
Message-ID: <87k0j1qj0i.fsf@codeaurora.org> (raw)
In-Reply-To: <20210927152412.2900928-1-arnd@kernel.org> (Arnd Bergmann's message of "Mon, 27 Sep 2021 17:22:13 +0200")
Arnd Bergmann <arnd@kernel•org> writes:
> From: Arnd Bergmann <arnd@arndb•de>
>
> Now that SCM can be a loadable module, we have to add another
> dependency to avoid link failures when ipa or adreno-gpu are
> built-in:
>
> aarch64-linux-ld: drivers/net/ipa/ipa_main.o: in function `ipa_probe':
> ipa_main.c:(.text+0xfc4): undefined reference to `qcom_scm_is_available'
>
> ld.lld: error: undefined symbol: qcom_scm_is_available
>>>> referenced by adreno_gpu.c
>>>> gpu/drm/msm/adreno/adreno_gpu.o:(adreno_zap_shader_load)
>>>> in archive drivers/built-in.a
>
> This can happen when CONFIG_ARCH_QCOM is disabled and we don't select
> QCOM_MDT_LOADER, but some other module selects QCOM_SCM. Ideally we'd
> use a similar dependency here to what we have for QCOM_RPROC_COMMON,
> but that causes dependency loops from other things selecting QCOM_SCM.
>
> This appears to be an endless problem, so try something different this
> time:
>
> - CONFIG_QCOM_SCM becomes a hidden symbol that nothing 'depends on'
> but that is simply selected by all of its users
>
> - All the stubs in include/linux/qcom_scm.h can go away
>
> - arm-smccc.h needs to provide a stub for __arm_smccc_smc() to
> allow compile-testing QCOM_SCM on all architectures.
>
> - To avoid a circular dependency chain involving RESET_CONTROLLER
> and PINCTRL_SUNXI, change the 'depends on RESET_CONTROLLER' in
> the latter one to 'select'.
>
> The last bit is rather annoying, as drivers should generally never
> 'select' another subsystem, and about half the users of the reset
> controller interface do this anyway.
>
> Nevertheless, this version seems to pass all my randconfig tests
> and is more robust than any of the prior versions.
>
> Comments?
>
> Signed-off-by: Arnd Bergmann <arnd@arndb•de>
[...]
> diff --git a/drivers/net/wireless/ath/ath10k/Kconfig b/drivers/net/wireless/ath/ath10k/Kconfig
> index 741289e385d5..ca007b800f75 100644
> --- a/drivers/net/wireless/ath/ath10k/Kconfig
> +++ b/drivers/net/wireless/ath/ath10k/Kconfig
> @@ -44,7 +44,7 @@ config ATH10K_SNOC
> tristate "Qualcomm ath10k SNOC support"
> depends on ATH10K
> depends on ARCH_QCOM || COMPILE_TEST
> - depends on QCOM_SCM || !QCOM_SCM #if QCOM_SCM=m this can't be =y
> + select QCOM_SCM
> select QCOM_QMI_HELPERS
> help
> This module adds support for integrated WCN3990 chip connected
I assume I can continue to build test ATH10K_SNOC with x86 as before?
That's important for me. If yes, then:
Acked-by: Kalle Valo <kvalo@codeaurora•org>
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-09-28 7:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 15:22 [PATCH] [RFC] qcom_scm: hide Kconfig symbol Arnd Bergmann
2021-09-27 19:52 ` Bjorn Andersson
2021-09-27 20:15 ` Arnd Bergmann
2021-09-27 20:42 ` Bjorn Andersson
2021-09-27 20:47 ` Arnd Bergmann
2021-09-28 7:03 ` Kalle Valo [this message]
2021-09-28 7:08 ` Arnd Bergmann
2021-09-29 9:51 ` Will Deacon
2021-09-29 10:04 ` Arnd Bergmann
2021-09-29 14:46 ` Bjorn Andersson
2021-09-29 18:30 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0j1qj0i.fsf@codeaurora.org \
--to=kvalo@codeaurora$(echo .)org \
--cc=agross@kernel$(echo .)org \
--cc=airlied@linux$(echo .)ie \
--cc=arnd@arndb$(echo .)de \
--cc=arnd@kernel$(echo .)org \
--cc=ath10k@lists$(echo .)infradead.org \
--cc=bjorn.andersson@linaro$(echo .)org \
--cc=daniel@ffwll$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=elder@kernel$(echo .)org \
--cc=freedreno@lists$(echo .)freedesktop.org \
--cc=iommu@lists$(echo .)linux-foundation.org \
--cc=jernej.skrabec@gmail$(echo .)com \
--cc=joro@8bytes$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-gpio@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-mmc@vger$(echo .)kernel.org \
--cc=linux-sunxi@lists$(echo .)linux.dev \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=lorenzo.pieralisi@arm$(echo .)com \
--cc=mark.rutland@arm$(echo .)com \
--cc=mchehab@kernel$(echo .)org \
--cc=mripard@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=robdclark@gmail$(echo .)com \
--cc=sean@poorly$(echo .)run \
--cc=sudeep.holla@arm$(echo .)com \
--cc=ulf.hansson@linaro$(echo .)org \
--cc=wens@csie$(echo .)org \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox