From: Bjorn Andersson <bjorn.andersson@linaro•org>
To: Arnd Bergmann <arnd@kernel•org>
Cc: Will Deacon <will@kernel•org>, Arnd Bergmann <arnd@arndb•de>,
Rob Clark <robdclark@gmail•com>, Sean Paul <sean@poorly•run>,
David Airlie <airlied@linux•ie>, Daniel Vetter <daniel@ffwll•ch>,
Joerg Roedel <joro@8bytes•org>,
Mauro Carvalho Chehab <mchehab@kernel•org>,
Ulf Hansson <ulf.hansson@linaro•org>,
Alex Elder <elder@kernel•org>,
"David S. Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>,
Kalle Valo <kvalo@codeaurora•org>, Andy Gross <agross@kernel•org>,
Linus Walleij <linus.walleij@linaro•org>,
Maxime Ripard <mripard@kernel•org>, Chen-Yu Tsai <wens@csie•org>,
Jernej Skrabec <jernej.skrabec@gmail•com>,
Mark Rutland <mark.rutland@arm•com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm•com>,
Sudeep Holla <sudeep.holla@arm•com>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
linux-arm-msm <linux-arm-msm@vger•kernel.org>,
dri-devel <dri-devel@lists•freedesktop.org>,
freedreno <freedreno@lists•freedesktop.org>,
"open list:IOMMU DRIVERS" <iommu@lists•linux-foundation.org>,
Linux Media Mailing List <linux-media@vger•kernel.org>,
linux-mmc <linux-mmc@vger•kernel.org>,
Networking <netdev@vger•kernel.org>,
ath10k@lists•infradead.org,
linux-wireless <linux-wireless@vger•kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger•kernel.org>,
Linux ARM <linux-arm-kernel@lists•infradead.org>,
linux-sunxi@lists•linux.dev
Subject: Re: [PATCH] [RFC] qcom_scm: hide Kconfig symbol
Date: Wed, 29 Sep 2021 09:46:27 -0500 [thread overview]
Message-ID: <YVR8Q7LO0weiFin+@yoga> (raw)
In-Reply-To: <CAK8P3a2QnJkYCoEWhziYYXQusb-25_wUhA5ZTGtBsyfFx3NWzQ@mail.gmail.com>
On Wed 29 Sep 05:04 CDT 2021, Arnd Bergmann wrote:
> On Wed, Sep 29, 2021 at 11:51 AM Will Deacon <will@kernel•org> wrote:
> > On Mon, Sep 27, 2021 at 05:22:13PM +0200, Arnd Bergmann wrote:
> > >
> > > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> > > index 124c41adeca1..989c83acbfee 100644
> > > --- a/drivers/iommu/Kconfig
> > > +++ b/drivers/iommu/Kconfig
> > > @@ -308,7 +308,7 @@ config APPLE_DART
> > > config ARM_SMMU
> > > tristate "ARM Ltd. System MMU (SMMU) Support"
> > > depends on ARM64 || ARM || (COMPILE_TEST && !GENERIC_ATOMIC64)
> > > - depends on QCOM_SCM || !QCOM_SCM #if QCOM_SCM=m this can't be =y
> > > + select QCOM_SCM
> > > select IOMMU_API
> > > select IOMMU_IO_PGTABLE_LPAE
> > > select ARM_DMA_USE_IOMMU if ARM
> >
> > I don't want to get in the way of this patch because I'm also tired of the
> > randconfig failures caused by QCOM_SCM. However, ARM_SMMU is applicable to
> > a wide variety of (non-qcom) SoCs and so it seems a shame to require the
> > QCOM_SCM code to be included for all of those when it's not strictly needed
> > at all.
>
> Good point, I agree that needs to be fixed. I think this additional
> change should do the trick:
>
ARM_SMMU and QCOM_IOMMU are two separate implementations and both uses
QCOM_SCM. So both of them should select QCOM_SCM.
"Unfortunately" the Qualcomm portion of ARM_SMMU is builtin
unconditionally, so going with something like select QCOM_SCM if
ARCH_QCOM would still require the stubs in qcom_scm.h.
Regards,
Bjorn
> --- a/drivers/iommu/Kconfig
> +++ b/drivers/iommu/Kconfig
> @@ -308,7 +308,6 @@ config APPLE_DART
> config ARM_SMMU
> tristate "ARM Ltd. System MMU (SMMU) Support"
> depends on ARM64 || ARM || (COMPILE_TEST && !GENERIC_ATOMIC64)
> - select QCOM_SCM
> select IOMMU_API
> select IOMMU_IO_PGTABLE_LPAE
> select ARM_DMA_USE_IOMMU if ARM
> @@ -438,7 +437,7 @@ config QCOM_IOMMU
> # Note: iommu drivers cannot (yet?) be built as modules
> bool "Qualcomm IOMMU Support"
> depends on ARCH_QCOM || (COMPILE_TEST && !GENERIC_ATOMIC64)
> - depends on QCOM_SCM=y
> + select QCOM_SCM
> select IOMMU_API
> select IOMMU_IO_PGTABLE_LPAE
> select ARM_DMA_USE_IOMMU
>
> I'll see if that causes any problems for the randconfig builds.
>
> Arnd
next prev parent reply other threads:[~2021-09-29 14:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 15:22 [PATCH] [RFC] qcom_scm: hide Kconfig symbol Arnd Bergmann
2021-09-27 19:52 ` Bjorn Andersson
2021-09-27 20:15 ` Arnd Bergmann
2021-09-27 20:42 ` Bjorn Andersson
2021-09-27 20:47 ` Arnd Bergmann
2021-09-28 7:03 ` Kalle Valo
2021-09-28 7:08 ` Arnd Bergmann
2021-09-29 9:51 ` Will Deacon
2021-09-29 10:04 ` Arnd Bergmann
2021-09-29 14:46 ` Bjorn Andersson [this message]
2021-09-29 18:30 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVR8Q7LO0weiFin+@yoga \
--to=bjorn.andersson@linaro$(echo .)org \
--cc=agross@kernel$(echo .)org \
--cc=airlied@linux$(echo .)ie \
--cc=arnd@arndb$(echo .)de \
--cc=arnd@kernel$(echo .)org \
--cc=ath10k@lists$(echo .)infradead.org \
--cc=daniel@ffwll$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=elder@kernel$(echo .)org \
--cc=freedreno@lists$(echo .)freedesktop.org \
--cc=iommu@lists$(echo .)linux-foundation.org \
--cc=jernej.skrabec@gmail$(echo .)com \
--cc=joro@8bytes$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=kvalo@codeaurora$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-gpio@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-mmc@vger$(echo .)kernel.org \
--cc=linux-sunxi@lists$(echo .)linux.dev \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=lorenzo.pieralisi@arm$(echo .)com \
--cc=mark.rutland@arm$(echo .)com \
--cc=mchehab@kernel$(echo .)org \
--cc=mripard@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=robdclark@gmail$(echo .)com \
--cc=sean@poorly$(echo .)run \
--cc=sudeep.holla@arm$(echo .)com \
--cc=ulf.hansson@linaro$(echo .)org \
--cc=wens@csie$(echo .)org \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox