From: Bjorn Andersson <bjorn.andersson@linaro•org>
To: Arnd Bergmann <arnd@kernel•org>
Cc: John Stultz <john.stultz@linaro•org>,
Arnd Bergmann <arnd@arndb•de>, Rob Clark <robdclark@gmail•com>,
Sean Paul <sean@poorly•run>, David Airlie <airlied@linux•ie>,
Daniel Vetter <daniel@ffwll•ch>, Joerg Roedel <joro@8bytes•org>,
Will Deacon <will@kernel•org>,
Mauro Carvalho Chehab <mchehab@kernel•org>,
Ulf Hansson <ulf.hansson@linaro•org>,
Alex Elder <elder@kernel•org>,
"David S. Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>,
Kalle Valo <kvalo@codeaurora•org>, Andy Gross <agross@kernel•org>,
Linus Walleij <linus.walleij@linaro•org>,
Maxime Ripard <mripard@kernel•org>, Chen-Yu Tsai <wens@csie•org>,
Jernej Skrabec <jernej.skrabec@gmail•com>,
Mark Rutland <mark.rutland@arm•com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm•com>,
Sudeep Holla <sudeep.holla@arm•com>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
linux-arm-msm <linux-arm-msm@vger•kernel.org>,
dri-devel <dri-devel@lists•freedesktop.org>,
freedreno <freedreno@lists•freedesktop.org>,
"open list:IOMMU DRIVERS" <iommu@lists•linux-foundation.org>,
Linux Media Mailing List <linux-media@vger•kernel.org>,
linux-mmc <linux-mmc@vger•kernel.org>,
Networking <netdev@vger•kernel.org>,
ath10k@lists•infradead.org,
linux-wireless <linux-wireless@vger•kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger•kernel.org>,
Linux ARM <linux-arm-kernel@lists•infradead.org>,
linux-sunxi@lists•linux.dev
Subject: Re: [PATCH] [RFC] qcom_scm: hide Kconfig symbol
Date: Mon, 27 Sep 2021 13:42:22 -0700 [thread overview]
Message-ID: <YVIsrgKiOG/gFVdT@ripper> (raw)
In-Reply-To: <CAK8P3a1fEuFsQVY9b1oGdTOHzr8pu9wvrSBCMn2iOvgWqtHNnA@mail.gmail.com>
On Mon 27 Sep 13:15 PDT 2021, Arnd Bergmann wrote:
> On Mon, Sep 27, 2021 at 9:52 PM Bjorn Andersson
> <bjorn.andersson@linaro•org> wrote:
> > On Mon 27 Sep 08:22 PDT 2021, Arnd Bergmann wrote:
> > > From: Arnd Bergmann <arnd@arndb•de>
> > >
> > > - To avoid a circular dependency chain involving RESET_CONTROLLER
> > > and PINCTRL_SUNXI, change the 'depends on RESET_CONTROLLER' in
> > > the latter one to 'select'.
> >
> > Can you please help me understand why this is part of the same patch?
>
> This can be done as a preparatory patch if we decide to do it this way,
> for the review it seemed better to spell out that this is required.
>
> I still hope that we can avoid adding another 'select RESET_CONTROLLER'
> if someone can figure out what to do instead.
>
Okay, thanks.
> The problem here is that QCOM_SCM selects RESET_CONTROLLER,
> and turning that into 'depends on' would in turn mean that any driver that
> wants to select QCOM_SCM would have to have the same RESET_CONTROLLER
> dependency.
>
Right, and that will just be another thing we'll get wrong across the
tree.
> An easier option might be to find a way to build QCOM_SCM without
> RESET_CONTROLLER for compile testing purposes. I don't know
> what would break from that.
>
Afaict the reset API is properly stubbed and RESET_CONTROLLER is a bool,
so I think we can simply drop the "select" and the kernel will still
compile fine in all combinations.
When it comes to runtime, we currently select RESET_CONTROLLER from the
Qualcomm common clocks. If that is dropped (why would it...) it seems
possible to build a custom kernel for msm8916 that we can boot and miss
the stubbed out "mss restart" reset line from the SCM.
So, let's just drop the select RESET_CONTROLLER from SCM for now.
Regards,
Bjorn
next prev parent reply other threads:[~2021-09-27 20:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 15:22 [PATCH] [RFC] qcom_scm: hide Kconfig symbol Arnd Bergmann
2021-09-27 19:52 ` Bjorn Andersson
2021-09-27 20:15 ` Arnd Bergmann
2021-09-27 20:42 ` Bjorn Andersson [this message]
2021-09-27 20:47 ` Arnd Bergmann
2021-09-28 7:03 ` Kalle Valo
2021-09-28 7:08 ` Arnd Bergmann
2021-09-29 9:51 ` Will Deacon
2021-09-29 10:04 ` Arnd Bergmann
2021-09-29 14:46 ` Bjorn Andersson
2021-09-29 18:30 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVIsrgKiOG/gFVdT@ripper \
--to=bjorn.andersson@linaro$(echo .)org \
--cc=agross@kernel$(echo .)org \
--cc=airlied@linux$(echo .)ie \
--cc=arnd@arndb$(echo .)de \
--cc=arnd@kernel$(echo .)org \
--cc=ath10k@lists$(echo .)infradead.org \
--cc=daniel@ffwll$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=elder@kernel$(echo .)org \
--cc=freedreno@lists$(echo .)freedesktop.org \
--cc=iommu@lists$(echo .)linux-foundation.org \
--cc=jernej.skrabec@gmail$(echo .)com \
--cc=john.stultz@linaro$(echo .)org \
--cc=joro@8bytes$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=kvalo@codeaurora$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-gpio@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-mmc@vger$(echo .)kernel.org \
--cc=linux-sunxi@lists$(echo .)linux.dev \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=lorenzo.pieralisi@arm$(echo .)com \
--cc=mark.rutland@arm$(echo .)com \
--cc=mchehab@kernel$(echo .)org \
--cc=mripard@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=robdclark@gmail$(echo .)com \
--cc=sean@poorly$(echo .)run \
--cc=sudeep.holla@arm$(echo .)com \
--cc=ulf.hansson@linaro$(echo .)org \
--cc=wens@csie$(echo .)org \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox