From: sdf@google•com
To: Lorenzo Bianconi <lorenzo@kernel•org>
Cc: bpf@vger•kernel.org, netdev@vger•kernel.org, ast@kernel•org,
daniel@iogearbox•net, andrii@kernel•org, davem@davemloft•net,
kuba@kernel•org, hawk@kernel•org, pabeni@redhat•com,
edumazet@google•com, toke@redhat•com, memxor@gmail•com,
alardam@gmail•com, saeedm@nvidia•com, anthony.l.nguyen@intel•com,
gospo@broadcom•com, vladimir.oltean@nxp•com, nbd@nbd•name,
john@phrozen•org, leon@kernel•org, simon.horman@corigine•com,
aelior@marvell•com, christophe.jaillet@wanadoo•fr,
ecree.xilinx@gmail•com, mst@redhat•com, bjorn@kernel•org,
magnus.karlsson@intel•com, maciej.fijalkowski@intel•com,
intel-wired-lan@lists•osuosl.org, lorenzo.bianconi@redhat•com,
martin.lau@linux•dev
Subject: Re: [PATCH v3 bpf-next 7/8] selftests/bpf: add test for bpf_xdp_query xdp-features support
Date: Thu, 26 Jan 2023 10:28:02 -0800 [thread overview]
Message-ID: <Y9LGMha3+jPLBXsb@google.com> (raw)
In-Reply-To: <7c403a3a043554df3ebe4b4a94b8e0d97414cb7e.1674737592.git.lorenzo@kernel.org>
On 01/26, Lorenzo Bianconi wrote:
> Introduce a self-test to verify libbpf bpf_xdp_query capability to dump
> the xdp-features supported by the device (lo and veth in this case).
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel•org>
Acked-by: Stanislav Fomichev <sdf@google•com>
> ---
> .../bpf/prog_tests/xdp_do_redirect.c | 27 ++++++++++++++++++-
> .../selftests/bpf/prog_tests/xdp_info.c | 8 ++++++
> 2 files changed, 34 insertions(+), 1 deletion(-)
> diff --git a/tools/testing/selftests/bpf/prog_tests/xdp_do_redirect.c
> b/tools/testing/selftests/bpf/prog_tests/xdp_do_redirect.c
> index a50971c6cf4a..e15fb3f0306c 100644
> --- a/tools/testing/selftests/bpf/prog_tests/xdp_do_redirect.c
> +++ b/tools/testing/selftests/bpf/prog_tests/xdp_do_redirect.c
> @@ -4,10 +4,12 @@
> #include <net/if.h>
> #include <linux/if_ether.h>
> #include <linux/if_packet.h>
> +#include <linux/if_link.h>
> #include <linux/ipv6.h>
> #include <linux/in6.h>
> #include <linux/udp.h>
> #include <bpf/bpf_endian.h>
> +#include <uapi/linux/netdev.h>
> #include "test_xdp_do_redirect.skel.h"
> #define SYS(fmt, ...) \
> @@ -92,7 +94,7 @@ void test_xdp_do_redirect(void)
> struct test_xdp_do_redirect *skel = NULL;
> struct nstoken *nstoken = NULL;
> struct bpf_link *link;
> -
> + LIBBPF_OPTS(bpf_xdp_query_opts, query_opts);
> struct xdp_md ctx_in = { .data = sizeof(__u32),
> .data_end = sizeof(data) };
> DECLARE_LIBBPF_OPTS(bpf_test_run_opts, opts,
> @@ -153,6 +155,29 @@ void test_xdp_do_redirect(void)
> !ASSERT_NEQ(ifindex_dst, 0, "ifindex_dst"))
> goto out;
> + /* Check xdp features supported by veth driver */
> + err = bpf_xdp_query(ifindex_src, XDP_FLAGS_DRV_MODE, &query_opts);
> + if (!ASSERT_OK(err, "veth_src bpf_xdp_query"))
> + goto out;
> +
> + if (!ASSERT_EQ(query_opts.fflags,
> + NETDEV_XDP_ACT_BASIC | NETDEV_XDP_ACT_REDIRECT |
> + NETDEV_XDP_ACT_NDO_XMIT | NETDEV_XDP_ACT_RX_SG |
> + NETDEV_XDP_ACT_NDO_XMIT_SG,
> + "veth_src query_opts.fflags"))
> + goto out;
> +
> + err = bpf_xdp_query(ifindex_dst, XDP_FLAGS_DRV_MODE, &query_opts);
> + if (!ASSERT_OK(err, "veth_dst bpf_xdp_query"))
> + goto out;
> +
> + if (!ASSERT_EQ(query_opts.fflags,
> + NETDEV_XDP_ACT_BASIC | NETDEV_XDP_ACT_REDIRECT |
> + NETDEV_XDP_ACT_NDO_XMIT | NETDEV_XDP_ACT_RX_SG |
> + NETDEV_XDP_ACT_NDO_XMIT_SG,
> + "veth_dst query_opts.fflags"))
> + goto out;
> +
> memcpy(skel->rodata->expect_dst, &pkt_udp.eth.h_dest, ETH_ALEN);
> skel->rodata->ifindex_out = ifindex_src; /* redirect back to the same
> iface */
> skel->rodata->ifindex_in = ifindex_src;
> diff --git a/tools/testing/selftests/bpf/prog_tests/xdp_info.c
> b/tools/testing/selftests/bpf/prog_tests/xdp_info.c
> index cd3aa340e65e..8397468a9e74 100644
> --- a/tools/testing/selftests/bpf/prog_tests/xdp_info.c
> +++ b/tools/testing/selftests/bpf/prog_tests/xdp_info.c
> @@ -8,6 +8,7 @@ void serial_test_xdp_info(void)
> {
> __u32 len = sizeof(struct bpf_prog_info), duration = 0, prog_id;
> const char *file = "./xdp_dummy.bpf.o";
> + LIBBPF_OPTS(bpf_xdp_query_opts, opts);
> struct bpf_prog_info info = {};
> struct bpf_object *obj;
> int err, prog_fd;
> @@ -61,6 +62,13 @@ void serial_test_xdp_info(void)
> if (CHECK(prog_id, "prog_id_drv", "unexpected prog_id=%u\n", prog_id))
> goto out;
> + /* Check xdp features supported by lo device */
> + opts.fflags = ~0;
> + err = bpf_xdp_query(IFINDEX_LO, XDP_FLAGS_DRV_MODE, &opts);
> + if (!ASSERT_OK(err, "bpf_xdp_query"))
> + goto out;
> +
> + ASSERT_EQ(opts.fflags, 0, "opts.fflags");
> out:
> bpf_xdp_detach(IFINDEX_LO, 0, NULL);
> out_close:
> --
> 2.39.1
next prev parent reply other threads:[~2023-01-26 18:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 12:58 [PATCH v3 bpf-next 0/8] xdp: introduce xdp-feature support Lorenzo Bianconi
2023-01-26 12:58 ` [PATCH v3 bpf-next 1/8] netdev-genl: create a simple family for netdev stuff Lorenzo Bianconi
2023-01-26 12:58 ` [PATCH v3 bpf-next 2/8] drivers: net: turn on XDP features Lorenzo Bianconi
2023-01-26 18:27 ` sdf
2023-01-26 12:58 ` [PATCH v3 bpf-next 3/8] xsk: add usage of XDP features flags Lorenzo Bianconi
2023-01-26 12:58 ` [PATCH v3 bpf-next 4/8] libbpf: add the capability to specify netlink proto in libbpf_netlink_send_recv Lorenzo Bianconi
2023-01-26 12:58 ` [PATCH v3 bpf-next 5/8] libbpf: add API to get XDP/XSK supported features Lorenzo Bianconi
2023-01-27 23:38 ` Andrii Nakryiko
2023-01-28 12:48 ` Lorenzo Bianconi
2023-01-26 12:58 ` [PATCH v3 bpf-next 6/8] bpf: devmap: check XDP features in __xdp_enqueue routine Lorenzo Bianconi
2023-01-26 12:58 ` [PATCH v3 bpf-next 7/8] selftests/bpf: add test for bpf_xdp_query xdp-features support Lorenzo Bianconi
2023-01-26 18:28 ` sdf [this message]
2023-01-26 12:58 ` [PATCH v3 bpf-next 8/8] selftests/bpf: introduce XDP compliance test tool Lorenzo Bianconi
2023-01-26 18:36 ` sdf
2023-01-27 8:19 ` Martin KaFai Lau
2023-01-27 17:26 ` Lorenzo Bianconi
2023-01-27 17:26 ` Lorenzo Bianconi
2023-01-27 17:41 ` Stanislav Fomichev
2023-01-27 17:52 ` Toke Høiland-Jørgensen
2023-01-27 17:58 ` Lorenzo Bianconi
2023-01-27 17:59 ` Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9LGMha3+jPLBXsb@google.com \
--to=sdf@google$(echo .)com \
--cc=aelior@marvell$(echo .)com \
--cc=alardam@gmail$(echo .)com \
--cc=andrii@kernel$(echo .)org \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=bjorn@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=christophe.jaillet@wanadoo$(echo .)fr \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=ecree.xilinx@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=gospo@broadcom$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=john@phrozen$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=lorenzo.bianconi@redhat$(echo .)com \
--cc=lorenzo@kernel$(echo .)org \
--cc=maciej.fijalkowski@intel$(echo .)com \
--cc=magnus.karlsson@intel$(echo .)com \
--cc=martin.lau@linux$(echo .)dev \
--cc=memxor@gmail$(echo .)com \
--cc=mst@redhat$(echo .)com \
--cc=nbd@nbd$(echo .)name \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=simon.horman@corigine$(echo .)com \
--cc=toke@redhat$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox