From: Lorenzo Bianconi <lorenzo@kernel•org>
To: "Toke Høiland-Jørgensen" <toke@redhat•com>
Cc: Stanislav Fomichev <sdf@google•com>,
bpf@vger•kernel.org, netdev@vger•kernel.org, ast@kernel•org,
daniel@iogearbox•net, andrii@kernel•org, davem@davemloft•net,
kuba@kernel•org, hawk@kernel•org, pabeni@redhat•com,
edumazet@google•com, memxor@gmail•com, alardam@gmail•com,
saeedm@nvidia•com, anthony.l.nguyen@intel•com,
gospo@broadcom•com, vladimir.oltean@nxp•com, nbd@nbd•name,
john@phrozen•org, leon@kernel•org, simon.horman@corigine•com,
aelior@marvell•com, christophe.jaillet@wanadoo•fr,
ecree.xilinx@gmail•com, mst@redhat•com, bjorn@kernel•org,
magnus.karlsson@intel•com, maciej.fijalkowski@intel•com,
intel-wired-lan@lists•osuosl.org, lorenzo.bianconi@redhat•com,
martin.lau@linux•dev
Subject: Re: [PATCH v3 bpf-next 8/8] selftests/bpf: introduce XDP compliance test tool
Date: Fri, 27 Jan 2023 18:58:28 +0100 [thread overview]
Message-ID: <Y9QQxMIVd+1chwm3@lore-desk> (raw)
In-Reply-To: <874jsblv9h.fsf@toke.dk>
[-- Attachment #1: Type: text/plain, Size: 1895 bytes --]
On Jan 27, Toke wrote:
> Stanislav Fomichev <sdf@google•com> writes:
>
> >> > > +
> >> > > + ctrl_sockfd = accept(sockfd, (struct sockaddr *)&ctrl_addr, &len);
> >> > > + if (ctrl_sockfd < 0) {
> >> > > + fprintf(stderr, "Failed to accept connection on DUT socket\n");
> >> > > + close(sockfd);
> >> > > + return -errno;
> >> > > + }
> >> > > +
> >>
> >> [...]
> >>
> >> >
> >> > There is also connect_to_fd, maybe we can use that? It should take
> >> > care of the timeouts.. (requires plumbing server_fd, not sure whether
> >> > it's a problem or not)
> >>
> >> please correct me if I am wrong, but in order to have server_fd it is mandatory
> >> both tester and DUT are running on the same process, right? Here, I guess 99% of
> >> the times DUT and tester will run on two separated devices. Agree?
> >
> > Yes, it's targeting more the case where you have a server fd and a
> > bunch of clients in the same process. But I think it's still usable in
> > your case, you're not using fork() anywhere afaict, so even if these
> > are separate devices, connect_to_fd should still work. (unless I'm
> > missing something, haven't looked too closely)
>
> Just to add a bit of context here, "separate devices" can refer to the
> hosts as well as the netdevs. I.e., it should also be possible to run
> this in a mode where the client bit runs on a different physical machine
> than the server bit (as it will not be feasible in any case to connect
> things with loopback cables).
yes, this is what I meant with 'DUT and tester will run on two separated
devices' (sorry to have not been so clear). Looking at the code server_fd
is always obtained from start_server(), while here the client on the tester
just knows the IPv4/IPv6 address and the port of the server running on the DUT.
Regards,
Lorenzo
>
> -Toke
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-01-27 17:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 12:58 [PATCH v3 bpf-next 0/8] xdp: introduce xdp-feature support Lorenzo Bianconi
2023-01-26 12:58 ` [PATCH v3 bpf-next 1/8] netdev-genl: create a simple family for netdev stuff Lorenzo Bianconi
2023-01-26 12:58 ` [PATCH v3 bpf-next 2/8] drivers: net: turn on XDP features Lorenzo Bianconi
2023-01-26 18:27 ` sdf
2023-01-26 12:58 ` [PATCH v3 bpf-next 3/8] xsk: add usage of XDP features flags Lorenzo Bianconi
2023-01-26 12:58 ` [PATCH v3 bpf-next 4/8] libbpf: add the capability to specify netlink proto in libbpf_netlink_send_recv Lorenzo Bianconi
2023-01-26 12:58 ` [PATCH v3 bpf-next 5/8] libbpf: add API to get XDP/XSK supported features Lorenzo Bianconi
2023-01-27 23:38 ` Andrii Nakryiko
2023-01-28 12:48 ` Lorenzo Bianconi
2023-01-26 12:58 ` [PATCH v3 bpf-next 6/8] bpf: devmap: check XDP features in __xdp_enqueue routine Lorenzo Bianconi
2023-01-26 12:58 ` [PATCH v3 bpf-next 7/8] selftests/bpf: add test for bpf_xdp_query xdp-features support Lorenzo Bianconi
2023-01-26 18:28 ` sdf
2023-01-26 12:58 ` [PATCH v3 bpf-next 8/8] selftests/bpf: introduce XDP compliance test tool Lorenzo Bianconi
2023-01-26 18:36 ` sdf
2023-01-27 8:19 ` Martin KaFai Lau
2023-01-27 17:26 ` Lorenzo Bianconi
2023-01-27 17:26 ` Lorenzo Bianconi
2023-01-27 17:41 ` Stanislav Fomichev
2023-01-27 17:52 ` Toke Høiland-Jørgensen
2023-01-27 17:58 ` Lorenzo Bianconi [this message]
2023-01-27 17:59 ` Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9QQxMIVd+1chwm3@lore-desk \
--to=lorenzo@kernel$(echo .)org \
--cc=aelior@marvell$(echo .)com \
--cc=alardam@gmail$(echo .)com \
--cc=andrii@kernel$(echo .)org \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=bjorn@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=christophe.jaillet@wanadoo$(echo .)fr \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=ecree.xilinx@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=gospo@broadcom$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=john@phrozen$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=lorenzo.bianconi@redhat$(echo .)com \
--cc=maciej.fijalkowski@intel$(echo .)com \
--cc=magnus.karlsson@intel$(echo .)com \
--cc=martin.lau@linux$(echo .)dev \
--cc=memxor@gmail$(echo .)com \
--cc=mst@redhat$(echo .)com \
--cc=nbd@nbd$(echo .)name \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=sdf@google$(echo .)com \
--cc=simon.horman@corigine$(echo .)com \
--cc=toke@redhat$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox