From: Martin Habets <habetsm.xilinx@gmail•com>
To: edward.cree@amd•com
Cc: linux-net-drivers@amd•com, davem@davemloft•net,
pabeni@redhat•com, edumazet@google•com,
Edward Cree <ecree.xilinx@gmail•com>,
netdev@vger•kernel.org, michal.swiatkowski@linux•intel.com,
Jakub Kicinski <kuba@kernel•org>
Subject: Re: [PATCH net-next v2 5/6] sfc: add code to register and unregister encap matches
Date: Fri, 24 Mar 2023 09:10:41 +0000 [thread overview]
Message-ID: <ZB1pEVNGn1fKTGDG@gmail.com> (raw)
In-Reply-To: <20230323220530.0d979b62@kernel.org>
On Thu, Mar 23, 2023 at 10:05:30PM -0700, Jakub Kicinski wrote:
> On Thu, 23 Mar 2023 20:45:13 +0000 edward.cree@amd•com wrote:
> > +__always_unused
> > +static int efx_tc_flower_record_encap_match(struct efx_nic *efx,
> > + struct efx_tc_match *match,
> > + enum efx_encap_type type,
> > + struct netlink_ext_ack *extack)
> > +{
> > + struct efx_tc_encap_match *encap, *old;
> > + bool ipv6;
> > + int rc;
>
> clang sayeth
>
> drivers/net/ethernet/sfc/tc.c:414:43: warning: variable 'ipv6' is uninitialized when used here [-Wuninitialized]
> rc = efx_mae_check_encap_match_caps(efx, ipv6, extack);
> ^~~~
> drivers/net/ethernet/sfc/tc.c:356:11: note: initialize the variable 'ipv6' to silence this warning
> bool ipv6;
> ^
> = 0
If CONFIG_IPV6 is unset it is never used, to is needs a __maybe_unused
as well.
Martin
next prev parent reply other threads:[~2023-03-24 9:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 20:45 [PATCH net-next v2 0/6] sfc: support TC decap rules edward.cree
2023-03-23 20:45 ` [PATCH net-next v2 1/6] sfc: document TC-to-EF100-MAE action translation concepts edward.cree
2023-03-25 12:05 ` Simon Horman
2023-03-23 20:45 ` [PATCH net-next v2 2/6] sfc: add notion of match on enc keys to MAE machinery edward.cree
2023-03-25 12:03 ` Simon Horman
2023-03-27 8:20 ` Edward Cree
2023-03-27 8:47 ` Simon Horman
2023-03-23 20:45 ` [PATCH net-next v2 3/6] sfc: handle enc keys in efx_tc_flower_parse_match() edward.cree
2023-03-25 12:07 ` Simon Horman
2023-03-23 20:45 ` [PATCH net-next v2 4/6] sfc: add functions to insert encap matches into the MAE edward.cree
2023-03-25 12:04 ` Simon Horman
2023-03-27 8:28 ` Edward Cree
2023-03-27 8:48 ` Simon Horman
2023-03-23 20:45 ` [PATCH net-next v2 5/6] sfc: add code to register and unregister encap matches edward.cree
2023-03-24 5:05 ` Jakub Kicinski
2023-03-24 9:10 ` Martin Habets [this message]
2023-03-24 18:37 ` Edward Cree
2023-03-24 17:16 ` kernel test robot
2023-03-26 9:18 ` Simon Horman
2023-03-23 20:45 ` [PATCH net-next v2 6/6] sfc: add offloading of 'foreign' TC (decap) rules edward.cree
2023-03-26 9:15 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZB1pEVNGn1fKTGDG@gmail.com \
--to=habetsm.xilinx@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ecree.xilinx@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=edward.cree@amd$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-net-drivers@amd$(echo .)com \
--cc=michal.swiatkowski@linux$(echo .)intel.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox