From: Simon Horman <simon.horman@corigine•com>
To: Edward Cree <ecree.xilinx@gmail•com>
Cc: edward.cree@amd•com, linux-net-drivers@amd•com,
davem@davemloft•net, kuba@kernel•org, pabeni@redhat•com,
edumazet@google•com, netdev@vger•kernel.org,
habetsm.xilinx@gmail•com, michal.swiatkowski@linux•intel.com
Subject: Re: [PATCH net-next v2 4/6] sfc: add functions to insert encap matches into the MAE
Date: Mon, 27 Mar 2023 10:48:10 +0200 [thread overview]
Message-ID: <ZCFYSpw5mOj2pJIB@corigine.com> (raw)
In-Reply-To: <66d1c67b-ecda-69a5-a8be-feddeee4a5d0@gmail.com>
On Mon, Mar 27, 2023 at 09:28:57AM +0100, Edward Cree wrote:
> On 25/03/2023 12:04, Simon Horman wrote:
> > On Thu, Mar 23, 2023 at 08:45:12PM +0000, edward.cree@amd•com wrote:
> >> diff --git a/drivers/net/ethernet/sfc/tc.h b/drivers/net/ethernet/sfc/tc.h
> >> index c1485679507c..19782c9a4354 100644
> >> --- a/drivers/net/ethernet/sfc/tc.h
> >> +++ b/drivers/net/ethernet/sfc/tc.h
> >> @@ -70,6 +70,7 @@ struct efx_tc_encap_match {
> >> __be32 src_ip, dst_ip;
> >> struct in6_addr src_ip6, dst_ip6;
> >> __be16 udp_dport;
> >> + u16 tun_type; /* enum efx_encap_type */
> >
> > nit: maybe the type of tyn_type can be enum efx_encap_type.
>
> Yeah, it probably should. Looking at my git history I think the
> initial reason was for struct-packing reasons (enums are int-sized
> at minimum, which is excessive for a field whose largest value is
> 3), but with the rhash_head that later appears between these two
> fields, using the narrower type doesn't actually avoid a 16-bit
> hole like it appears to here.
> Will change in v3.
Thanks.
next prev parent reply other threads:[~2023-03-27 8:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 20:45 [PATCH net-next v2 0/6] sfc: support TC decap rules edward.cree
2023-03-23 20:45 ` [PATCH net-next v2 1/6] sfc: document TC-to-EF100-MAE action translation concepts edward.cree
2023-03-25 12:05 ` Simon Horman
2023-03-23 20:45 ` [PATCH net-next v2 2/6] sfc: add notion of match on enc keys to MAE machinery edward.cree
2023-03-25 12:03 ` Simon Horman
2023-03-27 8:20 ` Edward Cree
2023-03-27 8:47 ` Simon Horman
2023-03-23 20:45 ` [PATCH net-next v2 3/6] sfc: handle enc keys in efx_tc_flower_parse_match() edward.cree
2023-03-25 12:07 ` Simon Horman
2023-03-23 20:45 ` [PATCH net-next v2 4/6] sfc: add functions to insert encap matches into the MAE edward.cree
2023-03-25 12:04 ` Simon Horman
2023-03-27 8:28 ` Edward Cree
2023-03-27 8:48 ` Simon Horman [this message]
2023-03-23 20:45 ` [PATCH net-next v2 5/6] sfc: add code to register and unregister encap matches edward.cree
2023-03-24 5:05 ` Jakub Kicinski
2023-03-24 9:10 ` Martin Habets
2023-03-24 18:37 ` Edward Cree
2023-03-24 17:16 ` kernel test robot
2023-03-26 9:18 ` Simon Horman
2023-03-23 20:45 ` [PATCH net-next v2 6/6] sfc: add offloading of 'foreign' TC (decap) rules edward.cree
2023-03-26 9:15 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCFYSpw5mOj2pJIB@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ecree.xilinx@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=edward.cree@amd$(echo .)com \
--cc=habetsm.xilinx@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-net-drivers@amd$(echo .)com \
--cc=michal.swiatkowski@linux$(echo .)intel.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox