From: Simon Horman <simon.horman@corigine•com>
To: Edward Cree <ecree.xilinx@gmail•com>
Cc: edward.cree@amd•com, linux-net-drivers@amd•com,
davem@davemloft•net, kuba@kernel•org, pabeni@redhat•com,
edumazet@google•com, netdev@vger•kernel.org,
habetsm.xilinx@gmail•com, michal.swiatkowski@linux•intel.com
Subject: Re: [PATCH net-next v2 2/6] sfc: add notion of match on enc keys to MAE machinery
Date: Mon, 27 Mar 2023 10:47:01 +0200 [thread overview]
Message-ID: <ZCFYBQBJbVSRmWNc@corigine.com> (raw)
In-Reply-To: <eeeda5b1-cd18-18ba-6018-a0772baf9948@gmail.com>
On Mon, Mar 27, 2023 at 09:20:06AM +0100, Edward Cree wrote:
> On 25/03/2023 12:03, Simon Horman wrote:
> > Hi Edward,
> >
> > Looks good to me.
> > A few minor comments inline.
> >
> > On Thu, Mar 23, 2023 at 08:45:10PM +0000, edward.cree@amd•com wrote:
> >> From: Edward Cree <ecree.xilinx@gmail•com>
> >>
> >> Extend the MAE caps check to validate that the hardware supports used
> >> outer-header matches.
> >
> > s/used// ?
>
> I think I meant it in the sense of "the outer-header matches which
> are used by the driver"; I can definitely reword it to spell that
> out better.
Thanks, I did have a bit of trouble parsing the text.
> >> int efx_mae_allocate_counter(struct efx_nic *efx, struct efx_tc_counter *cnt)
> >> {
> >> MCDI_DECLARE_BUF(outbuf, MC_CMD_MAE_COUNTER_ALLOC_OUT_LEN(1));
> >> @@ -941,6 +1011,29 @@ static int efx_mae_populate_match_criteria(MCDI_DECLARE_STRUCT_PTR(match_crit),
> >> match->value.tcp_flags);
> >> MCDI_STRUCT_SET_WORD_BE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_TCP_FLAGS_BE_MASK,
> >> match->mask.tcp_flags);
> >> + /* enc-keys are handled indirectly, through encap_match ID */
> >> + if (match->encap) {
> >> + MCDI_STRUCT_SET_DWORD(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_OUTER_RULE_ID,
> >> + match->encap->fw_id);
> >> + MCDI_STRUCT_SET_DWORD(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_OUTER_RULE_ID_MASK,
> >> + U32_MAX);
> >> + /* enc_keyid (VNI/VSID) is not part of the encap_match */
> >> + MCDI_STRUCT_SET_DWORD_BE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_ENC_VNET_ID_BE,
> >> + match->value.enc_keyid);
> >> + MCDI_STRUCT_SET_DWORD_BE(match_crit, MAE_FIELD_MASK_VALUE_PAIRS_V2_ENC_VNET_ID_BE_MASK,
> >> + match->mask.enc_keyid);
> >
> > Is it intentional that value.enc_keyid is used as the mask.
>
> But it isn't. mask.enc_keyid is.
Indeed it is :)
next prev parent reply other threads:[~2023-03-27 8:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 20:45 [PATCH net-next v2 0/6] sfc: support TC decap rules edward.cree
2023-03-23 20:45 ` [PATCH net-next v2 1/6] sfc: document TC-to-EF100-MAE action translation concepts edward.cree
2023-03-25 12:05 ` Simon Horman
2023-03-23 20:45 ` [PATCH net-next v2 2/6] sfc: add notion of match on enc keys to MAE machinery edward.cree
2023-03-25 12:03 ` Simon Horman
2023-03-27 8:20 ` Edward Cree
2023-03-27 8:47 ` Simon Horman [this message]
2023-03-23 20:45 ` [PATCH net-next v2 3/6] sfc: handle enc keys in efx_tc_flower_parse_match() edward.cree
2023-03-25 12:07 ` Simon Horman
2023-03-23 20:45 ` [PATCH net-next v2 4/6] sfc: add functions to insert encap matches into the MAE edward.cree
2023-03-25 12:04 ` Simon Horman
2023-03-27 8:28 ` Edward Cree
2023-03-27 8:48 ` Simon Horman
2023-03-23 20:45 ` [PATCH net-next v2 5/6] sfc: add code to register and unregister encap matches edward.cree
2023-03-24 5:05 ` Jakub Kicinski
2023-03-24 9:10 ` Martin Habets
2023-03-24 18:37 ` Edward Cree
2023-03-24 17:16 ` kernel test robot
2023-03-26 9:18 ` Simon Horman
2023-03-23 20:45 ` [PATCH net-next v2 6/6] sfc: add offloading of 'foreign' TC (decap) rules edward.cree
2023-03-26 9:15 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCFYBQBJbVSRmWNc@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ecree.xilinx@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=edward.cree@amd$(echo .)com \
--cc=habetsm.xilinx@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-net-drivers@amd$(echo .)com \
--cc=michal.swiatkowski@linux$(echo .)intel.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox