* [trivial PATCH 00/15] remove duplicate unlikely from IS_ERR
[not found] <1291906801-1389-2-git-send-email-tklauser@distanz.ch>
@ 2010-12-09 20:03 ` Joe Perches
2010-12-09 20:03 ` [PATCH 02/15] stmmac: Remove " Joe Perches
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Joe Perches @ 2010-12-09 20:03 UTC (permalink / raw)
To: netdev, uclinux-dist-devel, rtc-linux, linux-s390, osd-dev,
linux-arm-msm, linux-
Cc: Jiri Kosina, dri-devel, linux-kernel, linux-scsi, linux-wireless,
devel
Tobias Klauser <tklauser@distanz•ch> sent a patch to remove
an unnecessary unlikely from drivers/misc/c2port/core.c,
https://lkml.org/lkml/2010/12/9/199
Here are the other instances treewide.
I think it'd be good if people would, when noticing defects in a
specific subsystem, look for and correct the same defect treewide.
IS_ERR already has an unlikely test so remove unnecessary
unlikelys from the call sites.
from: include/linux/err.h
#define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO)
[...]
static inline long __must_check IS_ERR(const void *ptr)
{
return IS_ERR_VALUE((unsigned long)ptr);
}
Sending directly to maintainers for now, will resend in a month
or so only to trivial if not picked up.
Joe Perches (15):
drm: Remove duplicate unlikely from IS_ERR
stmmac: Remove duplicate unlikely from IS_ERR
rtc: Remove duplicate unlikely from IS_ERR
s390: Remove duplicate unlikely from IS_ERR
osd: Remove duplicate unlikely from IS_ERR
serial: Remove duplicate unlikely from IS_ERR
brcm80211: Remove duplicate unlikely from IS_ERR
gadget: Remove duplicate unlikely from IS_ERR
exofs: Remove duplicate unlikely from IS_ERR
ext2: Remove duplicate unlikely from IS_ERR
ext3: Remove duplicate unlikely from IS_ERR
ext4: Remove duplicate unlikely from IS_ERR
nfs: Remove duplicate unlikely from IS_ERR
mm: Remove duplicate unlikely from IS_ERR
ipv6: Remove duplicate unlikely from IS_ERR
drivers/gpu/drm/ttm/ttm_tt.c | 4 ++--
drivers/net/stmmac/stmmac_main.c | 2 +-
drivers/rtc/rtc-bfin.c | 2 +-
drivers/s390/scsi/zfcp_fsf.c | 4 ++--
drivers/scsi/osd/osd_initiator.c | 2 +-
drivers/serial/msm_serial.c | 2 +-
drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c | 2 +-
drivers/usb/gadget/f_fs.c | 4 ++--
fs/exofs/super.c | 2 +-
fs/ext2/namei.c | 2 +-
fs/ext3/namei.c | 2 +-
fs/ext4/namei.c | 2 +-
fs/nfs/mount_clnt.c | 2 +-
mm/vmalloc.c | 2 +-
net/ipv6/af_inet6.c | 2 +-
15 files changed, 18 insertions(+), 18 deletions(-)
--
1.7.3.3.464.gf80b6
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack•org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack•org"> email@kvack•org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 02/15] stmmac: Remove duplicate unlikely from IS_ERR
2010-12-09 20:03 ` [trivial PATCH 00/15] remove duplicate unlikely from IS_ERR Joe Perches
@ 2010-12-09 20:03 ` Joe Perches
2010-12-09 20:04 ` [PATCH 15/15] ipv6: " Joe Perches
2010-12-09 20:32 ` [trivial PATCH 00/15] remove " Joe Perches
2 siblings, 0 replies; 4+ messages in thread
From: Joe Perches @ 2010-12-09 20:03 UTC (permalink / raw)
To: Giuseppe Cavallaro; +Cc: Jiri Kosina, netdev, linux-kernel
IS_ERR already uses unlikely, remove unlikely from the call sites.
Signed-off-by: Joe Perches <joe@perches•com>
---
drivers/net/stmmac/stmmac_main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/stmmac/stmmac_main.c b/drivers/net/stmmac/stmmac_main.c
index c0dc785..20f803d 100644
--- a/drivers/net/stmmac/stmmac_main.c
+++ b/drivers/net/stmmac/stmmac_main.c
@@ -949,7 +949,7 @@ static int stmmac_sw_tso(struct stmmac_priv *priv, struct sk_buff *skb)
skb, skb->len);
segs = skb_gso_segment(skb, priv->dev->features & ~NETIF_F_TSO);
- if (unlikely(IS_ERR(segs)))
+ if (IS_ERR(segs))
goto sw_tso_end;
do {
--
1.7.3.3.464.gf80b6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 15/15] ipv6: Remove duplicate unlikely from IS_ERR
2010-12-09 20:03 ` [trivial PATCH 00/15] remove duplicate unlikely from IS_ERR Joe Perches
2010-12-09 20:03 ` [PATCH 02/15] stmmac: Remove " Joe Perches
@ 2010-12-09 20:04 ` Joe Perches
2010-12-09 20:32 ` [trivial PATCH 00/15] remove " Joe Perches
2 siblings, 0 replies; 4+ messages in thread
From: Joe Perches @ 2010-12-09 20:04 UTC (permalink / raw)
To: David S. Miller, Alexey Kuznetsov, Pekka Savola (ipv6),
James Morris, Hideaki YOSHIFUJI <yosh
Cc: Jiri Kosina, netdev, linux-kernel
IS_ERR already uses unlikely, remove unlikely from the call sites.
Signed-off-by: Joe Perches <joe@perches•com>
---
net/ipv6/af_inet6.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c
index 54e8e42..059a3de 100644
--- a/net/ipv6/af_inet6.c
+++ b/net/ipv6/af_inet6.c
@@ -810,7 +810,7 @@ static struct sk_buff *ipv6_gso_segment(struct sk_buff *skb, int features)
}
rcu_read_unlock();
- if (unlikely(IS_ERR(segs)))
+ if (IS_ERR(segs))
goto out;
for (skb = segs; skb; skb = skb->next) {
--
1.7.3.3.464.gf80b6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [trivial PATCH 00/15] remove duplicate unlikely from IS_ERR
2010-12-09 20:03 ` [trivial PATCH 00/15] remove duplicate unlikely from IS_ERR Joe Perches
2010-12-09 20:03 ` [PATCH 02/15] stmmac: Remove " Joe Perches
2010-12-09 20:04 ` [PATCH 15/15] ipv6: " Joe Perches
@ 2010-12-09 20:32 ` Joe Perches
2 siblings, 0 replies; 4+ messages in thread
From: Joe Perches @ 2010-12-09 20:32 UTC (permalink / raw)
To: netdev, Tobias Klauser
Cc: uclinux-dist-devel, rtc-linux, linux-s390, osd-dev, linux-arm-msm,
linux-usb, linux-ext4, linux-nfs, linux-mm, Jiri Kosina,
dri-devel, linux-kernel, linux-scsi, linux-wireless, devel
On Thu, 2010-12-09 at 12:03 -0800, Joe Perches wrote:
> Tobias Klauser <tklauser@distanz•ch> sent a patch to remove
> an unnecessary unlikely from drivers/misc/c2port/core.c,
> https://lkml.org/lkml/2010/12/9/199
It seems that Tobias did send all the appropriate patches,
not as a series, but as individual patches to kernel-janitor.
c2port was the only one that went to lkml.
Please ignore this series and apply Tobias' patches.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack•org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack•org"> email@kvack•org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-12-09 20:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1291906801-1389-2-git-send-email-tklauser@distanz.ch>
2010-12-09 20:03 ` [trivial PATCH 00/15] remove duplicate unlikely from IS_ERR Joe Perches
2010-12-09 20:03 ` [PATCH 02/15] stmmac: Remove " Joe Perches
2010-12-09 20:04 ` [PATCH 15/15] ipv6: " Joe Perches
2010-12-09 20:32 ` [trivial PATCH 00/15] remove " Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox