* [PATCH] Test failure when spaces in git root
@ 2011-03-24 0:11 Carl Michael Skog
2011-03-24 20:46 ` Thomas Rast
0 siblings, 1 reply; 2+ messages in thread
From: Carl Michael Skog @ 2011-03-24 0:11 UTC (permalink / raw)
To: git; +Cc: Thomas Rast, Carl Michael Skog
Some of the svn related tests would break when the git root path had
spaces in it.
The test checks in t/t9119-git-svn-info.sh where falsely assuming that
the only space where in the path of the generated subversion repository.
This will break when the actual git build repository has spaces in it.
Add a global modifier to the sed command that generates the expected
value for the tests.
Signed-off-by: Carl Michael Skog <cmskog@gmail•com>
---
t/t9119-git-svn-info.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/t/t9119-git-svn-info.sh b/t/t9119-git-svn-info.sh
index ff19695..752bf26 100755
--- a/t/t9119-git-svn-info.sh
+++ b/t/t9119-git-svn-info.sh
@@ -28,7 +28,7 @@ test_cmp_info () {
rm -f tmp.expect tmp.actual
}
-quoted_svnrepo="$(echo $svnrepo | sed 's/ /%20/')"
+quoted_svnrepo="$(echo $svnrepo | sed 's/ /%20/g')"
test_expect_success 'setup repository and import' '
mkdir info &&
--
1.7.4.1.99.g3d9132
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Test failure when spaces in git root
2011-03-24 0:11 [PATCH] Test failure when spaces in git root Carl Michael Skog
@ 2011-03-24 20:46 ` Thomas Rast
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Rast @ 2011-03-24 20:46 UTC (permalink / raw)
To: Carl Michael Skog; +Cc: git
Carl Michael Skog wrote:
> Some of the svn related tests would break when the git root path had
> spaces in it.
[...]
> -quoted_svnrepo="$(echo $svnrepo | sed 's/ /%20/')"
> +quoted_svnrepo="$(echo $svnrepo | sed 's/ /%20/g')"
If you're already fixing this, shouldn't it be
$(echo "$svnrepo" | ...)
to stop the expansion process from converting arbitrary series of
whitespace into a single space?
However, any other (than space) character that needs %-quoting would
probably also break the test. Maybe some more complicated mangling
would be in order.
--
Thomas Rast
trast@{inf,student}.ethz.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-24 20:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-24 0:11 [PATCH] Test failure when spaces in git root Carl Michael Skog
2011-03-24 20:46 ` Thomas Rast
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox