From: David Kastrup <dak@gnu•org>
To: Matthieu Moy <Matthieu.Moy@imag•fr>
Cc: git@vger•kernel.org, gitster@pobox•com, d9ba@mailtor•net,
jrnieder@gmail•com
Subject: Re: [PATCH] PAGER_ENV: remove 'S' from $LESS by default
Date: Mon, 28 Apr 2014 10:43:57 +0200 [thread overview]
Message-ID: <87vbtt6dyq.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <1398674062-24288-1-git-send-email-Matthieu.Moy@imag.fr> (Matthieu Moy's message of "Mon, 28 Apr 2014 10:34:22 +0200")
Matthieu Moy <Matthieu.Moy@imag•fr> writes:
> By default, Git used to set $LESS to -FRSX if $LESS was not set by the
> user. The FRX flags actually make sense for Git (F and X because Git
> sometimes pipes short output to less, and R because Git pipes colored
> output). The S flag (chop long lines), on the other hand, is not related
> to Git and is a matter of user preference. Git should not decide for the
> user to change LESS's default.
>> We agree here. So, does someone who actually wants this change want to
>> propose a patch? :)
>
> Here you are.
>
> Documentation/config.txt | 13 ++++++++-----
> Makefile | 6 +++---
> perl/Git/SVN/Log.pm | 2 +-
> 3 files changed, 12 insertions(+), 9 deletions(-)
There seem to be a few more occurences (git-sh-setup.sh and pager.c):
$ git grep FRSX
Documentation/RelNotes/1.6.5.txt: * mingw will also give FRSX as the default val
Documentation/config.txt:When the `LESS` environment variable is unset, Git sets
Documentation/config.txt:command to `LESS=FRSX less -+S`. The environment tells
git-sh-setup.sh: : ${LESS=-FRSX}
pager.c: env[i++] = "LESS=FRSX";
perl/Git/SVN/Log.pm: $ENV{LESS} ||= 'FRSX';
Searching for LESS seems to implicate a few more possible candidates in
contrib/examples:
contrib/examples/git-log.sh:LESS=-S ${PAGER:-less}
contrib/examples/git-whatchanged.sh:LESS="$LESS -S" ${PAGER:-less}
--
David Kastrup
next prev parent reply other threads:[~2014-04-28 8:44 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 23:46 Harmful LESS flags d9ba
2014-04-24 0:11 ` Jonathan Nieder
2014-04-28 21:38 ` Mark Nudelman
2014-04-24 5:06 ` David Kastrup
2014-04-24 19:02 ` Junio C Hamano
2014-04-24 19:21 ` David Kastrup
2014-04-24 19:29 ` Junio C Hamano
2014-04-24 19:50 ` David Kastrup
2014-04-24 21:35 ` Jeff King
2014-04-24 21:47 ` Junio C Hamano
2014-04-24 22:02 ` Jeff King
2014-04-24 21:48 ` David Kastrup
2014-04-24 22:13 ` Jeff King
2014-04-24 22:44 ` David Kastrup
2014-04-24 23:08 ` Jonathan Nieder
2014-04-25 6:56 ` Matthieu Moy
2014-04-25 15:11 ` Jonathan Nieder
2014-04-25 15:32 ` David Kastrup
2014-04-25 15:47 ` Jonathan Nieder
2014-04-28 8:34 ` [PATCH] PAGER_ENV: remove 'S' from $LESS by default Matthieu Moy
2014-04-28 8:43 ` David Kastrup [this message]
2014-04-28 8:59 ` Matthieu Moy
2014-04-28 9:14 ` David Kastrup
2014-04-28 12:22 ` Matthieu Moy
2014-04-28 16:24 ` Jeff King
2014-04-28 18:48 ` Junio C Hamano
2014-04-29 12:29 ` Matthieu Moy
2014-04-29 17:01 ` Junio C Hamano
2014-04-30 7:35 ` [PATCH v2] pager: " Matthieu Moy
2014-04-30 15:38 ` Junio C Hamano
2014-04-30 15:49 ` Matthieu Moy
2014-04-30 17:34 ` Junio C Hamano
2014-05-05 18:44 ` Jonathan Nieder
2014-05-05 20:10 ` Matthieu Moy
2014-05-06 17:34 ` Junio C Hamano
2014-05-06 18:00 ` David Kastrup
2014-05-06 18:49 ` Matthieu Moy
2014-05-06 21:55 ` Jeff King
2014-05-07 17:07 ` Junio C Hamano
2014-05-07 17:54 ` Matthieu Moy
2014-05-07 20:42 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vbtt6dyq.fsf@fencepost.gnu.org \
--to=dak@gnu$(echo .)org \
--cc=Matthieu.Moy@imag$(echo .)fr \
--cc=d9ba@mailtor$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox