From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>,
David Kastrup <dak@gnu•org>, Jonathan Nieder <jrnieder@gmail•com>,
git@vger•kernel.org, d9ba@mailtor•net
Subject: Re: [PATCH v2] pager: remove 'S' from $LESS by default
Date: Wed, 07 May 2014 10:07:29 -0700 [thread overview]
Message-ID: <xmqqy4ydbjqm.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140506215516.GA30185@sigill.intra.peff.net> (Jeff King's message of "Tue, 6 May 2014 17:55:16 -0400")
Jeff King <peff@peff•net> writes:
> On Tue, May 06, 2014 at 08:49:22PM +0200, Matthieu Moy wrote:
> ...
>> The idea of having a separate default value for pager.blame (or set
>> $LESS differently for blame) crossed my mind, but I actually don't like
>> it, as it would make it harder for a user to fine-tune his configuration
>> manually (one would have to cancel all the corner-cases that Git would
>> set by default).
>
> Agreed. We already get some confusion from users with "git has set $LESS
> for me". Changing it to "git set up $LESS depending on which command is
> running" seems like it would cause more of the same.
While I fully agree with the above conclusion, I just noticed that I
will be irritated enough to eventually set pager.blame myself, after
running a short "git blame -L1311,+7 git-p4.py", which is one of the
standard first steps for me to start reading patches submit on the
list.
Even with line wrapping, the output fits on a single page, so "F"
(aka "--quit-if-one-screen") kicks in, before giving me a chance to
scroll horizontally around.
Not objecting to the conclusion of the discussion with a concrete
counterproposal. Just hoping somebody clever enough might come up
with a good trick to make things easier to use and explain, which I
however suspect may be an incompatible pair of goals.
next prev parent reply other threads:[~2014-05-07 17:07 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 23:46 Harmful LESS flags d9ba
2014-04-24 0:11 ` Jonathan Nieder
2014-04-28 21:38 ` Mark Nudelman
2014-04-24 5:06 ` David Kastrup
2014-04-24 19:02 ` Junio C Hamano
2014-04-24 19:21 ` David Kastrup
2014-04-24 19:29 ` Junio C Hamano
2014-04-24 19:50 ` David Kastrup
2014-04-24 21:35 ` Jeff King
2014-04-24 21:47 ` Junio C Hamano
2014-04-24 22:02 ` Jeff King
2014-04-24 21:48 ` David Kastrup
2014-04-24 22:13 ` Jeff King
2014-04-24 22:44 ` David Kastrup
2014-04-24 23:08 ` Jonathan Nieder
2014-04-25 6:56 ` Matthieu Moy
2014-04-25 15:11 ` Jonathan Nieder
2014-04-25 15:32 ` David Kastrup
2014-04-25 15:47 ` Jonathan Nieder
2014-04-28 8:34 ` [PATCH] PAGER_ENV: remove 'S' from $LESS by default Matthieu Moy
2014-04-28 8:43 ` David Kastrup
2014-04-28 8:59 ` Matthieu Moy
2014-04-28 9:14 ` David Kastrup
2014-04-28 12:22 ` Matthieu Moy
2014-04-28 16:24 ` Jeff King
2014-04-28 18:48 ` Junio C Hamano
2014-04-29 12:29 ` Matthieu Moy
2014-04-29 17:01 ` Junio C Hamano
2014-04-30 7:35 ` [PATCH v2] pager: " Matthieu Moy
2014-04-30 15:38 ` Junio C Hamano
2014-04-30 15:49 ` Matthieu Moy
2014-04-30 17:34 ` Junio C Hamano
2014-05-05 18:44 ` Jonathan Nieder
2014-05-05 20:10 ` Matthieu Moy
2014-05-06 17:34 ` Junio C Hamano
2014-05-06 18:00 ` David Kastrup
2014-05-06 18:49 ` Matthieu Moy
2014-05-06 21:55 ` Jeff King
2014-05-07 17:07 ` Junio C Hamano [this message]
2014-05-07 17:54 ` Matthieu Moy
2014-05-07 20:42 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy4ydbjqm.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
--cc=d9ba@mailtor$(echo .)net \
--cc=dak@gnu$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox