public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: Jean-Noel Avila <jn.avila@free•fr>
Cc: git@vger•kernel.org
Subject: Re: [PATCHv2] Add hint interactive cleaning
Date: Mon, 02 Mar 2015 11:39:39 -0800	[thread overview]
Message-ID: <xmqq7fuzb344.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1425211105-18873-1-git-send-email-jn.avila@free.fr> (Jean-Noel Avila's message of "Sun, 1 Mar 2015 12:58:25 +0100")

Jean-Noel Avila <jn.avila@free•fr> writes:

> For translators, specify that a  y/N reply is needed.
>
> Signed-off-by: Jean-Noel Avila <jn.avila@free•fr>
> ---
>  builtin/clean.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/builtin/clean.c b/builtin/clean.c
> index 7e7fdcf..98c103f 100644
> --- a/builtin/clean.c
> +++ b/builtin/clean.c
> @@ -754,7 +754,8 @@ static int ask_each_cmd(void)
>  		/* Ctrl-D should stop removing files */
>  		if (!eof) {
>  			qname = quote_path_relative(item->string, NULL, &buf);
> -			printf(_("remove %s? "), qname);
> +			/* TRANSLATORS: Make sure to keep [y/N] as is */
> +			printf(_("Remove %s [y/N]? "), qname);
>  			if (strbuf_getline(&confirm, stdin, '\n') != EOF) {
>  				strbuf_trim(&confirm);
>  			} else {

Thanks. All other interactive prompts from this command
(i.e. menu_opts.prompt) seem to capitalize their first word, so
upcasing this message is a good change, too.

      reply	other threads:[~2015-03-02 19:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150212085211.9112780692@smtp-out.fingerprint.fr>
2015-02-23 15:46 ` Internationalization and yes/no prompts Pierre-Olivier Vares
2015-02-24 20:32   ` Junio C Hamano
2015-02-25  9:42     ` Jean-Noël Avila
2015-02-28 15:39     ` [PATCH] Add hint for translators for y/n reply Jean-Noel Avila
2015-03-01  0:18       ` Jiang Xin
2015-03-01  0:30         ` Jiang Xin
2015-03-01  4:02         ` Junio C Hamano
2015-03-01 11:58       ` [PATCHv2] Add hint interactive cleaning Jean-Noel Avila
2015-03-02 19:39         ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7fuzb344.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=jn.avila@free$(echo .)fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox