From: bod@kernel•org
To: Nihal Kumar Gupta <nihal.gupta@oss•qualcomm.com>
Cc: Bryan O'Donoghue <bod@kernel•org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro•org>,
Loic Poulain <loic.poulain@oss•qualcomm.com>,
Mauro Carvalho Chehab <mchehab@kernel•org>,
Rob Herring <robh@kernel•org>,
Krzysztof Kozlowski <krzk+dt@kernel•org>,
Conor Dooley <conor+dt@kernel•org>,
Robert Foss <rfoss@kernel•org>,
Andi Shyti <andi.shyti@kernel•org>,
Bryan O'Donoghue <bryan.odonoghue@linaro•org>,
Bjorn Andersson <andersson@kernel•org>,
Konrad Dybcio <konradybcio@kernel•org>,
Frank Li <Frank.Li@nxp•com>,
Sascha Hauer <s.hauer@pengutronix•de>,
Pengutronix Kernel Team <kernel@pengutronix•de>,
Fabio Estevam <festevam@gmail•com>,
linux-arm-msm@vger•kernel.org, linux-media@vger•kernel.org,
devicetree@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-i2c@vger•kernel.org, imx@lists•linux.dev,
linux-arm-kernel@lists•infradead.org,
Suresh Vankadara <quic_svankada@quicinc•com>,
Vikram Sharma <vikram.sharma@oss•qualcomm.com>
Subject: Re: [PATCH 5/8] arm64: dts: qcom: shikra: Add CCI definitions
Date: Thu, 28 May 2026 23:22:47 +0100 [thread overview]
Message-ID: <178000696709.4557.9615154244947019683.b4-reply@b4> (raw)
In-Reply-To: <20260526-shikra-camss-review-v1-5-645d2c8c75a7@qti.qualcomm.com>
On 2026-05-26 22:42 +0530, Nihal Kumar Gupta wrote:
> Qualcomm Shikra SoC has one Camera Control Interface (CCI)
> containing two I2C hosts.
>
> Signed-off-by: Nihal Kumar Gupta <nihal.gupta@oss•qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/shikra.dtsi | 70 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 70 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/shikra.dtsi b/arch/arm64/boot/dts/qcom/shikra.dtsi
> index 6c47cf2a7ef26b4bb7d7f642a240b435cf5208d8..46de35971f629ded990827ebd76134e652758ce3 100644
> --- a/arch/arm64/boot/dts/qcom/shikra.dtsi
> +++ b/arch/arm64/boot/dts/qcom/shikra.dtsi
> @@ -348,6 +348,38 @@ tlmm: pinctrl@500000 {
> gpio-ranges = <&tlmm 0 0 165>;
> wakeup-parent = <&mpm>;
>
> + cci_i2c0_default: cci-i2c0-default-state {
> + /* SDA, SCL */
> + pins = "gpio36", "gpio37";
> + function = "cci_i2c0";
> + drive-strength = <2>;
> + bias-pull-up;
> + };
> +
> + cci_i2c0_sleep: cci-i2c0-sleep-state {
> + /* SDA, SCL */
> + pins = "gpio36", "gpio37";
> + function = "cci_i2c0";
> + drive-strength = <2>;
> + bias-pull-down;
> + };
> +
> + cci_i2c1_default: cci-i2c1-default-state {
> + /* SDA, SCL */
> + pins = "gpio41", "gpio42";
> + function = "cci_i2c1";
> + drive-strength = <2>;
> + bias-pull-up;
> + };
> +
> + cci_i2c1_sleep: cci-i2c1-sleep-state {
> + /* SDA, SCL */
> + pins = "gpio41", "gpio42";
> + function = "cci_i2c1";
> + drive-strength = <2>;
> + bias-pull-down;
> + };
> +
> qup_uart0_default: qup-uart0-default-state {
> pins = "gpio0", "gpio1";
> function = "qup0_se0";
> @@ -701,6 +733,44 @@ port@1 {
> reg = <1>;
> };
> };
> +
> + };
> +
> + cci: cci@5c1b000 {
> + compatible = "qcom,shikra-cci", "qcom,msm8996-cci";
> + reg = <0x0 0x05c1b000 0x0 0x1000>;
> +
> + interrupts = <GIC_SPI 206 IRQ_TYPE_EDGE_RISING 0>;
> +
> + clocks = <&gcc GCC_CAMSS_TOP_AHB_CLK>,
> + <&gcc GCC_CAMSS_CCI_0_CLK>;
> + clock-names = "ahb",
> + "cci";
> +
> + power-domains = <&gcc GCC_CAMSS_TOP_GDSC>;
> +
> + pinctrl-0 = <&cci_i2c0_default &cci_i2c1_default>;
> + pinctrl-1 = <&cci_i2c0_sleep &cci_i2c1_sleep>;
> + pinctrl-names = "default", "sleep";
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + status = "disabled";
> +
> + cci_i2c0: i2c-bus@0 {
> + reg = <0>;
> + clock-frequency = <400000>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> +
> + cci_i2c1: i2c-bus@1 {
> + reg = <1>;
> + clock-frequency = <400000>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> };
>
> qupv3_0: geniqup@4ac0000 {
>
> --
> 2.34.1
>
>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro•org>
---
bod
next prev parent reply other threads:[~2026-05-28 22:23 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 17:12 [PATCH 0/8] Add CAMSS and IMX577 sensor support for Shikra EVK Nihal Kumar Gupta
2026-05-26 17:12 ` [PATCH 1/8] dt-bindings: media: qcom: Add Shikra CAMSS compatible Nihal Kumar Gupta
2026-05-28 22:08 ` bod
2026-05-30 11:34 ` Krzysztof Kozlowski
2026-06-01 6:44 ` Nihal Kumar Gupta
2026-05-26 17:12 ` [PATCH 2/8] dt-bindings: i2c: qcom-cci: Document Shikra compatible Nihal Kumar Gupta
2026-05-28 22:10 ` bod
2026-05-30 14:06 ` Wolfram Sang
2026-05-26 17:12 ` [PATCH 3/8] media: qcom: camss: add support for QCM2390 camss Nihal Kumar Gupta
2026-05-28 12:25 ` Loic Poulain
2026-05-29 15:00 ` Vikram Sharma
2026-05-28 22:13 ` bod
2026-06-01 13:30 ` Nihal Kumar Gupta
2026-05-26 17:12 ` [PATCH 4/8] arm64: dts: qcom: shikra: Add CAMSS node Nihal Kumar Gupta
2026-05-28 22:21 ` bod
2026-05-29 14:52 ` Vikram Sharma
2026-05-29 14:58 ` Bryan O'Donoghue
2026-06-01 6:42 ` Nihal Kumar Gupta
2026-06-01 14:15 ` Bryan O'Donoghue
2026-06-01 14:27 ` Loic Poulain
2026-06-01 14:58 ` Bryan O'Donoghue
2026-05-26 17:12 ` [PATCH 5/8] arm64: dts: qcom: shikra: Add CCI definitions Nihal Kumar Gupta
2026-05-28 22:22 ` bod [this message]
2026-05-26 17:12 ` [PATCH 6/8] arm64: dts: qcom: shikra: Add pin configuration for mclks Nihal Kumar Gupta
2026-05-26 17:12 ` [PATCH 7/8] arm64: dts: qcom: shikra-cqm-evk-imx577-camera: Add DT overlay Nihal Kumar Gupta
2026-05-28 22:25 ` bod
2026-05-28 22:28 ` bod
2026-05-29 17:30 ` Nihal Kumar Gupta
2026-05-29 22:57 ` Bryan O'Donoghue
2026-05-26 17:12 ` [PATCH 8/8] arm64: dts: qcom: shikra-iqs-evk-imx577-camera: " Nihal Kumar Gupta
2026-05-28 22:30 ` bod
2026-05-29 17:14 ` Nihal Kumar Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178000696709.4557.9615154244947019683.b4-reply@b4 \
--to=bod@kernel$(echo .)org \
--cc=Frank.Li@nxp$(echo .)com \
--cc=andersson@kernel$(echo .)org \
--cc=andi.shyti@kernel$(echo .)org \
--cc=bryan.odonoghue@linaro$(echo .)org \
--cc=conor+dt@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=festevam@gmail$(echo .)com \
--cc=imx@lists$(echo .)linux.dev \
--cc=kernel@pengutronix$(echo .)de \
--cc=konradybcio@kernel$(echo .)org \
--cc=krzk+dt@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-i2c@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=loic.poulain@oss$(echo .)qualcomm.com \
--cc=mchehab@kernel$(echo .)org \
--cc=nihal.gupta@oss$(echo .)qualcomm.com \
--cc=quic_svankada@quicinc$(echo .)com \
--cc=rfoss@kernel$(echo .)org \
--cc=robh@kernel$(echo .)org \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=vikram.sharma@oss$(echo .)qualcomm.com \
--cc=vladimir.zapolskiy@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox