From: Vikram Sharma <vikram.sharma@oss•qualcomm.com>
To: bod@kernel•org, Nihal Kumar Gupta <nihal.gupta@oss•qualcomm.com>
Cc: Vladimir Zapolskiy <vladimir.zapolskiy@linaro•org>,
Loic Poulain <loic.poulain@oss•qualcomm.com>,
Mauro Carvalho Chehab <mchehab@kernel•org>,
Rob Herring <robh@kernel•org>,
Krzysztof Kozlowski <krzk+dt@kernel•org>,
Conor Dooley <conor+dt@kernel•org>,
Robert Foss <rfoss@kernel•org>,
Andi Shyti <andi.shyti@kernel•org>,
Bryan O'Donoghue <bryan.odonoghue@linaro•org>,
Bjorn Andersson <andersson@kernel•org>,
Konrad Dybcio <konradybcio@kernel•org>,
Frank Li <Frank.Li@nxp•com>,
Sascha Hauer <s.hauer@pengutronix•de>,
Pengutronix Kernel Team <kernel@pengutronix•de>,
Fabio Estevam <festevam@gmail•com>,
linux-arm-msm@vger•kernel.org, linux-media@vger•kernel.org,
devicetree@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-i2c@vger•kernel.org, imx@lists•linux.dev,
linux-arm-kernel@lists•infradead.org,
Suresh Vankadara <quic_svankada@quicinc•com>
Subject: Re: [PATCH 4/8] arm64: dts: qcom: shikra: Add CAMSS node
Date: Fri, 29 May 2026 20:22:25 +0530 [thread overview]
Message-ID: <df00e8d8-21ab-415f-815e-608eb7ab0967@oss.qualcomm.com> (raw)
In-Reply-To: <178000689150.4557.11759359941436928903.b4-reply@b4>
On 5/29/2026 3:51 AM, bod@kernel•org wrote:
>> + iommus = <&apps_smmu 0x400 0x0>;
> So I'm suspicious of this IOMMU.
>
> We should list the full range of IFE SIDs here not a subset. Since we are
> register compatible with Agatti that implies to me we should also be IOMMU
> compatible.
Shikra and Agatti are not iommu compatible in terms of Stream ID. Only VFE SID is same
for both. Agatti is documenting iommu for VFE, CDM and OPE. OPE is not yet enabled for
Shikra and in my opinion it should be added as a separate yaml similar to Agatti.
"https://lore.kernel.org/all/20260508-camss-isp-ope-v3-9-bb1055274603@oss.qualcomm.com/"
Regarding cdm iommu we have excluded it as we do not use it to program registers as of now.
Loic/Bryan, Please share your thoughts on this?
> Please list in your next submission commit log the IOMMU SIDs - comment in
> the DTS is fine too.
Sure.
> Ideally list the IOMMus for Agatti/2290 and then explain why the singleton
> you have enumerated here is the only required one.
>
> Right now my suspicion radar is high that either the Agatti binding is
> wrong or the Shikra binding is.
>
> Possibly both.
Regards,
Vikram
next prev parent reply other threads:[~2026-05-29 14:52 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 17:12 [PATCH 0/8] Add CAMSS and IMX577 sensor support for Shikra EVK Nihal Kumar Gupta
2026-05-26 17:12 ` [PATCH 1/8] dt-bindings: media: qcom: Add Shikra CAMSS compatible Nihal Kumar Gupta
2026-05-28 22:08 ` bod
2026-05-30 11:34 ` Krzysztof Kozlowski
2026-06-01 6:44 ` Nihal Kumar Gupta
2026-05-26 17:12 ` [PATCH 2/8] dt-bindings: i2c: qcom-cci: Document Shikra compatible Nihal Kumar Gupta
2026-05-28 22:10 ` bod
2026-05-30 14:06 ` Wolfram Sang
2026-05-26 17:12 ` [PATCH 3/8] media: qcom: camss: add support for QCM2390 camss Nihal Kumar Gupta
2026-05-28 12:25 ` Loic Poulain
2026-05-29 15:00 ` Vikram Sharma
2026-05-28 22:13 ` bod
2026-06-01 13:30 ` Nihal Kumar Gupta
2026-05-26 17:12 ` [PATCH 4/8] arm64: dts: qcom: shikra: Add CAMSS node Nihal Kumar Gupta
2026-05-28 22:21 ` bod
2026-05-29 14:52 ` Vikram Sharma [this message]
2026-05-29 14:58 ` Bryan O'Donoghue
2026-06-01 6:42 ` Nihal Kumar Gupta
2026-06-01 14:15 ` Bryan O'Donoghue
2026-06-01 14:27 ` Loic Poulain
2026-06-01 14:58 ` Bryan O'Donoghue
2026-05-26 17:12 ` [PATCH 5/8] arm64: dts: qcom: shikra: Add CCI definitions Nihal Kumar Gupta
2026-05-28 22:22 ` bod
2026-05-26 17:12 ` [PATCH 6/8] arm64: dts: qcom: shikra: Add pin configuration for mclks Nihal Kumar Gupta
2026-05-26 17:12 ` [PATCH 7/8] arm64: dts: qcom: shikra-cqm-evk-imx577-camera: Add DT overlay Nihal Kumar Gupta
2026-05-28 22:25 ` bod
2026-05-28 22:28 ` bod
2026-05-29 17:30 ` Nihal Kumar Gupta
2026-05-29 22:57 ` Bryan O'Donoghue
2026-05-26 17:12 ` [PATCH 8/8] arm64: dts: qcom: shikra-iqs-evk-imx577-camera: " Nihal Kumar Gupta
2026-05-28 22:30 ` bod
2026-05-29 17:14 ` Nihal Kumar Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df00e8d8-21ab-415f-815e-608eb7ab0967@oss.qualcomm.com \
--to=vikram.sharma@oss$(echo .)qualcomm.com \
--cc=Frank.Li@nxp$(echo .)com \
--cc=andersson@kernel$(echo .)org \
--cc=andi.shyti@kernel$(echo .)org \
--cc=bod@kernel$(echo .)org \
--cc=bryan.odonoghue@linaro$(echo .)org \
--cc=conor+dt@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=festevam@gmail$(echo .)com \
--cc=imx@lists$(echo .)linux.dev \
--cc=kernel@pengutronix$(echo .)de \
--cc=konradybcio@kernel$(echo .)org \
--cc=krzk+dt@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-i2c@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=loic.poulain@oss$(echo .)qualcomm.com \
--cc=mchehab@kernel$(echo .)org \
--cc=nihal.gupta@oss$(echo .)qualcomm.com \
--cc=quic_svankada@quicinc$(echo .)com \
--cc=rfoss@kernel$(echo .)org \
--cc=robh@kernel$(echo .)org \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=vladimir.zapolskiy@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox