From: bod@kernel•org
To: Nihal Kumar Gupta <nihal.gupta@oss•qualcomm.com>
Cc: Bryan O'Donoghue <bod@kernel•org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro•org>,
Loic Poulain <loic.poulain@oss•qualcomm.com>,
Mauro Carvalho Chehab <mchehab@kernel•org>,
Rob Herring <robh@kernel•org>,
Krzysztof Kozlowski <krzk+dt@kernel•org>,
Conor Dooley <conor+dt@kernel•org>,
Robert Foss <rfoss@kernel•org>,
Andi Shyti <andi.shyti@kernel•org>,
Bryan O'Donoghue <bryan.odonoghue@linaro•org>,
Bjorn Andersson <andersson@kernel•org>,
Konrad Dybcio <konradybcio@kernel•org>,
Frank Li <Frank.Li@nxp•com>,
Sascha Hauer <s.hauer@pengutronix•de>,
Pengutronix Kernel Team <kernel@pengutronix•de>,
Fabio Estevam <festevam@gmail•com>,
linux-arm-msm@vger•kernel.org, linux-media@vger•kernel.org,
devicetree@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-i2c@vger•kernel.org, imx@lists•linux.dev,
linux-arm-kernel@lists•infradead.org,
Suresh Vankadara <quic_svankada@quicinc•com>,
Vikram Sharma <vikram.sharma@oss•qualcomm.com>
Subject: Re: [PATCH 7/8] arm64: dts: qcom: shikra-cqm-evk-imx577-camera: Add DT overlay
Date: Thu, 28 May 2026 23:28:34 +0100 [thread overview]
Message-ID: <178000731452.4557.8537369407478321842.b4-reply@b4> (raw)
In-Reply-To: <20260526-shikra-camss-review-v1-7-645d2c8c75a7@qti.qualcomm.com>
On 2026-05-26 22:42 +0530, Nihal Kumar Gupta wrote:
> Shikra CQM and CQS are retail variants sharing the same PM4125 PMIC
> and identical camera supply rails. The only difference between them
> is the integrated modem on CQM, which does not affect camera hardware.
>
> Add a shared overlay for optional IMX577 integration via CSIPHY1,
> used by both CQM and CQS EVK boards.
>
> Signed-off-by: Nihal Kumar Gupta <nihal.gupta@oss•qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/Makefile | 6 +++
> .../dts/qcom/shikra-cqm-evk-imx577-camera.dtso | 63 ++++++++++++++++++++++
> 2 files changed, 69 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index a9e9d829fb962386b3975f345ec006504607130a..df41830e18edff82893ca24ca84d7e03065d0ef7 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -337,6 +337,12 @@ dtb-$(CONFIG_ARCH_QCOM) += sdx75-idp.dtb
> dtb-$(CONFIG_ARCH_QCOM) += shikra-cqm-evk.dtb
> dtb-$(CONFIG_ARCH_QCOM) += shikra-cqs-evk.dtb
> dtb-$(CONFIG_ARCH_QCOM) += shikra-iqs-evk.dtb
> +
> +shikra-cqm-evk-imx577-camera-dtbs := shikra-cqm-evk.dtb shikra-cqm-evk-imx577-camera.dtbo
> +shikra-cqs-evk-imx577-camera-dtbs := shikra-cqs-evk.dtb shikra-cqm-evk-imx577-camera.dtbo
> +
> +dtb-$(CONFIG_ARCH_QCOM) += shikra-cqm-evk-imx577-camera.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += shikra-cqs-evk-imx577-camera.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm4250-oneplus-billie2.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm4450-qrd.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sm6115-fxtec-pro1x.dtb
> diff --git a/arch/arm64/boot/dts/qcom/shikra-cqm-evk-imx577-camera.dtso b/arch/arm64/boot/dts/qcom/shikra-cqm-evk-imx577-camera.dtso
> new file mode 100644
> index 0000000000000000000000000000000000000000..aedcd164810cf687efb425da79ace7ec6453e3a5
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/shikra-cqm-evk-imx577-camera.dtso
> @@ -0,0 +1,63 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + */
> +
> +/dts-v1/;
> +/plugin/;
> +
> +#include <dt-bindings/clock/qcom,shikra-gcc.h>
> +#include <dt-bindings/gpio/gpio.h>
> +
> +&camss {
> + vdd-csiphy-1p2-supply = <&pm4125_l5>;
> + vdd-csiphy-1p8-supply = <&pm4125_l13>;
> +
> + status = "okay";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@1 {
> + reg = <1>;
> +
> + csiphy1_ep: endpoint {
> + data-lanes = <0 1 2 3>;
> + remote-endpoint = <&imx577_ep1>;
> + };
> + };
> + };
> +};
> +
> +&cci {
> + status = "okay";
> +};
> +
> +&cci_i2c1 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + camera@1a {
> + compatible = "sony,imx577";
> + reg = <0x1a>;
> +
> + reset-gpios = <&tlmm 33 GPIO_ACTIVE_LOW>;
> + pinctrl-0 = <&mclk1_default>;
> + pinctrl-names = "default";
> +
> + clocks = <&gcc GCC_CAMSS_MCLK1_CLK>;
> + assigned-clocks = <&gcc GCC_CAMSS_MCLK1_CLK>;
> + assigned-clock-rates = <24000000>;
> +
> + dovdd-supply = <&pm4125_l15>;
> +
> + port {
> + imx577_ep1: endpoint {
> + link-frequencies = /bits/ 64 <600000000>;
> + data-lanes = <0 1 2 3>;
> + remote-endpoint = <&csiphy1_ep>;
> + };
> + };
> + };
> +};
>
> --
> 2.34.1
>
>
If the overlay is not specific to board then the overlay should have some
kind of base name shikra-evk-imx577-camera.dtb
This seems like a minor nit-pick and, it is :)
---
bod
next prev parent reply other threads:[~2026-05-28 22:28 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 17:12 [PATCH 0/8] Add CAMSS and IMX577 sensor support for Shikra EVK Nihal Kumar Gupta
2026-05-26 17:12 ` [PATCH 1/8] dt-bindings: media: qcom: Add Shikra CAMSS compatible Nihal Kumar Gupta
2026-05-28 22:08 ` bod
2026-05-30 11:34 ` Krzysztof Kozlowski
2026-06-01 6:44 ` Nihal Kumar Gupta
2026-05-26 17:12 ` [PATCH 2/8] dt-bindings: i2c: qcom-cci: Document Shikra compatible Nihal Kumar Gupta
2026-05-28 22:10 ` bod
2026-05-30 14:06 ` Wolfram Sang
2026-05-26 17:12 ` [PATCH 3/8] media: qcom: camss: add support for QCM2390 camss Nihal Kumar Gupta
2026-05-28 12:25 ` Loic Poulain
2026-05-29 15:00 ` Vikram Sharma
2026-05-28 22:13 ` bod
2026-06-01 13:30 ` Nihal Kumar Gupta
2026-05-26 17:12 ` [PATCH 4/8] arm64: dts: qcom: shikra: Add CAMSS node Nihal Kumar Gupta
2026-05-28 22:21 ` bod
2026-05-29 14:52 ` Vikram Sharma
2026-05-29 14:58 ` Bryan O'Donoghue
2026-06-01 6:42 ` Nihal Kumar Gupta
2026-06-01 14:15 ` Bryan O'Donoghue
2026-06-01 14:27 ` Loic Poulain
2026-06-01 14:58 ` Bryan O'Donoghue
2026-05-26 17:12 ` [PATCH 5/8] arm64: dts: qcom: shikra: Add CCI definitions Nihal Kumar Gupta
2026-05-28 22:22 ` bod
2026-05-26 17:12 ` [PATCH 6/8] arm64: dts: qcom: shikra: Add pin configuration for mclks Nihal Kumar Gupta
2026-05-26 17:12 ` [PATCH 7/8] arm64: dts: qcom: shikra-cqm-evk-imx577-camera: Add DT overlay Nihal Kumar Gupta
2026-05-28 22:25 ` bod
2026-05-28 22:28 ` bod [this message]
2026-05-29 17:30 ` Nihal Kumar Gupta
2026-05-29 22:57 ` Bryan O'Donoghue
2026-05-26 17:12 ` [PATCH 8/8] arm64: dts: qcom: shikra-iqs-evk-imx577-camera: " Nihal Kumar Gupta
2026-05-28 22:30 ` bod
2026-05-29 17:14 ` Nihal Kumar Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178000731452.4557.8537369407478321842.b4-reply@b4 \
--to=bod@kernel$(echo .)org \
--cc=Frank.Li@nxp$(echo .)com \
--cc=andersson@kernel$(echo .)org \
--cc=andi.shyti@kernel$(echo .)org \
--cc=bryan.odonoghue@linaro$(echo .)org \
--cc=conor+dt@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=festevam@gmail$(echo .)com \
--cc=imx@lists$(echo .)linux.dev \
--cc=kernel@pengutronix$(echo .)de \
--cc=konradybcio@kernel$(echo .)org \
--cc=krzk+dt@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-i2c@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=loic.poulain@oss$(echo .)qualcomm.com \
--cc=mchehab@kernel$(echo .)org \
--cc=nihal.gupta@oss$(echo .)qualcomm.com \
--cc=quic_svankada@quicinc$(echo .)com \
--cc=rfoss@kernel$(echo .)org \
--cc=robh@kernel$(echo .)org \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=vikram.sharma@oss$(echo .)qualcomm.com \
--cc=vladimir.zapolskiy@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox