From: Nihal Kumar Gupta <nihal.gupta@oss•qualcomm.com>
To: bod@kernel•org
Cc: Vladimir Zapolskiy <vladimir.zapolskiy@linaro•org>,
Loic Poulain <loic.poulain@oss•qualcomm.com>,
Mauro Carvalho Chehab <mchehab@kernel•org>,
Rob Herring <robh@kernel•org>,
Krzysztof Kozlowski <krzk+dt@kernel•org>,
Conor Dooley <conor+dt@kernel•org>,
Robert Foss <rfoss@kernel•org>,
Andi Shyti <andi.shyti@kernel•org>,
Bryan O'Donoghue <bryan.odonoghue@linaro•org>,
Bjorn Andersson <andersson@kernel•org>,
Konrad Dybcio <konradybcio@kernel•org>,
Frank Li <Frank.Li@nxp•com>,
Sascha Hauer <s.hauer@pengutronix•de>,
Pengutronix Kernel Team <kernel@pengutronix•de>,
Fabio Estevam <festevam@gmail•com>,
linux-arm-msm@vger•kernel.org, linux-media@vger•kernel.org,
devicetree@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-i2c@vger•kernel.org, imx@lists•linux.dev,
linux-arm-kernel@lists•infradead.org,
Suresh Vankadara <quic_svankada@quicinc•com>,
Vikram Sharma <vikram.sharma@oss•qualcomm.com>
Subject: Re: [PATCH 7/8] arm64: dts: qcom: shikra-cqm-evk-imx577-camera: Add DT overlay
Date: Fri, 29 May 2026 23:00:53 +0530 [thread overview]
Message-ID: <bc2aecf3-fedd-4b15-8e69-33ca928831d6@oss.qualcomm.com> (raw)
In-Reply-To: <178000731452.4557.8537369407478321842.b4-reply@b4>
On 29-05-2026 03:58, bod@kernel•org wrote:
> If the overlay is not specific to board then the overlay should have some
> kind of base name shikra-evk-imx577-camera.dtb
>
> This seems like a minor nit-pick and, it is 🙂
Thanks for the review!
The overlay is named after CQM because it's shared between CQM and CQS
both use PM4125 PMIC with identical camera supply rails. The only
difference between them is the integrated modem on CQM, which does not
affect camera hardware at all.
IQS uses PM8150 with different supply rails, so it needs its own overlay
and can't share with CQM/CQS. A generic shikra-evk-imx577-camera name
would be misleading since IQS is not compatible with this overlay.
Happy to rename to shikra-cqm-cqs-evk-imx577-camera if that makes the
shared scope clearer - open to suggestions.
------
Regards,
Nihal
next prev parent reply other threads:[~2026-05-29 17:31 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 17:12 [PATCH 0/8] Add CAMSS and IMX577 sensor support for Shikra EVK Nihal Kumar Gupta
2026-05-26 17:12 ` [PATCH 1/8] dt-bindings: media: qcom: Add Shikra CAMSS compatible Nihal Kumar Gupta
2026-05-28 22:08 ` bod
2026-05-30 11:34 ` Krzysztof Kozlowski
2026-06-01 6:44 ` Nihal Kumar Gupta
2026-05-26 17:12 ` [PATCH 2/8] dt-bindings: i2c: qcom-cci: Document Shikra compatible Nihal Kumar Gupta
2026-05-28 22:10 ` bod
2026-05-30 14:06 ` Wolfram Sang
2026-05-26 17:12 ` [PATCH 3/8] media: qcom: camss: add support for QCM2390 camss Nihal Kumar Gupta
2026-05-28 12:25 ` Loic Poulain
2026-05-29 15:00 ` Vikram Sharma
2026-05-28 22:13 ` bod
2026-06-01 13:30 ` Nihal Kumar Gupta
2026-05-26 17:12 ` [PATCH 4/8] arm64: dts: qcom: shikra: Add CAMSS node Nihal Kumar Gupta
2026-05-28 22:21 ` bod
2026-05-29 14:52 ` Vikram Sharma
2026-05-29 14:58 ` Bryan O'Donoghue
2026-06-01 6:42 ` Nihal Kumar Gupta
2026-06-01 14:15 ` Bryan O'Donoghue
2026-06-01 14:27 ` Loic Poulain
2026-06-01 14:58 ` Bryan O'Donoghue
2026-05-26 17:12 ` [PATCH 5/8] arm64: dts: qcom: shikra: Add CCI definitions Nihal Kumar Gupta
2026-05-28 22:22 ` bod
2026-05-26 17:12 ` [PATCH 6/8] arm64: dts: qcom: shikra: Add pin configuration for mclks Nihal Kumar Gupta
2026-05-26 17:12 ` [PATCH 7/8] arm64: dts: qcom: shikra-cqm-evk-imx577-camera: Add DT overlay Nihal Kumar Gupta
2026-05-28 22:25 ` bod
2026-05-28 22:28 ` bod
2026-05-29 17:30 ` Nihal Kumar Gupta [this message]
2026-05-29 22:57 ` Bryan O'Donoghue
2026-05-26 17:12 ` [PATCH 8/8] arm64: dts: qcom: shikra-iqs-evk-imx577-camera: " Nihal Kumar Gupta
2026-05-28 22:30 ` bod
2026-05-29 17:14 ` Nihal Kumar Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc2aecf3-fedd-4b15-8e69-33ca928831d6@oss.qualcomm.com \
--to=nihal.gupta@oss$(echo .)qualcomm.com \
--cc=Frank.Li@nxp$(echo .)com \
--cc=andersson@kernel$(echo .)org \
--cc=andi.shyti@kernel$(echo .)org \
--cc=bod@kernel$(echo .)org \
--cc=bryan.odonoghue@linaro$(echo .)org \
--cc=conor+dt@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=festevam@gmail$(echo .)com \
--cc=imx@lists$(echo .)linux.dev \
--cc=kernel@pengutronix$(echo .)de \
--cc=konradybcio@kernel$(echo .)org \
--cc=krzk+dt@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-i2c@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=loic.poulain@oss$(echo .)qualcomm.com \
--cc=mchehab@kernel$(echo .)org \
--cc=quic_svankada@quicinc$(echo .)com \
--cc=rfoss@kernel$(echo .)org \
--cc=robh@kernel$(echo .)org \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=vikram.sharma@oss$(echo .)qualcomm.com \
--cc=vladimir.zapolskiy@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox