From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] pinctrl: Add SPEAr pinctrl drivers
Date: Tue, 3 Apr 2012 19:37:33 +0000 [thread overview]
Message-ID: <201204031937.33897.arnd@arndb.de> (raw)
In-Reply-To: <4F7B2324.8000706@wwwdotorg.org>
On Tuesday 03 April 2012, Stephen Warren wrote:
> On 04/03/2012 07:47 AM, Arnd Bergmann wrote:
> > On Tuesday 03 April 2012, Viresh Kumar wrote:
> >> This adds pinctrl driver for SPEAr family. Currently it contains machine/SoC
> >> drivers for SPEAr3xx family only. SPEAr13xx family drivers will follow.
> >>
> >> Signed-off-by: Viresh Kumar <viresh.kumar@st•com>
> >
> > Hi Viresh,
> >
> > This is quite a lot of data, especially for the spear320. Have you
> > tried moving some or all of the data into device tree properties?
> >
> > I can only guess that the spear13xx file would be even larger than
> > these.
>
> Didn't we decide (at Linaro Connect) that is was perfectly acceptable to
> put this data into the pinctrl drivers; it's just going to get parsed
> out into exactly the same tables, and the data is presumably static for
> each SoC, and hence there's little point putting it into DT.
Yes, but it's also acceptable to put it into the device tree. It's mostly
a question of how you prioritise it as a maintainer. For platforms that
have a lot of different socs, it may make much more sense than it does
for those that only have a couple of different pincontrol variants.
> >> +/* pingroups */
> >> +static struct spear_pingroup *spear310_pingroups[] = {
> >> + SPEAR3XX_COMMON_PINGROUPS,
> >> + &emi_cs_0_to_5_pingroup,
> >> + &uart1_pingroup,
> >> + &uart2_pingroup,
> >> + &uart3_pingroup,
> >> + &uart4_pingroup,
> >> + &uart5_pingroup,
> >> + &fsmc_pingroup,
> >> + &rs485_0_pingroup,
> >> + &rs485_1_pingroup,
> >> + &tdm_pingroup,
> >> +};
> >> +
> >> +/* functions */
> >> +static struct spear_function *spear310_functions[] = {
> >> + SPEAR3XX_COMMON_FUNCTIONS,
> >> + &emi_cs_0_to_5_function,
> >> + &uart1_function,
> >> + &uart2_function,
> >> + &uart3_function,
> >> + &uart4_function,
> >> + &uart5_function,
> >> + &fsmc_function,
> >> + &rs485_0_function,
> >> + &rs485_1_function,
> >> + &tdm_function,
> >> +};
> >
> > I believe the macros like SPEAR3XX_COMMON_FUNCTIONS are not
> > needed any more, you can simply register multiple sets of pingroups
> > and functions.
>
> For a given pin controller, there's a single set of pins, groups, and
> functions; no incremental registration. You can register multiple pin
> controllers, but that only makes sense if there really are multiple
> physically separate pin controller modules in hardware.
Right, my fault. I confused this with pinmux_register_mappings, which
can be called multiple times.
Arnd
next prev parent reply other threads:[~2012-04-03 19:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <a1b7f612544a09989cec80a0318f35b6e48eb1d3.1333453148.git.viresh.kumar@st.com>
2012-04-03 13:47 ` [PATCH] pinctrl: Add SPEAr pinctrl drivers Arnd Bergmann
2012-04-03 14:10 ` viresh kumar
2012-04-03 17:09 ` viresh kumar
2012-04-03 19:33 ` Arnd Bergmann
2012-04-04 4:14 ` Viresh Kumar
2012-04-03 16:19 ` Stephen Warren
2012-04-03 19:37 ` Arnd Bergmann [this message]
2012-04-03 21:24 ` Linus Walleij
2012-04-03 22:43 ` Stephen Warren
2012-04-10 7:54 ` Linus Walleij
2012-04-04 7:45 ` Arnd Bergmann
2012-04-03 21:18 ` Linus Walleij
2012-04-04 4:17 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204031937.33897.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox