From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] pinctrl: Add SPEAr pinctrl drivers
Date: Tue, 03 Apr 2012 10:19:48 -0600 [thread overview]
Message-ID: <4F7B2324.8000706@wwwdotorg.org> (raw)
In-Reply-To: <201204031347.35256.arnd@arndb.de>
On 04/03/2012 07:47 AM, Arnd Bergmann wrote:
> On Tuesday 03 April 2012, Viresh Kumar wrote:
>> This adds pinctrl driver for SPEAr family. Currently it contains machine/SoC
>> drivers for SPEAr3xx family only. SPEAr13xx family drivers will follow.
>>
>> Signed-off-by: Viresh Kumar <viresh.kumar@st•com>
>
> Hi Viresh,
>
> This is quite a lot of data, especially for the spear320. Have you
> tried moving some or all of the data into device tree properties?
>
> I can only guess that the spear13xx file would be even larger than
> these.
Didn't we decide (at Linaro Connect) that is was perfectly acceptable to
put this data into the pinctrl drivers; it's just going to get parsed
out into exactly the same tables, and the data is presumably static for
each SoC, and hence there's little point putting it into DT.
>> +/* pingroups */
>> +static struct spear_pingroup *spear310_pingroups[] = {
>> + SPEAR3XX_COMMON_PINGROUPS,
>> + &emi_cs_0_to_5_pingroup,
>> + &uart1_pingroup,
>> + &uart2_pingroup,
>> + &uart3_pingroup,
>> + &uart4_pingroup,
>> + &uart5_pingroup,
>> + &fsmc_pingroup,
>> + &rs485_0_pingroup,
>> + &rs485_1_pingroup,
>> + &tdm_pingroup,
>> +};
>> +
>> +/* functions */
>> +static struct spear_function *spear310_functions[] = {
>> + SPEAR3XX_COMMON_FUNCTIONS,
>> + &emi_cs_0_to_5_function,
>> + &uart1_function,
>> + &uart2_function,
>> + &uart3_function,
>> + &uart4_function,
>> + &uart5_function,
>> + &fsmc_function,
>> + &rs485_0_function,
>> + &rs485_1_function,
>> + &tdm_function,
>> +};
>
> I believe the macros like SPEAR3XX_COMMON_FUNCTIONS are not
> needed any more, you can simply register multiple sets of pingroups
> and functions.
For a given pin controller, there's a single set of pins, groups, and
functions; no incremental registration. You can register multiple pin
controllers, but that only makes sense if there really are multiple
physically separate pin controller modules in hardware.
next prev parent reply other threads:[~2012-04-03 16:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <a1b7f612544a09989cec80a0318f35b6e48eb1d3.1333453148.git.viresh.kumar@st.com>
2012-04-03 13:47 ` [PATCH] pinctrl: Add SPEAr pinctrl drivers Arnd Bergmann
2012-04-03 14:10 ` viresh kumar
2012-04-03 17:09 ` viresh kumar
2012-04-03 19:33 ` Arnd Bergmann
2012-04-04 4:14 ` Viresh Kumar
2012-04-03 16:19 ` Stephen Warren [this message]
2012-04-03 19:37 ` Arnd Bergmann
2012-04-03 21:24 ` Linus Walleij
2012-04-03 22:43 ` Stephen Warren
2012-04-10 7:54 ` Linus Walleij
2012-04-04 7:45 ` Arnd Bergmann
2012-04-03 21:18 ` Linus Walleij
2012-04-04 4:17 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7B2324.8000706@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox