From: viresh.kumar@st•com (Viresh Kumar)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] pinctrl: Add SPEAr pinctrl drivers
Date: Wed, 4 Apr 2012 09:44:38 +0530 [thread overview]
Message-ID: <4F7BCAAE.9050306@st.com> (raw)
In-Reply-To: <201204031933.56131.arnd@arndb.de>
On 4/4/2012 1:03 AM, Arnd Bergmann wrote:
> Maybe I wasn't clear enough. I did not mean that code should be duplicated
> here. Instead, you should keep the probe function and export it, with some
> modifications, and do the same for the other common functions. This works
> well for a lot of other drivers in a similar situation. It would result
> in a function like
No. You were very clear earlier too. :)
> static int __devinit spear320_pinctrl_probe(struct platform_device *pdev)
> {
> return spear3xx_pinctrl_init(pdev, &spear320_machdata);
> }
>
> static struct of_device_id spear_pinctrl_of_match[] __devinitdata = {
> { .compatible = "st,spear320-pinmux" },
> {},
> };
>
> static struct platform_driver spear_pinctrl_driver = {
> .driver = {
> .name = DRIVER_NAME,
> .owner = THIS_MODULE,
> .of_match_table = spear_pinctrl_of_match,
> },
> .probe = spear320_pinctrl_probe,
> .remove = __devexit_p(spear_pinctrl_remove),
> };
I was worrying about duplicating above code. :)
Anyway, i have already fixed up my code as you suggested.
--
viresh
next prev parent reply other threads:[~2012-04-04 4:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <a1b7f612544a09989cec80a0318f35b6e48eb1d3.1333453148.git.viresh.kumar@st.com>
2012-04-03 13:47 ` [PATCH] pinctrl: Add SPEAr pinctrl drivers Arnd Bergmann
2012-04-03 14:10 ` viresh kumar
2012-04-03 17:09 ` viresh kumar
2012-04-03 19:33 ` Arnd Bergmann
2012-04-04 4:14 ` Viresh Kumar [this message]
2012-04-03 16:19 ` Stephen Warren
2012-04-03 19:37 ` Arnd Bergmann
2012-04-03 21:24 ` Linus Walleij
2012-04-03 22:43 ` Stephen Warren
2012-04-10 7:54 ` Linus Walleij
2012-04-04 7:45 ` Arnd Bergmann
2012-04-03 21:18 ` Linus Walleij
2012-04-04 4:17 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7BCAAE.9050306@st.com \
--to=viresh.kumar@st$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox