From: Jason Gunthorpe <jgg@nvidia•com>
To: "Tian, Kevin" <kevin.tian@intel•com>
Cc: Nicolin Chen <nicolinc@nvidia•com>,
"will@kernel•org" <will@kernel•org>,
"robin.murphy@arm•com" <robin.murphy@arm•com>,
"bhelgaas@google•com" <bhelgaas@google•com>,
"joro@8bytes•org" <joro@8bytes•org>,
"praan@google•com" <praan@google•com>,
"baolu.lu@linux•intel.com" <baolu.lu@linux•intel.com>,
"miko.lenczewski@arm•com" <miko.lenczewski@arm•com>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>,
"iommu@lists•linux.dev" <iommu@lists•linux.dev>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"linux-pci@vger•kernel.org" <linux-pci@vger•kernel.org>,
"Williams, Dan J" <dan.j.williams@intel•com>,
"jonathan.cameron@huawei•com" <jonathan.cameron@huawei•com>,
Vikram Sethi <vsethi@nvidia•com>,
"linux-cxl@vger•kernel.org" <linux-cxl@vger•kernel.org>
Subject: Re: [PATCH v3 3/3] iommu/arm-smmu-v3: Allow ATS to be always on
Date: Tue, 31 Mar 2026 09:08:16 -0300 [thread overview]
Message-ID: <20260331120816.GW310919@nvidia.com> (raw)
In-Reply-To: <BN9PR11MB52760A7F20A1CC2BC0DB018A8C53A@BN9PR11MB5276.namprd11.prod.outlook.com>
On Tue, Mar 31, 2026 at 08:40:17AM +0000, Tian, Kevin wrote:
> > From: Nicolin Chen <nicolinc@nvidia•com>
> > Sent: Saturday, March 7, 2026 7:41 AM
> >
> > +
> > + master->ats_always_on = true;
> > +
> > + ret = arm_smmu_alloc_cd_tables(master);
> > + if (ret)
> > + return ret;
> > +
> > +out_prepare:
> > + pci_prepare_ats(pdev, stu);
> > + return 0;
>
> is there a problem leaving ats_always_on being true while
> allocating cd tables fails?
I would expect this error flow unwinds back up to failing device
probe?
Jason
next prev parent reply other threads:[~2026-03-31 12:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 23:41 [PATCH v3 0/3] Allow ATS to be always on for certain ATS-capable devices Nicolin Chen
2026-03-06 23:41 ` [PATCH v3 1/3] PCI: Allow ATS to be always on for CXL.cache capable devices Nicolin Chen
2026-03-08 20:49 ` Nirmoy Das
2026-03-08 20:53 ` Nirmoy Das
2026-03-09 11:48 ` Jonathan Cameron
2026-03-26 21:38 ` Bjorn Helgaas
2026-03-26 21:51 ` Jason Gunthorpe
2026-03-30 12:48 ` Jason Gunthorpe
2026-03-31 8:19 ` Tian, Kevin
2026-04-09 22:45 ` Nicolin Chen
2026-04-09 22:52 ` Jason Gunthorpe
2026-04-10 0:04 ` Nicolin Chen
2026-04-10 3:13 ` Tian, Kevin
2026-04-10 12:05 ` Jason Gunthorpe
2026-04-13 6:40 ` Tian, Kevin
2026-03-06 23:41 ` [PATCH v3 2/3] PCI: Allow ATS to be always on for pre-CXL devices Nicolin Chen
2026-03-08 20:50 ` Nirmoy Das
2026-03-08 20:54 ` Nirmoy Das
2026-03-09 11:50 ` Jonathan Cameron
2026-03-30 12:49 ` Jason Gunthorpe
2026-03-31 8:24 ` Tian, Kevin
2026-03-06 23:41 ` [PATCH v3 3/3] iommu/arm-smmu-v3: Allow ATS to be always on Nicolin Chen
2026-03-08 20:52 ` Nirmoy Das
2026-03-30 12:51 ` Jason Gunthorpe
2026-03-31 8:40 ` Tian, Kevin
2026-03-31 12:08 ` Jason Gunthorpe [this message]
2026-04-01 8:15 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260331120816.GW310919@nvidia.com \
--to=jgg@nvidia$(echo .)com \
--cc=baolu.lu@linux$(echo .)intel.com \
--cc=bhelgaas@google$(echo .)com \
--cc=dan.j.williams@intel$(echo .)com \
--cc=iommu@lists$(echo .)linux.dev \
--cc=jonathan.cameron@huawei$(echo .)com \
--cc=joro@8bytes$(echo .)org \
--cc=kevin.tian@intel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-cxl@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=miko.lenczewski@arm$(echo .)com \
--cc=nicolinc@nvidia$(echo .)com \
--cc=praan@google$(echo .)com \
--cc=robin.murphy@arm$(echo .)com \
--cc=vsethi@nvidia$(echo .)com \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox