public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: emilio@elopez•com.ar (Emilio López)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/4] ARM: dts: sun7i: external clock outputs
Date: Mon, 23 Dec 2013 13:21:06 -0300	[thread overview]
Message-ID: <52B862F2.1020406@elopez.com.ar> (raw)
In-Reply-To: <1387787827-11341-3-git-send-email-wens@csie.org>

Hi,

El 23/12/13 05:37, Chen-Yu Tsai escribi?:
> This commit adds the two external clock outputs available on A20 to
> its device tree. A dummy fixed factor clock is also added to serve as
> the first input of the clock outputs, which according to AW's A20 user
> manual, is the 24MHz oscillator divided by 750.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie•org>
> ---
(,,,)
> +		clk_out_a: clk_out_a at 01c201f0 {
> +			#clock-cells = <0>;
> +			compatible = "allwinner,sun7i-a20-out-clk";
> +			reg = <0x01c201f0 0x4>;
> +			clocks = <&osc24M_32k>, <&osc32k>, <&osc24M>;
> +		};

These nodes should, as per Maxime's recommendation, look more like

	clk_out_a: clk at 01c201f0 {
		#clock-cells = <0>;
		compatible = "allwinner,sun7i-a20-out-clk";
		reg = <0x01c201f0 0x4>;
		clocks = <&osc24M_32k>, <&osc32k>, <&osc24M>;
		clk-output-names = "clk_out_a";
	};

Cheers,

Emilio

  reply	other threads:[~2013-12-23 16:21 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-23  8:37 [PATCH 0/4] clk: sunxi: add A20 external output clock support Chen-Yu Tsai
2013-12-23  8:37 ` [PATCH 1/4] clk: sunxi: Allwinner A20 " Chen-Yu Tsai
2013-12-23 16:13   ` Emilio López
2013-12-23 16:23     ` Emilio López
2013-12-23 19:34       ` Mike Turquette
2013-12-23  8:37 ` [PATCH 2/4] ARM: dts: sun7i: external clock outputs Chen-Yu Tsai
2013-12-23 16:21   ` Emilio López [this message]
2013-12-23 16:43     ` Chen-Yu Tsai
2013-12-23 16:52       ` Emilio López
2013-12-23  8:37 ` [PATCH 3/4] pinctrl: sunxi: Add Allwinner A20 clock output pin functions Chen-Yu Tsai
2013-12-23 16:33   ` Emilio López
2013-12-23  8:37 ` [PATCH 4/4] ARM: dts: sun7i: Add pin muxing options for clock outputs Chen-Yu Tsai
2013-12-23 16:44   ` Emilio López
2013-12-23 16:50     ` Chen-Yu Tsai
2013-12-23  8:37 ` [PATCH 0/4] clk: sunxi: add A20 external output clock support Chen-Yu Tsai
2013-12-24 13:26 ` Chen-Yu Tsai
2013-12-24 13:26   ` [PATCH 1/4] clk: sunxi: Allwinner A20 " Chen-Yu Tsai
2013-12-29 21:30     ` Mike Turquette
2013-12-29 21:35       ` Emilio López
2013-12-24 13:26   ` [PATCH 2/4] ARM: dts: sun7i: external clock outputs Chen-Yu Tsai
2013-12-24 13:26   ` [PATCH 3/4] pinctrl: sunxi: Add Allwinner A20 clock output pin functions Chen-Yu Tsai
2013-12-24 13:26   ` [PATCH 4/4] ARM: dts: sun7i: Add pin muxing options for clock outputs Chen-Yu Tsai
2013-12-29 20:59 ` [PATCH 0/4] clk: sunxi: add A20 external output clock support Maxime Ripard
2013-12-29 21:56   ` Mike Turquette
2013-12-30 15:12     ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B862F2.1020406@elopez.com.ar \
    --to=emilio@elopez$(echo .)com.ar \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox