From: emilio@elopez•com.ar (Emilio López)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/4] pinctrl: sunxi: Add Allwinner A20 clock output pin functions
Date: Mon, 23 Dec 2013 13:33:45 -0300 [thread overview]
Message-ID: <52B865E9.4040800@elopez.com.ar> (raw)
In-Reply-To: <1387787827-11341-4-git-send-email-wens@csie.org>
Hi,
El 23/12/13 05:37, Chen-Yu Tsai escribi?:
> Signed-off-by: Chen-Yu Tsai <wens@csie•org>
> ---
A commit description would be nice :) What are these outputs used for?
> drivers/pinctrl/pinctrl-sunxi-pins.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pinctrl/pinctrl-sunxi-pins.h b/drivers/pinctrl/pinctrl-sunxi-pins.h
> index 2c7446a..567bc44 100644
> --- a/drivers/pinctrl/pinctrl-sunxi-pins.h
> +++ b/drivers/pinctrl/pinctrl-sunxi-pins.h
> @@ -3774,12 +3774,14 @@ static const struct sunxi_desc_pin sun7i_a20_pins[] = {
> SUNXI_FUNCTION(0x1, "gpio_out"),
> SUNXI_FUNCTION(0x2, "spi0"), /* MOSI */
> SUNXI_FUNCTION(0x3, "uart6"), /* TX */
> + SUNXI_FUNCTION(0x4, "clk_out_a"),
I would add a /* comment */ here and below too, to keep in line with the
rest of the file, but this is just me nitpicking :)
> SUNXI_FUNCTION_IRQ(0x5, 24)), /* EINT24 */
> SUNXI_PIN(SUNXI_PINCTRL_PIN_PI13,
> SUNXI_FUNCTION(0x0, "gpio_in"),
> SUNXI_FUNCTION(0x1, "gpio_out"),
> SUNXI_FUNCTION(0x2, "spi0"), /* MISO */
> SUNXI_FUNCTION(0x3, "uart6"), /* RX */
> + SUNXI_FUNCTION(0x4, "clk_out_b"),
> SUNXI_FUNCTION_IRQ(0x5, 25)), /* EINT25 */
> SUNXI_PIN(SUNXI_PINCTRL_PIN_PI14,
> SUNXI_FUNCTION(0x0, "gpio_in"),
>
Cheers!
Emilio
next prev parent reply other threads:[~2013-12-23 16:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 8:37 [PATCH 0/4] clk: sunxi: add A20 external output clock support Chen-Yu Tsai
2013-12-23 8:37 ` [PATCH 1/4] clk: sunxi: Allwinner A20 " Chen-Yu Tsai
2013-12-23 16:13 ` Emilio López
2013-12-23 16:23 ` Emilio López
2013-12-23 19:34 ` Mike Turquette
2013-12-23 8:37 ` [PATCH 2/4] ARM: dts: sun7i: external clock outputs Chen-Yu Tsai
2013-12-23 16:21 ` Emilio López
2013-12-23 16:43 ` Chen-Yu Tsai
2013-12-23 16:52 ` Emilio López
2013-12-23 8:37 ` [PATCH 3/4] pinctrl: sunxi: Add Allwinner A20 clock output pin functions Chen-Yu Tsai
2013-12-23 16:33 ` Emilio López [this message]
2013-12-23 8:37 ` [PATCH 4/4] ARM: dts: sun7i: Add pin muxing options for clock outputs Chen-Yu Tsai
2013-12-23 16:44 ` Emilio López
2013-12-23 16:50 ` Chen-Yu Tsai
2013-12-23 8:37 ` [PATCH 0/4] clk: sunxi: add A20 external output clock support Chen-Yu Tsai
2013-12-24 13:26 ` Chen-Yu Tsai
2013-12-24 13:26 ` [PATCH 1/4] clk: sunxi: Allwinner A20 " Chen-Yu Tsai
2013-12-29 21:30 ` Mike Turquette
2013-12-29 21:35 ` Emilio López
2013-12-24 13:26 ` [PATCH 2/4] ARM: dts: sun7i: external clock outputs Chen-Yu Tsai
2013-12-24 13:26 ` [PATCH 3/4] pinctrl: sunxi: Add Allwinner A20 clock output pin functions Chen-Yu Tsai
2013-12-24 13:26 ` [PATCH 4/4] ARM: dts: sun7i: Add pin muxing options for clock outputs Chen-Yu Tsai
2013-12-29 20:59 ` [PATCH 0/4] clk: sunxi: add A20 external output clock support Maxime Ripard
2013-12-29 21:56 ` Mike Turquette
2013-12-30 15:12 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B865E9.4040800@elopez.com.ar \
--to=emilio@elopez$(echo .)com.ar \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox