public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: emilio@elopez•com.ar (Emilio López)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 4/4] ARM: dts: sun7i: Add pin muxing options for clock outputs
Date: Mon, 23 Dec 2013 13:44:12 -0300	[thread overview]
Message-ID: <52B8685C.3060001@elopez.com.ar> (raw)
In-Reply-To: <1387787827-11341-5-git-send-email-wens@csie.org>

Hi,

El 23/12/13 05:37, Chen-Yu Tsai escribi?:
> Signed-off-by: Chen-Yu Tsai <wens@csie•org>
> ---

Other than the lack of a commit description, the patch looks ok to me.

>   arch/arm/boot/dts/sun7i-a20.dtsi | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
> index 6ad5507..d6e7251 100644
> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> @@ -414,6 +414,20 @@
>   				allwinner,drive = <0>;
>   				allwinner,pull = <0>;
>   			};
> +
> +			clk_out_a_pins: clk_out_a {

I see the other nodes all start like

	foo_pins_a: foo0 at 0 {

Maybe yours should too? Maxime, thoughts?

> +				allwinner,pins = "PI12";
> +				allwinner,function = "clk_out_a";
> +				allwinner,drive = <0>;
> +				allwinner,pull = <0>;
> +			};
> +
> +			clk_out_b_pins: clk_out_b {
> +				allwinner,pins = "PI13";
> +				allwinner,function = "clk_out_b";
> +				allwinner,drive = <0>;
> +				allwinner,pull = <0>;
> +			};
>   		};
>
>   		timer at 01c20c00 {
>

Thanks for working on this!

Emilio

  reply	other threads:[~2013-12-23 16:44 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-23  8:37 [PATCH 0/4] clk: sunxi: add A20 external output clock support Chen-Yu Tsai
2013-12-23  8:37 ` [PATCH 1/4] clk: sunxi: Allwinner A20 " Chen-Yu Tsai
2013-12-23 16:13   ` Emilio López
2013-12-23 16:23     ` Emilio López
2013-12-23 19:34       ` Mike Turquette
2013-12-23  8:37 ` [PATCH 2/4] ARM: dts: sun7i: external clock outputs Chen-Yu Tsai
2013-12-23 16:21   ` Emilio López
2013-12-23 16:43     ` Chen-Yu Tsai
2013-12-23 16:52       ` Emilio López
2013-12-23  8:37 ` [PATCH 3/4] pinctrl: sunxi: Add Allwinner A20 clock output pin functions Chen-Yu Tsai
2013-12-23 16:33   ` Emilio López
2013-12-23  8:37 ` [PATCH 4/4] ARM: dts: sun7i: Add pin muxing options for clock outputs Chen-Yu Tsai
2013-12-23 16:44   ` Emilio López [this message]
2013-12-23 16:50     ` Chen-Yu Tsai
2013-12-23  8:37 ` [PATCH 0/4] clk: sunxi: add A20 external output clock support Chen-Yu Tsai
2013-12-24 13:26 ` Chen-Yu Tsai
2013-12-24 13:26   ` [PATCH 1/4] clk: sunxi: Allwinner A20 " Chen-Yu Tsai
2013-12-29 21:30     ` Mike Turquette
2013-12-29 21:35       ` Emilio López
2013-12-24 13:26   ` [PATCH 2/4] ARM: dts: sun7i: external clock outputs Chen-Yu Tsai
2013-12-24 13:26   ` [PATCH 3/4] pinctrl: sunxi: Add Allwinner A20 clock output pin functions Chen-Yu Tsai
2013-12-24 13:26   ` [PATCH 4/4] ARM: dts: sun7i: Add pin muxing options for clock outputs Chen-Yu Tsai
2013-12-29 20:59 ` [PATCH 0/4] clk: sunxi: add A20 external output clock support Maxime Ripard
2013-12-29 21:56   ` Mike Turquette
2013-12-30 15:12     ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B8685C.3060001@elopez.com.ar \
    --to=emilio@elopez$(echo .)com.ar \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox