From: t.figa@samsung•com (Tomasz Figa)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V4 5/5] usb-phy: samsung-usb3: Remove older phy-samsung-usb3 driver
Date: Wed, 09 Apr 2014 13:13:29 +0200 [thread overview]
Message-ID: <53452B59.8030901@samsung.com> (raw)
In-Reply-To: <1396967803-28868-6-git-send-email-gautam.vivek@samsung.com>
Hi Vivek,
On 08.04.2014 16:36, Vivek Gautam wrote:
> Removing this older USB 3.0 DRD controller PHY driver, since
> a new driver based on generic phy framework is now available.
>
> Also removing the dt node for older driver from Exynos5250
> device tree and updating the dt node for DWC3 controller.
>
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung•com>
> ---
>
> NOTE: This patch should be merged only when the new USB 3.0
> DRD phy controller driver is available in the tree from the
> patches:
> phy: Add new Exynos5 USB 3.0 PHY driver; and
> dt: exynos5250: Enable support for generic USB DRD phy
>
> arch/arm/boot/dts/exynos5250.dtsi | 17 +-
> drivers/usb/phy/phy-samsung-usb.h | 83 ---------
> drivers/usb/phy/phy-samsung-usb3.c | 350 ------------------------------------
> 3 files changed, 2 insertions(+), 448 deletions(-)
> delete mode 100644 drivers/usb/phy/phy-samsung-usb3.c
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 92c6fcd..1cb1e91 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
IMHO driver and dts changes should be separated into two patches, first
updating device tree to use the new driver and second removing the driver.
After fixing this issue,
Reviewed-by: Tomasz Figa <t.figa@samsung•com>
--
Best regards,
Tomasz
next prev parent reply other threads:[~2014-04-09 11:13 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 14:36 [PATCH V4 0/5] Add Exynos5 USB 3.0 phy driver based on generic PHY framework Vivek Gautam
2014-04-08 14:36 ` [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver Vivek Gautam
2014-04-09 11:06 ` Tomasz Figa
2014-04-09 11:49 ` Vivek Gautam
2014-04-09 13:33 ` Tomasz Figa
2014-04-10 11:39 ` Vivek Gautam
2014-04-15 6:09 ` Vivek Gautam
2014-04-16 13:44 ` Tomasz Figa
2014-04-16 14:49 ` Vivek Gautam
2014-04-22 2:18 ` Jingoo Han
2014-04-22 3:35 ` Vivek Gautam
2014-04-14 11:54 ` Kishon Vijay Abraham I
2014-04-14 12:05 ` Vivek Gautam
2014-04-14 13:05 ` Kishon Vijay Abraham I
2014-04-14 13:44 ` Tomasz Figa
2014-04-14 13:49 ` Vivek Gautam
2014-04-14 14:21 ` Sylwester Nawrocki
2014-04-15 5:07 ` Vivek Gautam
2014-04-14 12:27 ` Kishon Vijay Abraham I
2014-04-14 12:42 ` Vivek Gautam
2014-04-14 12:59 ` Kishon Vijay Abraham I
2014-04-14 13:20 ` Vivek Gautam
2014-04-14 13:26 ` Kishon Vijay Abraham I
2014-04-14 13:40 ` Vivek Gautam
2014-04-14 13:46 ` Vivek Gautam
2014-04-14 13:49 ` Tomasz Figa
2014-04-15 13:59 ` Kishon Vijay Abraham I
2014-04-14 14:37 ` Sylwester Nawrocki
2014-04-15 5:09 ` Vivek Gautam
2014-04-25 7:57 ` Tushar Behera
2014-04-25 8:08 ` Vivek Gautam
2014-04-08 14:36 ` [PATCH v4 2/5] dt: exynos5420: Enable support for USB 3.0 PHY controller Vivek Gautam
2014-04-09 11:10 ` Tomasz Figa
2014-04-08 14:36 ` [PATCH V4 3/5] dt: exynos5420: Enable support for DWC3 controller Vivek Gautam
2014-04-09 11:11 ` Tomasz Figa
2014-04-08 14:36 ` [PATCH V4 4/5] dt: exynos5250: Enable support for generic USB DRD phy Vivek Gautam
2014-04-09 11:11 ` Tomasz Figa
2014-04-08 14:36 ` [PATCH V4 5/5] usb-phy: samsung-usb3: Remove older phy-samsung-usb3 driver Vivek Gautam
2014-04-09 11:13 ` Tomasz Figa [this message]
2014-04-09 11:34 ` Vivek Gautam
2014-04-16 13:33 ` Richard Genoud
2014-04-16 14:42 ` Vivek Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53452B59.8030901@samsung.com \
--to=t.figa@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox