From: slash.tmp@free•fr (Mason)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] arm-soc: Add Sigma Designs Tango4 port
Date: Fri, 2 Oct 2015 18:33:48 +0200 [thread overview]
Message-ID: <560EB1EC.3020403@free.fr> (raw)
In-Reply-To: <yw1xoaghl099.fsf@unicorn.mansr.com>
On 02/10/2015 18:10, M?ns Rullg?rd wrote:
> Mason writes:
>
>> diff --git a/arch/arm/boot/dts/tango4.dtsi b/arch/arm/boot/dts/tango4.dtsi
>> new file mode 100644
>> index 000000000000..7336fcc3ac1d
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/tango4.dtsi
>
> Once more with feeling, why don't you want to use the fine clock driver
> I wrote?
I'll send you my clock tree driver next week. Then we can discuss.
>> + uart0 {
>> + compatible = "ralink,rt2880-uart";
>> + reg = <0x10700 0x100>;
>> + clock-frequency = <7372800>;
>> + reg-shift = <2>;
>> +/* fifo-size = <16>; BROKEN */
>
> Either fix whatever is broken or drop that line.
I can't leave TODO reminders in the platform Kconfig?
Even as comments?
>> + };
>> +
>> + eth0: eth0 {
>> + compatible = "sigma,smp8640-emac";
>> + reg = <0x26000 0x800>;
>> + interrupts = <38 4>;
>> + interrupt-parent = <&irq0>;
>> + mac-address = [ 00 16 e8 02 08 42 ];
>
> mac-address should not be hardcoded here or anywhere else.
Sorry. I missed that in my clean up.
>> + clocks = <&sysclk>;
>> + };
>> +
>> + intc: intc at e000 {
>> + compatible = "sigma,tango-intc";
>
> Why do you insist on using other names than the ones I've been using for
> months? Just want to leave your own mark on the code?
You're using "sigma,smp8640-intc".
The SMP8640 is a Tango3 (MIPS-based) platform.
It makes no sense to have references to Tango3 in tango4.dtsi
Aside from the CPU difference, Tango3 and Tango4 have a lot in common though.
Which reminds me that I forgot to change "sigma,smp8640-emac"
I'll send an updated patch.
Regards.
next prev parent reply other threads:[~2015-10-02 16:33 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 16:02 [PATCH] arm-soc: Add Sigma Designs Tango4 port Mason
2015-10-02 16:10 ` Måns Rullgård
2015-10-02 16:33 ` Mason [this message]
2015-10-02 16:55 ` Måns Rullgård
2015-10-02 18:00 ` Mason
2015-10-02 17:13 ` Russell King - ARM Linux
2015-10-02 18:09 ` Mason
2015-10-02 18:53 ` Russell King - ARM Linux
2015-10-02 19:25 ` Mason
2015-10-02 19:56 ` Arnd Bergmann
2015-10-02 20:53 ` Mason
2015-10-02 21:11 ` Arnd Bergmann
2015-10-02 21:57 ` Mason
2015-10-02 22:12 ` Arnd Bergmann
2015-10-05 16:25 ` [PATCH v2] arm-soc: Add support for Sigma Designs Tango4 Marc Gonzalez
2015-10-06 15:57 ` [PATCH v3] " Marc Gonzalez
2015-10-09 13:18 ` Arnd Bergmann
2015-10-09 13:30 ` Marc Gonzalez
2015-10-09 14:40 ` Måns Rullgård
2015-10-09 19:01 ` Mason
2015-10-09 20:24 ` Måns Rullgård
2015-10-09 21:12 ` Mason
2015-10-09 14:08 ` Rob Herring
2015-10-09 14:16 ` Marc Gonzalez
2015-10-09 14:48 ` Rob Herring
2015-10-13 15:54 ` Marc Gonzalez
2015-10-13 17:55 ` Rob Herring
2015-10-19 11:09 ` Marc Gonzalez
2015-10-19 16:39 ` Rob Herring
2015-10-19 17:32 ` Mark Rutland
2015-10-20 9:20 ` Marc Gonzalez
2015-10-20 9:50 ` Marc Gonzalez
2015-10-20 10:04 ` Russell King - ARM Linux
2015-10-20 10:54 ` Marc Gonzalez
2015-10-09 14:12 ` [PATCH v2] " Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560EB1EC.3020403@free.fr \
--to=slash.tmp@free$(echo .)fr \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox