From: slash.tmp@free•fr (Mason)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] arm-soc: Add Sigma Designs Tango4 port
Date: Fri, 2 Oct 2015 20:00:03 +0200 [thread overview]
Message-ID: <560EC623.4030300@free.fr> (raw)
In-Reply-To: <yw1xfv1tky6m.fsf@unicorn.mansr.com>
On 02/10/2015 18:55, M?ns Rullg?rd wrote:
> Mason writes:
>
>>>> + uart0 {
>>>> + compatible = "ralink,rt2880-uart";
>>>> + reg = <0x10700 0x100>;
>>>> + clock-frequency = <7372800>;
>>>> + reg-shift = <2>;
>>>> +/* fifo-size = <16>; BROKEN */
>>>
>>> Either fix whatever is broken or drop that line.
>>
>> I can't leave TODO reminders in the platform Kconfig [and DT files]?
>
> Never mind, I've sent a patch fixing the problem.
That's great news. Although back-porting to 3.14 is looking
more and more time-consuming. (But that's my problem.)
The question of comments in Kconfig and DT files still stands.
(No need to state your position again.)
>>>> + intc: intc at e000 {
>>>> + compatible = "sigma,tango-intc";
>>>
>>> Why do you insist on using other names than the ones I've been using for
>>> months? Just want to leave your own mark on the code?
>>
>> You're using "sigma,smp8640-intc".
>> The SMP8640 is a Tango3 (MIPS-based) platform.
>> It makes no sense to have references to Tango3 in tango4.dtsi
>> Aside from the CPU difference, Tango3 and Tango4 have a lot in common though.
>
> It's commonplace to refer to peripherals by the earliest (supported)
> chip using them. This avoids naming conflicts if a future chip uses a
> different component. Some bits are incompatible even between different
> devices in the tango3 family.
I'm confused. I like the way ARM did it in smp-twd.c
CLOCKSOURCE_OF_DECLARE(arm_twd_a9, "arm,cortex-a9-twd-timer", twd_local_timer_of_register);
CLOCKSOURCE_OF_DECLARE(arm_twd_a5, "arm,cortex-a5-twd-timer", twd_local_timer_of_register);
CLOCKSOURCE_OF_DECLARE(arm_twd_11mp, "arm,arm11mp-twd-timer", twd_local_timer_of_register);
They have several definitions for the different supported platforms.
They have several versions of the GIC:
IRQCHIP_DECLARE(gic_400, "arm,gic-400", gic_of_init);
IRQCHIP_DECLARE(arm11mp_gic, "arm,arm11mp-gic", gic_of_init);
IRQCHIP_DECLARE(arm1176jzf_dc_gic, "arm,arm1176jzf-devchip-gic", gic_of_init);
IRQCHIP_DECLARE(cortex_a15_gic, "arm,cortex-a15-gic", gic_of_init);
IRQCHIP_DECLARE(cortex_a9_gic, "arm,cortex-a9-gic", gic_of_init);
IRQCHIP_DECLARE(cortex_a7_gic, "arm,cortex-a7-gic", gic_of_init);
IRQCHIP_DECLARE(msm_8660_qgic, "qcom,msm-8660-qgic", gic_of_init);
IRQCHIP_DECLARE(msm_qgic2, "qcom,msm-qgic2", gic_of_init);
IRQCHIP_DECLARE(gic_v3, "arm,gic-v3", gic_of_init);
For example, I know the interrupt controller was changed for Tango5.
So I was planning on using:
"sigma,tango-intc" for Tango3/Tango4
"sigma,tango-intc-v2" for Tango5
Would you change your code to accommodate this nomenclature?
Regards.
next prev parent reply other threads:[~2015-10-02 18:00 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 16:02 [PATCH] arm-soc: Add Sigma Designs Tango4 port Mason
2015-10-02 16:10 ` Måns Rullgård
2015-10-02 16:33 ` Mason
2015-10-02 16:55 ` Måns Rullgård
2015-10-02 18:00 ` Mason [this message]
2015-10-02 17:13 ` Russell King - ARM Linux
2015-10-02 18:09 ` Mason
2015-10-02 18:53 ` Russell King - ARM Linux
2015-10-02 19:25 ` Mason
2015-10-02 19:56 ` Arnd Bergmann
2015-10-02 20:53 ` Mason
2015-10-02 21:11 ` Arnd Bergmann
2015-10-02 21:57 ` Mason
2015-10-02 22:12 ` Arnd Bergmann
2015-10-05 16:25 ` [PATCH v2] arm-soc: Add support for Sigma Designs Tango4 Marc Gonzalez
2015-10-06 15:57 ` [PATCH v3] " Marc Gonzalez
2015-10-09 13:18 ` Arnd Bergmann
2015-10-09 13:30 ` Marc Gonzalez
2015-10-09 14:40 ` Måns Rullgård
2015-10-09 19:01 ` Mason
2015-10-09 20:24 ` Måns Rullgård
2015-10-09 21:12 ` Mason
2015-10-09 14:08 ` Rob Herring
2015-10-09 14:16 ` Marc Gonzalez
2015-10-09 14:48 ` Rob Herring
2015-10-13 15:54 ` Marc Gonzalez
2015-10-13 17:55 ` Rob Herring
2015-10-19 11:09 ` Marc Gonzalez
2015-10-19 16:39 ` Rob Herring
2015-10-19 17:32 ` Mark Rutland
2015-10-20 9:20 ` Marc Gonzalez
2015-10-20 9:50 ` Marc Gonzalez
2015-10-20 10:04 ` Russell King - ARM Linux
2015-10-20 10:54 ` Marc Gonzalez
2015-10-09 14:12 ` [PATCH v2] " Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560EC623.4030300@free.fr \
--to=slash.tmp@free$(echo .)fr \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox