* linux-next: leds tree build failure
@ 2008-10-21 4:47 Stephen Rothwell
2008-10-21 8:19 ` Pavel Machek
2008-10-23 21:46 ` Richard Purdie
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Rothwell @ 2008-10-21 4:47 UTC (permalink / raw)
To: Richard Purdie; +Cc: linux-next, Pavel Machek, Len Brown, Andrew Morton
Hi Richard,
Today's linux-next build (x86_64 allmodconfig) failed like this:
drivers/leds/leds-hp-disk.c: In function 'hpled_add':
drivers/leds/leds-hp-disk.c:101: error: invalid lvalue in assignment
Caused by commit 9c78ff6e65cad9f9fcf0bbde2bfbbf3a544fb704 ("leds: Add
driver for HP harddisk protection LEDs") from the leds tree inertacting
with commit db89b4f0dbab837d0f3de2c3e9427a8d5393afa3 ("ACPI: catch calls
of acpi_driver_data on pointer of wrong type") from the acpi tree.
I fixed it up (see below).
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/
From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Tue, 21 Oct 2008 15:44:45 +1100
Subject: [PATCH] leds/acpi: fix merge fallout from acpi_driver_data change
Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
drivers/leds/leds-hp-disk.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/leds/leds-hp-disk.c b/drivers/leds/leds-hp-disk.c
index d636280..53a25b1 100644
--- a/drivers/leds/leds-hp-disk.c
+++ b/drivers/leds/leds-hp-disk.c
@@ -98,7 +98,7 @@ static int hpled_add(struct acpi_device *device)
adev.device = device;
strcpy(acpi_device_name(device), DRIVER_NAME);
strcpy(acpi_device_class(device), ACPI_MDPS_CLASS);
- acpi_driver_data(device) = &adev;
+ device->driver_data = &adev;
ret = led_classdev_register(NULL, &hpled_led);
return ret;
--
1.5.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: linux-next: leds tree build failure
2008-10-21 4:47 linux-next: leds tree build failure Stephen Rothwell
@ 2008-10-21 8:19 ` Pavel Machek
2008-10-23 21:46 ` Richard Purdie
1 sibling, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2008-10-21 8:19 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Richard Purdie, linux-next, Len Brown, Andrew Morton
> Hi Richard,
>
> Today's linux-next build (x86_64 allmodconfig) failed like this:
>
> drivers/leds/leds-hp-disk.c: In function 'hpled_add':
> drivers/leds/leds-hp-disk.c:101: error: invalid lvalue in assignment
>
> Caused by commit 9c78ff6e65cad9f9fcf0bbde2bfbbf3a544fb704 ("leds: Add
> driver for HP harddisk protection LEDs") from the leds tree inertacting
> with commit db89b4f0dbab837d0f3de2c3e9427a8d5393afa3 ("ACPI: catch calls
> of acpi_driver_data on pointer of wrong type") from the acpi tree.
>
> I fixed it up (see below).
ACK. (And thanks!)
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: linux-next: leds tree build failure
2008-10-21 4:47 linux-next: leds tree build failure Stephen Rothwell
2008-10-21 8:19 ` Pavel Machek
@ 2008-10-23 21:46 ` Richard Purdie
1 sibling, 0 replies; 3+ messages in thread
From: Richard Purdie @ 2008-10-23 21:46 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, Pavel Machek, Len Brown, Andrew Morton
Hi Stephen,
On Tue, 2008-10-21 at 15:47 +1100, Stephen Rothwell wrote:
> Today's linux-next build (x86_64 allmodconfig) failed like this:
>
> drivers/leds/leds-hp-disk.c: In function 'hpled_add':
> drivers/leds/leds-hp-disk.c:101: error: invalid lvalue in assignment
>
> Caused by commit 9c78ff6e65cad9f9fcf0bbde2bfbbf3a544fb704 ("leds: Add
> driver for HP harddisk protection LEDs") from the leds tree inertacting
> with commit db89b4f0dbab837d0f3de2c3e9427a8d5393afa3 ("ACPI: catch calls
> of acpi_driver_data on pointer of wrong type") from the acpi tree.
>
> I fixed it up (see below).
Thanks for spotting that and fixing. I've added the fix to the tree
before I sent the pull request.
Cheers,
Richard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-10-23 21:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-21 4:47 linux-next: leds tree build failure Stephen Rothwell
2008-10-21 8:19 ` Pavel Machek
2008-10-23 21:46 ` Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox