* [PTCH -next] i2o: fix kernel-doc warnings
@ 2008-10-22 23:38 Randy Dunlap
2008-10-27 20:14 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2008-10-22 23:38 UTC (permalink / raw)
To: linux-next; +Cc: akpm, viro
From: Randy Dunlap <randy.dunlap@oracle•com>
Fixup i2o kernel-doc warnings:
Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:579): No description found for parameter 'bdev'
Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:579): No description found for parameter 'mode'
Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:608): No description found for parameter 'disk'
Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:608): No description found for parameter 'mode'
Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:657): No description found for parameter 'bdev'
Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:657): No description found for parameter 'mode'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
cc: Al Viro <viro@zeniv•linux.org.uk>
---
drivers/message/i2o/i2o_block.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
--- linux-next-20081022.orig/drivers/message/i2o/i2o_block.c
+++ linux-next-20081022/drivers/message/i2o/i2o_block.c
@@ -567,8 +567,8 @@ static void i2o_block_biosparam(unsigned
/**
* i2o_block_open - Open the block device
- * @inode: inode for block device being opened
- * @file: file to open
+ * @bdev: block device being opened
+ * @mode: file open mode
*
* Power up the device, mount and lock the media. This function is called,
* if the block device is opened for access.
@@ -596,8 +596,8 @@ static int i2o_block_open(struct block_d
/**
* i2o_block_release - Release the I2O block device
- * @inode: inode for block device being released
- * @file: file to close
+ * @disk: gendisk device being released
+ * @mode: file open mode
*
* Unlock and unmount the media, and power down the device. Gets called if
* the block device is closed.
@@ -643,8 +643,8 @@ static int i2o_block_getgeo(struct block
/**
* i2o_block_ioctl - Issue device specific ioctl calls.
- * @inode: inode for block device ioctl
- * @file: file for ioctl
+ * @bdev: block device being opened
+ * @mode: file open mode
* @cmd: ioctl command
* @arg: arg
*
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PTCH -next] i2o: fix kernel-doc warnings
2008-10-22 23:38 [PTCH -next] i2o: fix kernel-doc warnings Randy Dunlap
@ 2008-10-27 20:14 ` Andrew Morton
2008-10-27 20:58 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2008-10-27 20:14 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-next, viro
On Wed, 22 Oct 2008 16:38:38 -0700
Randy Dunlap <rdunlap@xenotime•net> wrote:
> From: Randy Dunlap <randy.dunlap@oracle•com>
>
> Fixup i2o kernel-doc warnings:
>
> Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:579): No description found for parameter 'bdev'
> Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:579): No description found for parameter 'mode'
> Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:608): No description found for parameter 'disk'
> Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:608): No description found for parameter 'mode'
> Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:657): No description found for parameter 'bdev'
> Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:657): No description found for parameter 'mode'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
> cc: Al Viro <viro@zeniv•linux.org.uk>
> ---
> drivers/message/i2o/i2o_block.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> --- linux-next-20081022.orig/drivers/message/i2o/i2o_block.c
> +++ linux-next-20081022/drivers/message/i2o/i2o_block.c
> @@ -567,8 +567,8 @@ static void i2o_block_biosparam(unsigned
>
> /**
> * i2o_block_open - Open the block device
> - * @inode: inode for block device being opened
> - * @file: file to open
> + * @bdev: block device being opened
> + * @mode: file open mode
> *
> * Power up the device, mount and lock the media. This function is called,
> * if the block device is opened for access.
> @@ -596,8 +596,8 @@ static int i2o_block_open(struct block_d
>
> /**
> * i2o_block_release - Release the I2O block device
> - * @inode: inode for block device being released
> - * @file: file to close
> + * @disk: gendisk device being released
> + * @mode: file open mode
> *
> * Unlock and unmount the media, and power down the device. Gets called if
> * the block device is closed.
> @@ -643,8 +643,8 @@ static int i2o_block_getgeo(struct block
>
> /**
> * i2o_block_ioctl - Issue device specific ioctl calls.
> - * @inode: inode for block device ioctl
> - * @file: file for ioctl
> + * @bdev: block device being opened
> + * @mode: file open mode
> * @cmd: ioctl command
> * @arg: arg
>From my reading this is needed in current mainline?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PTCH -next] i2o: fix kernel-doc warnings
2008-10-27 20:14 ` Andrew Morton
@ 2008-10-27 20:58 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2008-10-27 20:58 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-next, viro
On Mon, 27 Oct 2008 13:14:01 -0700
Andrew Morton <akpm@linux-foundation•org> wrote:
> On Wed, 22 Oct 2008 16:38:38 -0700
> Randy Dunlap <rdunlap@xenotime•net> wrote:
>
> > From: Randy Dunlap <randy.dunlap@oracle•com>
> >
> > Fixup i2o kernel-doc warnings:
> >
> > Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:579): No description found for parameter 'bdev'
> > Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:579): No description found for parameter 'mode'
> > Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:608): No description found for parameter 'disk'
> > Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:608): No description found for parameter 'mode'
> > Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:657): No description found for parameter 'bdev'
> > Warning(linux-next-20081022//drivers/message/i2o/i2o_block.c:657): No description found for parameter 'mode'
> >
> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
> > cc: Al Viro <viro@zeniv•linux.org.uk>
> > ---
> > drivers/message/i2o/i2o_block.c | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > --- linux-next-20081022.orig/drivers/message/i2o/i2o_block.c
> > +++ linux-next-20081022/drivers/message/i2o/i2o_block.c
> > @@ -567,8 +567,8 @@ static void i2o_block_biosparam(unsigned
> >
> > /**
> > * i2o_block_open - Open the block device
> > - * @inode: inode for block device being opened
> > - * @file: file to open
> > + * @bdev: block device being opened
> > + * @mode: file open mode
> > *
> > * Power up the device, mount and lock the media. This function is called,
> > * if the block device is opened for access.
> > @@ -596,8 +596,8 @@ static int i2o_block_open(struct block_d
> >
> > /**
> > * i2o_block_release - Release the I2O block device
> > - * @inode: inode for block device being released
> > - * @file: file to close
> > + * @disk: gendisk device being released
> > + * @mode: file open mode
> > *
> > * Unlock and unmount the media, and power down the device. Gets called if
> > * the block device is closed.
> > @@ -643,8 +643,8 @@ static int i2o_block_getgeo(struct block
> >
> > /**
> > * i2o_block_ioctl - Issue device specific ioctl calls.
> > - * @inode: inode for block device ioctl
> > - * @file: file for ioctl
> > + * @bdev: block device being opened
> > + * @mode: file open mode
> > * @cmd: ioctl command
> > * @arg: arg
>
> From my reading this is needed in current mainline?
True. Al's -next patch (git tree) was merged into mainline.
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-10-27 20:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-22 23:38 [PTCH -next] i2o: fix kernel-doc warnings Randy Dunlap
2008-10-27 20:14 ` Andrew Morton
2008-10-27 20:58 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox