* next-20091029: fs/aio.c build failure
@ 2009-10-29 12:40 Alexander Beregalov
2009-10-29 12:56 ` Jens Axboe
0 siblings, 1 reply; 4+ messages in thread
From: Alexander Beregalov @ 2009-10-29 12:40 UTC (permalink / raw)
To: linux-next, jmoyer, jens.axboe
Hi
fs/aio.c:1575: error: implicit declaration of function 'blk_run_address_space'
CONFIG_BLOCK is not set.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: next-20091029: fs/aio.c build failure
2009-10-29 12:40 next-20091029: fs/aio.c build failure Alexander Beregalov
@ 2009-10-29 12:56 ` Jens Axboe
2009-10-29 13:01 ` Jens Axboe
0 siblings, 1 reply; 4+ messages in thread
From: Jens Axboe @ 2009-10-29 12:56 UTC (permalink / raw)
To: Alexander Beregalov; +Cc: linux-next, jmoyer
On Thu, Oct 29 2009, Alexander Beregalov wrote:
> Hi
>
> fs/aio.c:1575: error: implicit declaration of function 'blk_run_address_space'
>
> CONFIG_BLOCK is not set.
Not the first time this has happened, I think we should just pull the
bdi/mapping unplug functions out of CONFIG_BLOCK protection. They work
on the backing_dev, so they aren't inherently tied to just block IO.
This should fix it, I'll test and commit.
diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
index b449e73..fcbc26a 100644
--- a/include/linux/backing-dev.h
+++ b/include/linux/backing-dev.h
@@ -331,4 +331,17 @@ static inline int bdi_sched_wait(void *word)
return 0;
}
+static inline void blk_run_backing_dev(struct backing_dev_info *bdi,
+ struct page *page)
+{
+ if (bdi && bdi->unplug_io_fn)
+ bdi->unplug_io_fn(bdi, page);
+}
+
+static inline void blk_run_address_space(struct address_space *mapping)
+{
+ if (mapping)
+ blk_run_backing_dev(mapping->backing_dev_info, NULL);
+}
+
#endif /* _LINUX_BACKING_DEV_H */
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 221cecd..39c601f 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -823,19 +823,6 @@ static inline struct request_queue *bdev_get_queue(struct block_device *bdev)
return bdev->bd_disk->queue;
}
-static inline void blk_run_backing_dev(struct backing_dev_info *bdi,
- struct page *page)
-{
- if (bdi && bdi->unplug_io_fn)
- bdi->unplug_io_fn(bdi, page);
-}
-
-static inline void blk_run_address_space(struct address_space *mapping)
-{
- if (mapping)
- blk_run_backing_dev(mapping->backing_dev_info, NULL);
-}
-
/*
* blk_rq_pos() : the current sector
* blk_rq_bytes() : bytes left in the entire request
--
Jens Axboe
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: next-20091029: fs/aio.c build failure
2009-10-29 12:56 ` Jens Axboe
@ 2009-10-29 13:01 ` Jens Axboe
2009-10-29 13:07 ` Jeff Moyer
0 siblings, 1 reply; 4+ messages in thread
From: Jens Axboe @ 2009-10-29 13:01 UTC (permalink / raw)
To: Alexander Beregalov; +Cc: linux-next, jmoyer
On Thu, Oct 29 2009, Jens Axboe wrote:
> On Thu, Oct 29 2009, Alexander Beregalov wrote:
> > Hi
> >
> > fs/aio.c:1575: error: implicit declaration of function 'blk_run_address_space'
> >
> > CONFIG_BLOCK is not set.
>
> Not the first time this has happened, I think we should just pull the
> bdi/mapping unplug functions out of CONFIG_BLOCK protection. They work
> on the backing_dev, so they aren't inherently tied to just block IO.
I committed this:
http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=b9d128f1088ea5245109dfc9bbceb128b6371a77
Same as the posted version, but adds the backing-dev.h include to
fs/aio.c to make it visible as well. Passes compile/link testing here,
for both CONFIG_BLOCk and !CONFIG_BLOCK.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: next-20091029: fs/aio.c build failure
2009-10-29 13:01 ` Jens Axboe
@ 2009-10-29 13:07 ` Jeff Moyer
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Moyer @ 2009-10-29 13:07 UTC (permalink / raw)
To: Jens Axboe; +Cc: Alexander Beregalov, linux-next
Jens Axboe <jens.axboe@oracle•com> writes:
> On Thu, Oct 29 2009, Jens Axboe wrote:
>> On Thu, Oct 29 2009, Alexander Beregalov wrote:
>> > Hi
>> >
>> > fs/aio.c:1575: error: implicit declaration of function 'blk_run_address_space'
>> >
>> > CONFIG_BLOCK is not set.
>>
>> Not the first time this has happened, I think we should just pull the
>> bdi/mapping unplug functions out of CONFIG_BLOCK protection. They work
>> on the backing_dev, so they aren't inherently tied to just block IO.
>
> I committed this:
>
> http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=b9d128f1088ea5245109dfc9bbceb128b6371a77
>
> Same as the posted version, but adds the backing-dev.h include to
> fs/aio.c to make it visible as well. Passes compile/link testing here,
> for both CONFIG_BLOCk and !CONFIG_BLOCK.
Thanks for fixing that, Jens!
Acked-by: Jeff Moyer <jmoyer@redhat•com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-10-29 13:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-29 12:40 next-20091029: fs/aio.c build failure Alexander Beregalov
2009-10-29 12:56 ` Jens Axboe
2009-10-29 13:01 ` Jens Axboe
2009-10-29 13:07 ` Jeff Moyer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox